oak-team/oak-gpui
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,839 Commits 1 Branch 0 Tags
94293b3bf92fb5a85eb28f157f17052d41bf526e
Commit Graph
16839 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kirill BulatovandPiotr 41bc49af36 Remove redundant install Rust steps 
Those were not installing Rust but configuring it via rustup, and
those configurations were done on `stable` toolchain which is not what we use (see rust-toolchain.toml)

co-authored-by: Piotr <piotr@zed.dev>
 2024-01-11 14:11:13 +02:00
Kirill BulatovandPiotr a5dd2535f1 Properly require clippy installation, try to shuffle clippy arguments 
co-authored-by: Piotr <piotr@zed.dev>
 2024-01-11 13:56:28 +02:00
Antonio Scandurra d088ace404 Explicitly push a node in the dispatch tree when painting a new view 2024-01-11 12:48:05 +01:00
Piotr Osiewicz 1200f595a3 Try to run clippy just for a single target 2024-01-11 12:36:45 +01:00
Antonio Scandurra 142a8b68c8 Avoid casting view ids to u32 
Also, it looks like using a u64 directly doesn't work well with Metal
shaders, so we unpack the u64 into two u32s.
 2024-01-11 12:28:48 +01:00
Piotr Osiewicz 0db7559e96 editor: extend diff hunk range for custom transform blocks. (#4012) 
Reported by Mikayla:

![image](https://github.com/zed-industries/zed/assets/24362066/b744d82e-328f-4554-becf-96f9fa92bfc8)
Note how the line with rust analyzer error does not have a git diff
hunk.
vs:

![image](https://github.com/zed-industries/zed/assets/24362066/e285af7a-b8ab-40e9-a9c6-b4ab8d6c4cd0)

Release Notes:
- N/A
 2024-01-11 12:26:12 +01:00
Mikayla 6503dd51dd enviroment -> environment 2024-01-10 22:57:58 -08:00
Joseph T. Lyons 0df4bfacc2 Increase debug mode queue size 2024-01-11 01:12:49 -05:00
Joseph T. Lyons 8a61d5059b Never send an an empty set of events 2024-01-11 01:12:30 -05:00
Conrad Irwin f418bd907d Stop following when project is unshared 
Before this change the views would continue to update in the background
of the "disconnected" dialogue, which was disconcerting.
 2024-01-10 23:09:09 -07:00
Mikayla Maki 31689c09e5 Uncomment last tests (#4009) 
With this, we're done all known things that need porting. 

Release Notes:

-
 2024-01-10 20:00:14 -08:00
Mikayla 83163a0031 Reverse context arrays in child predicate test 2024-01-10 19:54:39 -08:00
MikaylaandConrad 38396d4281 Add remaining tests 
co-authored-by: Conrad <conrad@zed.dev>
 2024-01-10 19:39:43 -08:00
Mikayla a5ca58354d Fix first few asserts 2024-01-10 18:26:01 -08:00
Joseph T. Lyons bddf827bc1 Add reminder for the future 2024-01-10 21:02:34 -05:00
Mikayla Maki 44969460cd Remove remaining port related todos (#3994) 
TODO:
- [x] Audit all TODO comments in Zed source and mark port related ones
with a !
- [x] Resolve all todos written as `todo!`

Release Notes:

- N/A
 2024-01-10 17:31:05 -08:00
Max Brunsfeld cb5d4edc4b Handle reconnects to the livekit server in which local tracks are unpublished (#3992) 
Release notes:

* Fixed a bug where network interruptions could cause audio and screen
sharing to stop working without indicating that they were stopped, and
there was no way to restart the audio stream.
 2024-01-10 16:34:11 -08:00
Mikayla 1932a298cb Add back ime_key 2024-01-10 16:29:00 -08:00
Max BrunsfeldandJulia 75fdaeb56f Detect when a track is unpublished due to reconnecting to livekit 
Co-authored-by: Julia <julia@zed.dev>
 2024-01-10 16:12:26 -08:00
Max BrunsfeldandJulia 2d1eb0c56c Expose a single updates stream from live_kit_client::Room 
Co-authored-by: Julia <julia@zed.dev>
 2024-01-10 16:10:52 -08:00
Max Brunsfeld 0dca67fc33 Add --top flag to zed-local script, for making windows take up half the screen 2024-01-10 16:09:40 -08:00
Conrad Irwin b907f375a3 Fix fold-related panic (#4008) 
Although it's not super clear why this fails; in zed1 we used to have a
bounds
check. Restoring the bounds check for now, but leaving a debug_assert!
in case
a local reproduction happens.

Release Notes:

- Fix a panic that happened sometimes when rendering folds
 2024-01-10 16:53:25 -07:00
Conrad Irwin 766a869208 Fix fold-related panic 2024-01-10 15:51:13 -07:00
Joseph T. Lyons b4444bdfc0 Rename field in telemetry struct 2024-01-10 17:41:02 -05:00
Kirill Bulatov 3c1ed152ee Remove active call data when it was accepted (#4007) 
That hopefully helps with call notifications sometimes not being closed

Release Notes:

- N/A
 2024-01-11 00:40:32 +02:00
Kirill BulatovandMax 2e9c9adfbe Remove active call data when it was accepted 
That hopefully helps with call notifications sometimes not being closed

co-authored-by: Max <max@zed.dev>
 2024-01-11 00:35:00 +02:00
Kirill Bulatov e0dd5a5820 Debugging 2024-01-11 00:33:53 +02:00
Kirill Bulatov 7b3e7ee3cc Enfoce no dbg! and todo! in Rust code via clippy lints in the CI job 2024-01-11 00:26:46 +02:00
Antonio Scandurra a4ef1bc096 Rename reuse_geometry to reuse_view 2024-01-10 23:06:10 +01:00
Joseph T. Lyons 9df29fb347 WIP 2024-01-10 17:04:26 -05:00
Antonio Scandurra 1c260e6dfd Merge remote-tracking branch 'origin/main' into cache 
# Conflicts:
#	crates/copilot/src/sign_in.rs
#	crates/gpui/src/window.rs
#	crates/workspace/src/pane_group.rs
 2024-01-10 22:58:52 +01:00
Joseph T. Lyons b26a468820 Merge branch 'main' into instrument-keyboard-events 2024-01-10 16:03:01 -05:00
Mikayla f71a0cddb8 Remove last todos 2024-01-10 12:13:12 -08:00
Mikayla 4bcac68c8c Restore GPUI test 2024-01-10 11:43:52 -08:00
Piotr Osiewicz 9553759899 Remove todo from search tests 2024-01-10 11:26:11 -08:00
Mikayla 7ef88397c9 Fix seg fault when using the WindowContext::on_window_should_close() API 2024-01-10 11:26:11 -08:00
Mikayla 2a09c6aad5 Restore missing test 2024-01-10 11:26:11 -08:00
Mikayla c98d7adf83 Audit all TODOs in Zed and mark port related todos 2024-01-10 11:26:11 -08:00
Max Brunsfeld 02ef6fc973 Ensure ArenaRef pointers are aligned to their contained type (#4002) 
We think this may fix a segfault that sometimes occurs during
`display_layer`.
 2024-01-10 10:53:24 -08:00
Conrad Irwin 61a9a3a274 Revert "Remove ChannelsAlpha flag" 
This reverts commit 1c1151a0ed.
 2024-01-10 11:52:33 -07:00
Max BrunsfeldandAntonio Scandurra 69a93edabd Ensure ArenaRef pointers are aligned to their contained type 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
 2024-01-10 10:36:08 -08:00
Conrad Irwin 8d1bca450f Remove extra assertion 
As part of debugging the port of following tests we added an assertion
that the project was dropped. Now that we initialize the editor and
handle focus correctly in tests, the project is retained by
`refresh_document_highlights`. That doesn't affect the meaning of the
tests
 2024-01-10 10:18:45 -07:00
Piotr Osiewicz 282184a673 editor: Use inclusive ranges for git diff resolution. (#3999) 
The culprit was in display map which was resolving next valid point for
the editor, without regard for whether that point belongs to the same excerpt. We now make an end point a minimum of the end point passed in and the start of excerpt header, if there are any. 
This bug existed in Zed1 as well.

Fixes: Diff markers in multibuffer search overlap with dividers between
excepts (shouldn't extend all the way into the divider region)


Release Notes:
- Fixed diff markers being drawn incorrectly near headers in multibuffer
views.
 2024-01-10 18:11:05 +01:00
Conrad Irwin f16331a331 Remove ChannelsAlpha flag (#4001) 
Welcome to the party!

[[PR Description]]

Release Notes:

- Added Channels for structured real-time collaboration (TODO: link)
 2024-01-10 10:02:52 -07:00
Conrad Irwin 5dff458014 Ensure focus_in and focus_out fire on window activation (#3993) 
Also:
- Rename cx.on_blur to cx.on_focus_lost
- Fix a bug where notify calls in focus handlers were ignored
- Fix a bug where vim would get stuck in the wrong mode when switching
  windows

Release Notes:

- (preview only) vim: fix switching between multiple windows
 2024-01-10 10:00:07 -07:00
Conrad Irwin 1c1151a0ed Remove ChannelsAlpha flag 
Welcome to the party!
 2024-01-10 09:29:44 -07:00
Antonio Scandurra 2923b71f83 Replace WindowContext::notify with WindowContext::refresh 2024-01-10 17:27:02 +01:00
Conrad Irwin f8e4fd012f collab 0.36.0 2024-01-10 09:26:15 -07:00
Marshall Bowers a5203364b1 Use the .selected style for buffer search option buttons (#4000) 
This PR updates the `IconButton`s used to control the buffer search
options to use the `.selected` state to denote when they are active.
This matches what we are doing in the project search.

This should improve the contrast in certain themes.

Release Notes:

- Improved the active style for the search options in buffer search.
 2024-01-10 10:35:06 -05:00
Marshall Bowers aff119b80a Fix possessive "its" in docs and comments (#3998) 
This PR fixes a number of places where we were incorrectly using "it's"
where we needed to use the possessive "its".

Release Notes:

- N/A
 2024-01-10 10:09:48 -05:00