oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,149 Commits 1 Branch 0 Tags
824b68788fbd99b454ff18c7aeb53d50bb40f2e2
Commit Graph
204 Commits
Author SHA1 Message Date
Marshall Bowers 824b68788f Improve chat panel styling (#3758) 
This PR improves the chat panel styling, especially with regards to the
spacing.

Release Notes:

- N/A
 2023-12-21 12:15:11 -05:00
Max Brunsfeld afbc655100 Ensure that views' on_release callbacks are always called (#3747) 
* Ensure that views' on_release callbacks are always called (even if
their window is gone), by passing them a `AppContext`, not a
`WindowContext`.
* Fix leaked handles to `CollabPanel`, `NotificationPanel`, and
`ChatPanel` caused by captures in a `ListState` render callback.

This fixes two issues we were seeing with following:
* inability to rejoin a remote project after you closed it
* following not working if a window had previously been closed
 2023-12-20 16:45:37 -08:00
Max Brunsfeld 24970c1da9 Fix view handle leaks in ListState callbacks 2023-12-20 16:33:10 -08:00
Marshall Bowers 7b51f73826 Tighten up project share notifications 2023-12-20 16:06:59 -05:00
Marshall Bowers 9a06b7e77d Style incoming call notifications 2023-12-20 15:59:01 -05:00
Marshall Bowers c1df27c792 Style notification panel (#3741) 
This PR makes a first pass at styling the notification panel.

#### Signed out

<img width="381" alt="Screenshot 2023-12-20 at 11 41 25 AM"
src="https://github.com/zed-industries/zed/assets/1486634/f045fa17-4ebc-437f-a25b-d7695d47f18b">

#### No notifications

<img width="380" alt="Screenshot 2023-12-20 at 11 44 23 AM"
src="https://github.com/zed-industries/zed/assets/1486634/3a7543f2-8cd8-4788-8059-d5663f5f6b4c">

#### Notifications

<img width="386" alt="Screenshot 2023-12-20 at 1 27 08 PM"
src="https://github.com/zed-industries/zed/assets/1486634/13b81722-c47a-4c06-b37d-e6515cbfdb9d">

Release Notes:

- N/A
 2023-12-20 14:06:33 -05:00
Marshall Bowers da34dd49bb Fix text wrapping issues with overflow_hidden 
This seems to influence sizing calculations in ways I don't fully understand.
 2023-12-20 13:25:17 -05:00
Marshall Bowers b0b4610a73 Fix positioning of right items 2023-12-20 13:05:21 -05:00
Marshall Bowers 87f879bfa9 Add text wrapping to notifications 2023-12-20 12:48:30 -05:00
Marshall Bowers 9c4e8699ba Remove unneeded wrapping element 2023-12-20 12:45:18 -05:00
Marshall Bowers 636c12ec3f Style signed-out and empty states for the notification panel 2023-12-20 11:45:18 -05:00
Marshall Bowers 3886b1993d Fix formatting breakage 2023-12-20 11:41:51 -05:00
Marshall Bowers 5145795f33 Adjust styles for notification panel container 2023-12-20 11:27:28 -05:00
Kirill BulatovandAntonio Scandurra fe40e3920b Fix remaining z-index bugs 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
 2023-12-20 18:23:09 +02:00
Antonio Scandurra 6e1ba645f3 Show button as selected if screen sharing is on 2023-12-20 14:17:15 +01:00
Piotr Osiewicz 2f57a3ccfb Popover buttons titlebar (#3732) 
Migrate project picker/vcs menu to use popover_menu.

Release Notes:
- N/A
 2023-12-20 12:47:53 +01:00
Max Brunsfeld 599ec5c25b Make collab panel usable from the keyboard, add missing styling (#3724) 
* allow confirming all items via the keyboard
* allow deploying the channel context menu via the keyboard
* add missing selected styling for list items
 2023-12-19 14:33:56 -08:00
Max Brunsfeld afd3bf7746 Add missing selected state and keyboard action for some collab panel items 2023-12-19 14:16:44 -08:00
Max Brunsfeld 901795bcb9 Don't reset the collab panel when it loses focus 2023-12-19 14:12:29 -08:00
Kirill BulatovandAntonio Scandurra cf12d62fc5 Tidy up z-index handling 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
 2023-12-19 23:50:42 +02:00
Kirill BulatovandAntonio Scandurra 8f1c5375ef Fix more z-index and rendering issues 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
 2023-12-19 23:30:17 +02:00
Max BrunsfeldandNathan a9b1273e2b Clean up commented code 
Co-authored-by: Nathan <nathan@zed.dev>
 2023-12-19 12:06:47 -08:00
Max BrunsfeldandNathan 1c3698ae20 Implement channel modal 
Co-authored-by: Nathan <nathan@zed.dev>
 2023-12-19 12:02:35 -08:00
Max Brunsfeld 80b6922de7 wip 2023-12-19 10:20:40 -08:00
Max Brunsfeld a4bfd0147d Render channel invites in collab panel, fix unused warnings 2023-12-19 10:20:40 -08:00
Marshall Bowers a3bab25792 Style contact finder (#3717) 
This PR styles the contact finder.

<img width="598" alt="Screenshot 2023-12-19 at 12 59 00 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ca9d9345-bf27-4256-aabc-6017a0c4d217">

Release Notes:

- N/A
 2023-12-19 13:16:14 -05:00
Antonio ScandurraandJulia dd84993d76 Maintain scroll position in CollabPanel after updating entries 
Co-Authored-By: Julia <julia@zed.dev>
 2023-12-19 16:06:00 +01:00
Marshall Bowers 91f1be213b Style project share notification (#3706) 
This PR styles the project share notification, so we're not staring a
red rectangle.

<img width="425" alt="Screenshot 2023-12-18 at 6 06 14 PM"
src="https://github.com/zed-industries/zed/assets/1486634/7ae9a2d3-d5d9-427c-9125-3a47df5f6a2f">

Release Notes:

- N/A
 2023-12-18 18:13:09 -05:00
Marshall Bowers 4fdf6a867a Wire up offline contact list (#3700) 
This PR wires up the offline contact list.

Also enables toggling both the online and offline contact lists.

Release Notes:

- N/A
 2023-12-18 13:54:11 -05:00
Nate Butler 9d014b0f9a Remove comment 2023-12-18 13:11:51 -05:00
Nate Butler 89b231afeb Update collab panel signed out state 2023-12-18 13:09:46 -05:00
Nate Butler 196df1c378 Start on collab panel empty state 2023-12-18 11:33:37 -05:00
Max Brunsfeld 29c6061a14 Fix following bugs (#3688) 
* Follow command didn't work, because follow task was dropped
* An extra div prevented titlebar facepiles from rendering correctly
 2023-12-15 16:34:08 -08:00
Max Brunsfeld b5ae2f060b Remove div around all avatars in titlebar facepile 2023-12-15 16:26:56 -08:00
Marshall Bowers 5447c6d5ee Fix channel filter input (#3686) 
This PR fixes the channel filter in the collab panel not showing up.

Release Notes:

- N/A
 2023-12-15 17:03:59 -05:00
Marshall Bowers 487edcb12b Rework collab panel rendering to use gpui::list (#3678) 
This PR reworks the rendering of the collab panel to use `gpui::list`,
so that we don't render any items that are not visible on the screen.

In the process we also fixed some bugs in the channel list:

- Fixed the context menu for channels not deploying when activated via
keyboard
- Fixed drag and drop for channels
- Made it so when navigating the collab panel via keyboard the list only
scrolls enough to reveal the next item when navigating to an item that
is currently off-screen

Release Notes:

- N/A
 2023-12-15 14:11:24 -05:00
Marshall Bowers 5c060ceb1c Format code 2023-12-15 14:03:49 -05:00
Marshall BowersandMax 5417127902 Fix channel drag and drop 
Also add the ability to unnest a channel by dragging it to the "Channels"
header. This is currently not working due to a collab server issue.

Co-authored-by: Max <max@zed.dev>
 2023-12-15 14:01:24 -05:00
Marshall BowersandMax a40f04b71f Only scroll enough to reveal the next channel if it isn't visible 
Co-authored-by: Max <max@zed.dev>
 2023-12-15 13:50:51 -05:00
Marshall BowersandMax 47fc03ab98 Fix positioning of the inline context menu 
Added a new `bounds_for_item` for `ListState`.

Co-authored-by: Max <max@zed.dev>
 2023-12-15 13:24:30 -05:00
Marshall Bowers b478a4c4d5 Perform scroll interactions through the ListState 2023-12-15 12:10:40 -05:00
Marshall Bowers 6c10ff8548 Render the collab panel using a gpui::list 2023-12-15 11:56:03 -05:00
Nate Butler 6345e6d4d2 Add some right side padding in titlebar. 2023-12-15 11:25:24 -05:00
Nate Butler 47eaf1abd8 Remove red borders, improve left side padding 2023-12-15 11:07:40 -05:00
Conrad Irwin 7e1d61d116 Merge branch 'main' into user-menu 2023-12-14 20:18:20 -07:00
Mikayla Maki 46bd6088e8 Fix some todos, add others (#3669) 
As it says on the tin

Release Notes:

-
 2023-12-14 19:00:58 -08:00
Mikayla 6973b1b592 Add several red outlines 2023-12-14 17:48:49 -08:00
Nathan Sobo 02606d1fb9 Merge remote-tracking branch 'origin/main' into perf-2 2023-12-14 16:56:36 -07:00
MikaylaMaxConrad
 		8791f7cefc Enable dragging from project panel to panes 
Rework gpui2 drag API so that receivers need not specify the dragged view type.

co-authored-by: Max <max@zed.dev>
co-authored-by: Conrad <conrad@zed.dev>
 2023-12-14 13:20:48 -08:00
Nathan Sobo fb3382bcc5 Merge remote-tracking branch 'origin/main' into perf-2 2023-12-14 14:16:59 -07:00