oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,950 Commits 1 Branch 0 Tags
80852c3e182ccdd4e1237b5e7770efa33ea9ec28
Commit Graph
16950 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kirill Bulatov dd6e2df2a1 Show abs path matches in file finder 2024-01-11 17:49:46 +02:00
Kirill BulatovandMarshall Bowers ba83623c84 Fix whitespace symbol colors in the editor, use zed1 one 
co-authored-by: Marshall Bowers <marshall@zed.dev>
 2024-01-11 17:43:49 +02:00
Kirill Bulatov b342c92495 Restore hover action in the editor (#4016) 
Deals with https://github.com/zed-industries/community/issues/2304
Deals with https://github.com/zed-industries/community/issues/2394

Release Notes:

- Fixed `editor::Hover` action (and `g h` command in Vim mode) not
working
 2024-01-11 16:28:10 +02:00
Kirill Bulatov 9bb50a5ded Restore hover action in the editor 2024-01-11 16:19:44 +02:00
Antonio Scandurra 18eaefd0ed Reuse cursor style when reusing a view tree 2024-01-11 15:03:34 +01:00
Kirill Bulatov 4fe0c473ca Do not split on only external directories being drag and dropped (#4015) 
Release Notes:

- Fixed drag and dropped folders opening an empty split pane
 2024-01-11 15:23:53 +02:00
Joseph T. Lyons 75cb409d2e Instrument edit events (#4006) 
The goal of this PR is to send up events that contain the duration of
keyboard activity within Zed. I built the `EventCoalescer`, which gets
called called each time a key is pressed, within any environment (in the
case of this PR, within "editor" and "terminal). The" `EventCoalescer`
holds a start and end DateTime and adjusts the end instant as events
come in, until a timeout from the last event is hit.

I did my best to keep this mechanism efficient (avoiding vectors to
store moments in time, avoiding spawning timers threads, etc.), because
I know this is going to be per keystroke, but its behind a lock on the
telemetry struck, since it has to know when the environment changes, in
which point, it will automatically end the activity period, even if
there is no timeout. Because we have to have access to it from different
parts of the system, we have to go through the lock, which worried me a
bit (@mikayla-maki's intuition is that it should be fine).

As for the event, I take the time between the durations reported by the
event coalescer and send that up to zed - the indention is to
reconstruct the start and end times on zed.dev, in the same way we use
the event offset times and the time on zed.dev to get the official event
timestamp, and avoid the issue of the user having their system clocks
set wrong.

I'd really appreciate it if @nathansobo or @maxbrunsfeld could check
this out.

Release Notes:

- N/A
 2024-01-11 08:19:29 -05:00
Kirill Bulatov 2e36b0b72a Do not split on only external directories being drag and dropped 2024-01-11 15:09:43 +02:00
Piotr Osiewicz a33be893a4 chore: Revert asset compression 
While it does reduce the size of a binary quite significantly, it doesn't seem to matter for .dmg which runs it's own compression on top of binaries.
 2024-01-11 13:42:57 +01:00
Kirill Bulatov 348bc842ef Enforce no dbg! and todo! in Rust code via clippy lints in the CI job (#4005) 
Release Notes:

- N/A
 2024-01-11 14:25:31 +02:00
Antonio Scandurra 50ccdf5c16 Reuse input handler when reusing a view tree 2024-01-11 13:22:59 +01:00
Kirill BulatovandPiotr 41bc49af36 Remove redundant install Rust steps 
Those were not installing Rust but configuring it via rustup, and
those configurations were done on `stable` toolchain which is not what we use (see rust-toolchain.toml)

co-authored-by: Piotr <piotr@zed.dev>
 2024-01-11 14:11:13 +02:00
Kirill BulatovandPiotr a5dd2535f1 Properly require clippy installation, try to shuffle clippy arguments 
co-authored-by: Piotr <piotr@zed.dev>
 2024-01-11 13:56:28 +02:00
Antonio Scandurra d088ace404 Explicitly push a node in the dispatch tree when painting a new view 2024-01-11 12:48:05 +01:00
Piotr Osiewicz 1200f595a3 Try to run clippy just for a single target 2024-01-11 12:36:45 +01:00
Antonio Scandurra 142a8b68c8 Avoid casting view ids to u32 
Also, it looks like using a u64 directly doesn't work well with Metal
shaders, so we unpack the u64 into two u32s.
 2024-01-11 12:28:48 +01:00
Piotr Osiewicz 0db7559e96 editor: extend diff hunk range for custom transform blocks. (#4012) 
Reported by Mikayla:

![image](https://github.com/zed-industries/zed/assets/24362066/b744d82e-328f-4554-becf-96f9fa92bfc8)
Note how the line with rust analyzer error does not have a git diff
hunk.
vs:

![image](https://github.com/zed-industries/zed/assets/24362066/e285af7a-b8ab-40e9-a9c6-b4ab8d6c4cd0)

Release Notes:
- N/A
 2024-01-11 12:26:12 +01:00
Mikayla 6503dd51dd enviroment -> environment 2024-01-10 22:57:58 -08:00
Joseph T. Lyons 0df4bfacc2 Increase debug mode queue size 2024-01-11 01:12:49 -05:00
Joseph T. Lyons 8a61d5059b Never send an an empty set of events 2024-01-11 01:12:30 -05:00
Conrad Irwin f418bd907d Stop following when project is unshared 
Before this change the views would continue to update in the background
of the "disconnected" dialogue, which was disconcerting.
 2024-01-10 23:09:09 -07:00
Mikayla Maki 31689c09e5 Uncomment last tests (#4009) 
With this, we're done all known things that need porting. 

Release Notes:

-
 2024-01-10 20:00:14 -08:00
Mikayla 83163a0031 Reverse context arrays in child predicate test 2024-01-10 19:54:39 -08:00
MikaylaandConrad 38396d4281 Add remaining tests 
co-authored-by: Conrad <conrad@zed.dev>
 2024-01-10 19:39:43 -08:00
Mikayla a5ca58354d Fix first few asserts 2024-01-10 18:26:01 -08:00
Joseph T. Lyons bddf827bc1 Add reminder for the future 2024-01-10 21:02:34 -05:00
Mikayla Maki 44969460cd Remove remaining port related todos (#3994) 
TODO:
- [x] Audit all TODO comments in Zed source and mark port related ones
with a !
- [x] Resolve all todos written as `todo!`

Release Notes:

- N/A
 2024-01-10 17:31:05 -08:00
Max Brunsfeld cb5d4edc4b Handle reconnects to the livekit server in which local tracks are unpublished (#3992) 
Release notes:

* Fixed a bug where network interruptions could cause audio and screen
sharing to stop working without indicating that they were stopped, and
there was no way to restart the audio stream.
 2024-01-10 16:34:11 -08:00
Mikayla 1932a298cb Add back ime_key 2024-01-10 16:29:00 -08:00
Max BrunsfeldandJulia 75fdaeb56f Detect when a track is unpublished due to reconnecting to livekit 
Co-authored-by: Julia <julia@zed.dev>
 2024-01-10 16:12:26 -08:00
Max BrunsfeldandJulia 2d1eb0c56c Expose a single updates stream from live_kit_client::Room 
Co-authored-by: Julia <julia@zed.dev>
 2024-01-10 16:10:52 -08:00
Max Brunsfeld 0dca67fc33 Add --top flag to zed-local script, for making windows take up half the screen 2024-01-10 16:09:40 -08:00
Conrad Irwin b907f375a3 Fix fold-related panic (#4008) 
Although it's not super clear why this fails; in zed1 we used to have a
bounds
check. Restoring the bounds check for now, but leaving a debug_assert!
in case
a local reproduction happens.

Release Notes:

- Fix a panic that happened sometimes when rendering folds
 2024-01-10 16:53:25 -07:00
Conrad Irwin 766a869208 Fix fold-related panic 2024-01-10 15:51:13 -07:00
Joseph T. Lyons b4444bdfc0 Rename field in telemetry struct 2024-01-10 17:41:02 -05:00
Kirill Bulatov 3c1ed152ee Remove active call data when it was accepted (#4007) 
That hopefully helps with call notifications sometimes not being closed

Release Notes:

- N/A
 2024-01-11 00:40:32 +02:00
Kirill BulatovandMax 2e9c9adfbe Remove active call data when it was accepted 
That hopefully helps with call notifications sometimes not being closed

co-authored-by: Max <max@zed.dev>
 2024-01-11 00:35:00 +02:00
Kirill Bulatov e0dd5a5820 Debugging 2024-01-11 00:33:53 +02:00
Kirill Bulatov 7b3e7ee3cc Enfoce no dbg! and todo! in Rust code via clippy lints in the CI job 2024-01-11 00:26:46 +02:00
Antonio Scandurra a4ef1bc096 Rename reuse_geometry to reuse_view 2024-01-10 23:06:10 +01:00
Joseph T. Lyons 9df29fb347 WIP 2024-01-10 17:04:26 -05:00
Antonio Scandurra 1c260e6dfd Merge remote-tracking branch 'origin/main' into cache 
# Conflicts:
#	crates/copilot/src/sign_in.rs
#	crates/gpui/src/window.rs
#	crates/workspace/src/pane_group.rs
 2024-01-10 22:58:52 +01:00
Joseph T. Lyons b26a468820 Merge branch 'main' into instrument-keyboard-events 2024-01-10 16:03:01 -05:00
Mikayla f71a0cddb8 Remove last todos 2024-01-10 12:13:12 -08:00
Mikayla 4bcac68c8c Restore GPUI test 2024-01-10 11:43:52 -08:00
Piotr Osiewicz 9553759899 Remove todo from search tests 2024-01-10 11:26:11 -08:00
Mikayla 7ef88397c9 Fix seg fault when using the WindowContext::on_window_should_close() API 2024-01-10 11:26:11 -08:00
Mikayla 2a09c6aad5 Restore missing test 2024-01-10 11:26:11 -08:00
Mikayla c98d7adf83 Audit all TODOs in Zed and mark port related todos 2024-01-10 11:26:11 -08:00
Max Brunsfeld 02ef6fc973 Ensure ArenaRef pointers are aligned to their contained type (#4002) 
We think this may fix a segfault that sometimes occurs during
`display_layer`.
 2024-01-10 10:53:24 -08:00