oak-team/oak-gpui
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
13,775 Commits 1 Branch 0 Tags
6d2e1a8e76aafdeb958f7742d6d7fcaa09cf61ba
Commit Graph
2199 Commits
Author SHA1 Message Date
Max Brunsfeld d6abd8a2b4 Add missing dev-dependency feature for editor multi_buffer dependency 2023-10-30 15:32:52 -07:00
Joseph T. Lyons dd89b2e6d4 Pull duplicate call out of if-else block 2023-10-29 13:54:32 -05:00
Joseph T. Lyons 34747bbbbc Do not call scroll_to twice 2023-10-29 13:47:02 -05:00
Piotr Osiewicz 7f6bb3d1eb Extract multi_buffer module out of editor (#3170) 
Release Notes:

- N/A
 2023-10-25 19:31:47 +02:00
Julia 1936ba5e30 F8 navigation bugs (#3163) 
Release Notes:

- Fixed "go to previous hunk" getting suck on deletion.
- Fixed a rare case where "go to (prev) diagnostic" could get stuck with
specifically overlapping diagnostics.
 2023-10-25 19:03:45 +02:00
Joseph T. Lyons 1c5b321058 Allow completion menus to be cycled 2023-10-24 19:29:44 +02:00
Julia bfdff4e2e0 When navigating diagnostics, skip diagnostic containing cursor 
Slightly unfortunate but prevents an issue with weirdly overlapping
diagnostics causing the cursor to bounce between them
 2023-10-24 17:56:56 +02:00
Kirill Bulatov e9ce935991 Rework prettier tests 
Do not infuse `FakeNodeRuntime` with prettier exceptions, rather keep
the default formatter installation method as no-op.
 2023-10-24 14:25:46 +02:00
Julia 48cdefe6cf Re-understand that the line just below git deletion is "inside" hunk 
Fixes "go to previous hunk" getting stuck on a deletion, never going
further up
 2023-10-24 11:17:42 +02:00
Conrad Irwin 2b95db087b Fix infinite loop in select all (#3154) 
[[PR Description]]

Release Notes:

- Fixed an infinite loop in select all matches
([#2170](https://github.com/zed-industries/community/issues/2170)).
 2023-10-24 02:58:48 -06:00
Conrad Irwin 0e035c1a95 Fix character selection 2023-10-24 10:50:08 +02:00
Conrad Irwin 6e4e19d8fc Fix infinite loop in select all 2023-10-23 16:08:12 +02:00
Conrad Irwin 9589f5573d Fix some bugs with vim objects 
- softwrap interaction
- correct selection if cursor is on opening marker
 2023-10-22 21:44:34 -06:00
Kirill Bulatov 26638748bb Move prettier parsers data into languages from LSP adapters (#3150) 
Release Notes:

- Fixed incorrect prettier parsers sometimes being applied to certain
files
 2023-10-21 02:22:21 +03:00
Kirill Bulatov 7748848b6e Move prettier parsers data into languages from LSP adapters 2023-10-21 01:14:03 +02:00
Conrad Irwin 0dae0f6027 pixel columns (#3052) 
@ForLoveOfCats and I found a few speedups that make this acceptably fast
(able to update ~10k selections in <100ms), so the remaining work here
is to fix the tests, and then ship!

Release notes:
- Updated up/down to work based on pixel positions
([#1966](https://github.com/zed-industries/community/issues/1966))
([#759](https://github.com/zed-industries/community/issues/759))
- vim: Fixed off-by-one in visual block mode
([2123](https://github.com/zed-industries/community/issues/2123))
 2023-10-20 15:01:27 -06:00
Conrad Irwin 2de34a905d Hide any circumstantial evidence that this didn't work perfectly first 
time
 2023-10-20 14:45:37 -06:00
Conrad Irwin fae5b1e391 Fix build columnar selection logic 2023-10-20 12:55:41 -06:00
Conrad Irwin 43d682f6b8 Handle pixel-down to last line when no trailing newline 2023-10-20 12:46:14 -06:00
Conrad Irwin 1c36134cf9 Fix single column vim selections 2023-10-20 11:17:19 -06:00
Conrad Irwin b596b4153f Fix test 2023-10-20 10:34:09 -06:00
Kirill Bulatov 40104c06e2 Sort hint request ranges before asserting to avoid flackiness 2023-10-19 11:05:47 +03:00
Conrad Irwin 9d07561d99 Merge branch 'main' into pixel-columns 2023-10-18 23:00:56 -06:00
Conrad Irwin 3eb8aa8085 Refactor TextLayoutDetails construction 2023-10-18 22:56:11 -06:00
Conrad Irwin cb76b2a6ad Make vim visual block work better 2023-10-18 22:23:06 -06:00
Max BrunsfeldandPiotr 655c9ece2d Fix possibility of infinite loop in selections_with_autoclose_regions 
Previously, that method could loop forever if the editor's autoclose
regions had unexpected selection ids.

Co-authored-by: Piotr <piotr@zed.dev>
 2023-10-18 11:16:14 -07:00
Piotr Osiewicz cc335db9e0 editor/language: hoist out non-generic parts of edit functions. (#3130) 
This reduces LLVM IR size of editor (that's one of the heaviest crates
to build) by almost 5%.

LLVM IR size of `editor` before this PR: 3280386
LLVM IR size with `editor::edit` changed: 3227092
LLVM IR size with `editor::edit` and `language::edit` changed: 3146807

Release Notes:
- N/A
 2023-10-16 13:17:44 +02:00
Piotr Osiewicz 6f4008ebab copilot: Propagate action if suggest_next is not possible. (#3129) 
One of our users ran into an issue where typing "true quote" characters
(option-[ for „ and option-] for ‚) was not possible; I've narrowed it
down to a collision with Copilot's NextSuggestion and PreviousSuggestion
action default keybinds. I explicitly did not want to alter the key
bindings, so I've went with a more neutral fix - one that propagates the
keystroke if there's no Copilot action to be taken (user is not using
Copilot etc). Note however that typing true quotes while using a Copilot
is still not possible, as for that we'd have to change a keybind.

Fixes zed-industries/community#2072


Release Notes:
- Fixed Copilot's "Suggest next" and "Suggest previous" actions
colliding with true quotes key bindings (`option-[` and `option-]`). The
keystrokes are now propagated if there's no Copilot action to be taken
at cursor's position.
 2023-10-15 17:27:36 +02:00
Julia 2323fd17b0 Autocomplete docs (#3126) 
Release Notes:

- Added documentation display for autocomplete items.
- Fixed autocomplete filtering blocking the Zed UI, causing hitches and
input delays with large completion lists.
- Fixed hover popup link not firing if the mouse moved a slight amount
while clicking.
- Added support for absolute path file links in hover popup and
autocomplete docs.
 2023-10-13 13:26:45 -04:00
Julia ec4391b88e Add setting to disable completion docs 2023-10-12 22:08:47 -04:00
Julia 1c3ecc4ad2 Whooooops 2023-10-12 21:00:31 -04:00
Julia c4fc9f7ed8 Eagerly attempt to resolve missing completion documentation 2023-10-12 19:28:17 -04:00
Julia d23bb3b05d Unbork markdown parse test by making links match 2023-10-12 16:18:54 -04:00
Julia 85332eacbd Race completion filter w/completion request & make not block UI 2023-10-12 13:23:26 -04:00
Julia 4688a94a54 Allow file links in markdown & filter links a bit aggressively 2023-10-12 12:11:27 -04:00
Kirill Bulatov 1bfde4bfa2 Add more tests 2023-10-12 15:14:51 +03:00
Kirill Bulatov 7f4ebf50d3 Make the first prettier test pass 2023-10-12 13:30:49 +03:00
Julia a09ee3a41b Fire markdown link on mouse down 
Previously any amount of mouse movement would disqualify the mouse down
and up from being a click, being a drag instead, which is a long
standing UX issue. We can get away with just firing on mouse down here
for now
 2023-10-11 14:39:34 -04:00
Julia 0cec0c1c1d Fixup layout 2023-10-11 13:41:58 -04:00
Kirill Bulatov e50f4c0ee5 Add prettier tests infrastructure 2023-10-11 19:13:28 +03:00
JuliaandAntonio Scandurra 801af95a13 Make completion documentation scroll & fix accompanying panic from tag 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
 2023-10-10 10:08:29 -04:00
JuliaandAntonio Scandurra f5af5f7334 Avoid leaving selected item index past end of matches list 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
 2023-10-10 09:27:18 -04:00
Julia 354882f2c0 Enable completion menu to resolve documentation when guest 2023-10-10 00:16:15 -04:00
Conrad Irwin ab050d1890 Use Horizontal ranges everywhere 2023-10-09 21:48:50 -06:00
Conrad Irwin 002e2cc42c Round better for up/down 2023-10-09 21:48:32 -06:00
Conrad Irwin ef7e2c5d86 Get the project running! 2023-10-09 21:48:31 -06:00
Conrad Irwin e7badb38e9 Refactor to pass a TextLayoutDetails around 2023-10-09 21:47:58 -06:00
Conrad IrwinandJulia dacc8cb5f4 Begin to use pixels for column selection 
For zed-industries/community#759
For zed-industries/community#1966

Co-Authored-By: Julia <floc@unpromptedtirade.com>
 2023-10-09 21:47:58 -06:00
Julia 7020050b06 Fix hover_popover.rs after bad rebase 2023-10-09 14:28:53 -04:00
Julia 9d8cff1275 If documentation included in original completion then parse up front 2023-10-06 13:26:39 -04:00