apricotbucket28
5c7e6b7eff
wayland: Fix window state issues ( #13885 )
...
Fixes some issues with the CSD added in
https://github.com/zed-industries/zed/pull/13611
Here's a video comparing the master branch (yellow icon) with this PR
(blue icon):
https://github.com/zed-industries/zed/assets/71973804/35be443a-8f24-4aed-910b-625bad9821e2
_Note: the flicker at the bottom of the window when maximizing is an
issue with the KDE floating task bar, it happens with all programs._
Release Notes:
- N/A
2024-07-05 13:42:11 -07:00
47aa761ca9
Linux window decorations ( #13611 )
...
This PR adds support for full client side decorations on X11 and Wayland
TODO:
- [x] Adjust GPUI APIs to expose CSD related information
- [x] Implement remaining CSD features (Resizing, window border, window
shadow)
- [x] Integrate with existing background appearance and window
transparency
- [x] Figure out how to check if the window is tiled on X11
- [x] Implement in Zed
- [x] Repeatedly maximizing and unmaximizing can panic
- [x] Resizing is strangely slow
- [x] X11 resizing and movement doesn't work for this:
https://discord.com/channels/869392257814519848/1204679850208657418/1256816908519604305
- [x] The top corner can clip with current styling
- [x] Pressing titlebar buttons doesn't work
- [x] Not showing maximize / unmaximize buttons
- [x] Noisy transparency logs / surface transparency problem
https://github.com/zed-industries/zed/pull/13611#issuecomment-2201685030
- [x] Strange offsets when dragging the project panel
https://github.com/zed-industries/zed/pull/13611#pullrequestreview-2154606261
- [x] Shadow inset with `_GTK_FRAME_EXTENTS` doesn't respect tiling on
X11 (observe by snapping an X11 window in any direction)
Release Notes:
- N/A
---------
Co-authored-by: conrad <conrad@zed.dev >
Co-authored-by: Owen Law <81528246+someone13574@users.noreply.github.com >
Co-authored-by: apricotbucket28 <71973804+apricotbucket28@users.noreply.github.com >
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com >
2024-07-03 11:28:09 -07:00
Nate Butler
7db68547fa
Update Platform Controls ( #13751 )
...
Continuing from #13597 , this PR refactors platform controls to extract a
generic set of platform controls that can be used for any platform that
does not define it's own/we don't use the system ones.
In the future, these controls will likely be used as a fallback on
windows as well when the windows icon font isn't available.
Release Notes:
- Added updated window controls on Linux
2024-07-02 16:15:59 -04:00
Nate Butler
0b57df5deb
Extract title_bar crate ( #13597 )
...
This PR extracts a singular title bar (`title_bar::TitleBar`) from
`ui::TitleBar` and
`collab_ui::collab_titlebar_item::CollabTitlebarItem`.
This is a first step towards organizing title bar things into one place,
and standardizing platform titlebar/window control implementations.
Release Notes:
- N/A
2024-06-27 19:14:13 -04:00