oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
21,918 Commits 1 Branch 0 Tags
01284c261cc7b515affbb4348dab25e4eae4df58
Commit Graph
21918 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Marshall BowersandMax a40f04b71f Only scroll enough to reveal the next channel if it isn't visible 
Co-authored-by: Max <max@zed.dev>
 2023-12-15 13:50:51 -05:00
Mikayla b4135dd2f1 Fix editor mouse event dispatch 2023-12-15 10:26:41 -08:00
Marshall BowersandMax 47fc03ab98 Fix positioning of the inline context menu 
Added a new `bounds_for_item` for `ListState`.

Co-authored-by: Max <max@zed.dev>
 2023-12-15 13:24:30 -05:00
Mikayla Maki a65688abac Fix center pane resizing (#3677) 
Release Notes:

- N/A
 2023-12-15 10:15:58 -08:00
Mikayla a2852e36ce Fix pane resizing 2023-12-15 10:07:10 -08:00
Antonio Scandurra 0a57171066 Use a safe API for Arena 2023-12-15 19:03:37 +01:00
Nate Butler 4cb0f60779 Update size of code action indicator and show when active 2023-12-15 12:29:33 -05:00
Nate Butler 83525bf142 Revert change to single line editor height 2023-12-15 12:22:33 -05:00
Marshall Bowers b478a4c4d5 Perform scroll interactions through the ListState 2023-12-15 12:10:40 -05:00
Nate Butler d13c1486da Update fold_indicator render 2023-12-15 12:09:06 -05:00
Marshall Bowers 6c10ff8548 Render the collab panel using a gpui::list 2023-12-15 11:56:03 -05:00
Nate Butler 3993b0acde Titlebar cleanup (#3675) 
[[PR Description]]

Clean up titlebar design nits

- Remove red borders
- Update menu button styles
- Adjust padding
- Improve tooltips with keybindings

Release Notes:

- N/A
 2023-12-15 11:45:52 -05:00
Nate Butler 6345e6d4d2 Add some right side padding in titlebar. 2023-12-15 11:25:24 -05:00
Nate Butler d099d35948 Reduce intensity of project panel icons 2023-12-15 11:20:56 -05:00
Nate Butler 47eaf1abd8 Remove red borders, improve left side padding 2023-12-15 11:07:40 -05:00
Nate Butler 50a44dd8ba Improve tooltip with keybinding styling 2023-12-15 11:07:17 -05:00
Nate Butler 2b4f779918 Story/Storybook Enhancements (#3674) 
[[PR Description]]

- Adds some Story components to reduce the amount of code needed to lay
out stories
- Added the ability to open a story in Zed using a link (see text story)
- Added sections with descriptions and usage.

Release Notes:

- N/A
 2023-12-15 10:48:13 -05:00
Nate Butler f459fc5e27 Fix import 2023-12-15 10:33:27 -05:00
Nate Butler 62ea58618c Merge branch 'main' into story-enhancements 2023-12-15 10:26:59 -05:00
Nate Butler 3d9e051b07 Update storybook2.rs 2023-12-15 10:25:07 -05:00
Antonio Scandurra be73dd852d Move Arena to a thread-local and use it to allocate AnyElement 2023-12-15 16:18:05 +01:00
Antonio Scandurra e1ca8e81bb Use an Arena to reuse allocations for listeners 2023-12-15 15:13:32 +01:00
Piotr Osiewicz ff3f4f3027 search: Reintroduce whole word switch (#3672) 
It seems to have been lost in the recent styling pass.

Release Notes:

- N/A
 2023-12-15 12:20:54 +01:00
Piotr Osiewicz 2b3d9deabe Dismiss Recent Projects & VCS modals on ESC (#3671) 
Release Notes:

- N/A
 2023-12-15 12:07:25 +01:00
Kirill Bulatov 83b55de73e zed2: Restore buffer search deploy & focus behavior (#3670) 
In zed1, cmd-f either opened the search buffer, or focused into it if it
was open already. Search query got updated, if any selection was made on
the moment of cmd-f call.

The PR restores that behavior and also

* fixes a bug when opened diagnostics error always got pasted
* comments out the panic on multibuffer separator click 
* removes extra stdout & stderr debug logging

Release Notes:

- N/A
 2023-12-15 12:33:45 +02:00
Kirill Bulatov 4bfe46f53a Restore zed1 behavior for buffer search deploy 2023-12-15 12:23:03 +02:00
Kirill Bulatov 31ff7d40ed Adjust copy/paste buffer only on the copy error action trigger 2023-12-15 11:34:00 +02:00
Kirill Bulatov a6403aad1a Remove extra nits, do not panic on clicking the buffer separator 2023-12-15 11:28:48 +02:00
Joseph T. Lyons 2fd9ac506f Tweak wording 2023-12-15 01:47:59 -05:00
Julia 62d655183b Fire focus handlers on draw to avoid timing with newly created item (#3640) 
See title

Any focus changes which fire from within a focus handler should be
handled in the next frame

Release Notes:

- N/A
 2023-12-14 23:57:24 -05:00
Julia de523c2d80 Give correct focus handle when project search has no matches 2023-12-14 23:49:44 -05:00
Julia 4be84f3db0 Merge branch 'main' into focus-handlers-on-draw 2023-12-14 23:08:23 -05:00
Conrad Irwin 70a14bb22f Implement user menu (#3636) 
Release Notes:

- N/A
 2023-12-14 20:30:28 -07:00
Julia d4e09230cc Give result-less project search a focus handle 2023-12-14 22:29:33 -05:00
Conrad Irwin 7e1d61d116 Merge branch 'main' into user-menu 2023-12-14 20:18:20 -07:00
Mikayla Maki 46bd6088e8 Fix some todos, add others (#3669) 
As it says on the tin

Release Notes:

-
 2023-12-14 19:00:58 -08:00
Julia ff4da878f9 Render panel in these tests 2023-12-14 21:33:11 -05:00
Julia fbcaf96ab5 Track focus on TestItem 2023-12-14 20:58:59 -05:00
Mikayla 6973b1b592 Add several red outlines 2023-12-14 17:48:49 -08:00
Mikayla ead5206741 Fix todos in auto-update 2023-12-14 17:00:07 -08:00
Max Brunsfeld b52db696d3 Fix overlay rendering when dragging onto the center of a pane (#3667) 2023-12-14 16:59:19 -08:00
Max Brunsfeld 52b9fc303b Fix overlay rendering when dragging onto the center of a pane 2023-12-14 16:52:03 -08:00
Mikayla Maki c27dd57a48 Make more performance improvements to GPUI 2 (#3664) 
In the 3 charts below, "window draw" has 3 major subroutines. Request
layout, where we walk over the tree and have everything talk to the
layout engine initially. Compute layout, where we have the layout engine
actually do the layout, and then paint, where we use the computed bounds
to populate the scene.


![image_720](https://github.com/zed-industries/zed/assets/1789/d2225389-865f-4c8a-9452-9f611da64dcf)

Things are moving quickly so before/after comparisons are tough. In the
graph above, green bars are from a commit actually pre-dates a merge of
master which increased the complexity of layout. The red bars represent
the state of the world after this PR. Note how we improve the
performance of `paint`.

Improvements:

- Not moving `self` in `Element::paint`. This was moving from the heap
to the stack and imposing a big cost. This is the biggest win in this
PR.
- We got some minor wins by making the stacking order a bigger smallvec
of u8 instead of u32.
- A big win that doesn't show up in this chart is avoiding a double
render of the editor when autoscrolling by never pushing notification
effects or marking the window dirty when notifying during a window draw.

Release Notes:

- N/A
 2023-12-14 16:45:58 -08:00
Max Brunsfeld b95cc7221c Fix centering of empty pane text (#3666) 
The formatting of the empty pane text regressed in #3665, in which I
also made it possible to drag items onto an empty pane.
 2023-12-14 16:44:30 -08:00
Mikayla Maki 05cb68eff1 Merge branch 'main' into perf-2 2023-12-14 16:39:10 -08:00
Max Brunsfeld 842f15c65b Fix centering of empty pane text 2023-12-14 16:35:58 -08:00
Max Brunsfeld 82c8b49dac Fix stickiness of main pane drag target (#3665) 
Reimplement the pane drag targets using on_drag_move
 2023-12-14 16:30:02 -08:00
Mikayla Maki 8418f25d0a Merge branch 'main' into perf-2 2023-12-14 16:25:40 -08:00
Max Brunsfeld d6383ab0c6 Fix stickiness of main pane drag target 
Reimplement the pane drag targets using on_drag_move
 2023-12-14 16:23:15 -08:00
Mikayla Maki 0b4b81fa0c Fix dock resizing (#3663) 
This fixes some bugs in the display and tracking of dock resizes

Release Notes:

-
 2023-12-14 16:20:29 -08:00