oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remote: Do not allocate pseudo terminal for ssh commands (#39451)

Browse Source 
Closes https://github.com/zed-industries/zed/issues/25382

Release Notes:

- Fixed ssh remote not working if the default shell profile prints to
stdout
This commit is contained in:
Lukas Wirth
2025-10-03 11:33:44 +00:00
committed by GitHub
parent f3abd1dab5
commit db825c1141
1 changed files with 4 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/remote/src/transport/ssh.rs
+4 -21
View File
@@ -512,16 +512,7 @@ impl SshRemoteConnection {
) -> Result<()> {
if let Some(parent) = tmp_path_gz.parent() {
self.socket
.run_command(
"sh",
&[
"-c",
&shell_script!(
"mkdir -p {parent}",
parent = parent.display(self.path_style()).as_ref()
),
],
)
.run_command("mkdir", &["-p", parent.display(self.path_style()).as_ref()])
.await?;
}
@@ -592,16 +583,7 @@ impl SshRemoteConnection {
) -> Result<()> {
if let Some(parent) = tmp_path_gz.parent() {
self.socket
.run_command(
"sh",
&[
"-c",
&shell_script!(
"mkdir -p {parent}",
parent = parent.display(self.path_style()).as_ref()
),
],
)
.run_command("mkdir", &["-p", parent.display(self.path_style()).as_ref()])
.await?;
}
@@ -735,6 +717,7 @@ impl SshSocket {
log::debug!("ssh {} {:?}", self.connection_options.ssh_url(), to_run);
self.ssh_options(&mut command)
.arg(self.connection_options.ssh_url())
.arg("-T")
.arg(to_run);
command
}
@@ -795,7 +778,7 @@ impl SshSocket {
}
async fn platform(&self) -> Result<RemotePlatform> {
let uname = self.run_command("sh", &["-c", "uname -sm"]).await?;
let uname = self.run_command("uname", &["-sm"]).await?;
let Some((os, arch)) = uname.split_once(" ") else {
anyhow::bail!("unknown uname: {uname:?}")
};