windows: Fix semantic merge conflict with ShellKind::new (#40107)

Release Notes:

- N/A
This commit is contained in:
Cole Miller
2025-10-13 14:30:40 +00:00
committed by GitHub
parent f1db1f3a3c
commit dac5725246
3 changed files with 5 additions and 5 deletions
+1 -1
View File
@@ -166,7 +166,7 @@ mod test {
#[test]
fn redirect_stdin_to_dev_null_fish() {
let shell = Shell::Program("fish".to_owned());
let shell_builder = ShellBuilder::new(&shell);
let shell_builder = ShellBuilder::new(&shell, false);
let (program, args) = shell_builder
.redirect_stdin_to_dev_null()
+3 -3
View File
@@ -355,10 +355,10 @@ impl Shell {
}
}
pub fn shell_kind(&self) -> ShellKind {
pub fn shell_kind(&self, is_windows: bool) -> ShellKind {
match self {
Shell::Program(program) => ShellKind::new(program),
Shell::WithArguments { program, .. } => ShellKind::new(program),
Shell::Program(program) => ShellKind::new(program, is_windows),
Shell::WithArguments { program, .. } => ShellKind::new(program, is_windows),
Shell::System => ShellKind::system(),
}
}
+1 -1
View File
@@ -495,7 +495,7 @@ impl TerminalBuilder {
.unwrap_or(params.program.clone())
});
let shell_kind = shell.shell_kind();
let shell_kind = shell.shell_kind(cfg!(windows));
let pty_options = {
let alac_shell = shell_params.as_ref().map(|params| {