gpui: Return None for non-existing credentials in read_credentials on windows (#43540)

Release Notes: - N/A *or* Added/Fixed/Improved ...
2025-11-26 12:01:01 +00:00
parent c2cb76b026
commit b9af6645e3
1 changed files with 11 additions and 2 deletions
@@ -642,15 +642,24 @@ impl Platform for WindowsPlatform {
            .collect_vec();
        self.foreground_executor().spawn(async move {
            let mut credentials: *mut CREDENTIALW = std::ptr::null_mut();
-            unsafe {
+            let result = unsafe {
                CredReadW(
                    PCWSTR::from_raw(target_name.as_ptr()),
                    CRED_TYPE_GENERIC,
                    None,
                    &mut credentials,
-                )?
+                )
            };

+            if let Err(err) = result {
+                // ERROR_NOT_FOUND means the credential doesn't exist.
+                // Return Ok(None) to match macOS and Linux behavior.
+                if err.code().0 == ERROR_NOT_FOUND.0 as i32 {
+                    return Ok(None);
+                }
+                return Err(err.into());
+            }
+
            if credentials.is_null() {
                Ok(None)
            } else {