oak-team/oak-gpui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

settings_ui: Fix tabbing in settings UI main page content (#41209)

Browse Source 
Tabbing into the main page would move focus to the navigation panel
instead of auto-scrolling. This PR fixes that bug.


Release Notes:

- N/A
This commit is contained in:
Anthony Eid
2025-10-27 17:30:34 -04:00
committed by GitHub
parent ac66e912d5
commit b3483a157c
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/settings_ui/src/settings_ui.rs
+8 -2
View File
@@ -2775,8 +2775,11 @@ impl SettingsWindow {
this.list_state.scroll_to_reveal_item(next_logical_index);
// We need to render the next item to ensure it's focus handle is in the element tree
cx.on_next_frame(window, |_, window, cx| {
window.focus_next();
cx.notify();
cx.on_next_frame(window, |_, window, cx| {
window.focus_next();
cx.notify();
});
});
cx.notify();
return;
@@ -2804,8 +2807,11 @@ impl SettingsWindow {
this.list_state.scroll_to_reveal_item(next_logical_index);
// We need to render the next item to ensure it's focus handle is in the element tree
cx.on_next_frame(window, |_, window, cx| {
window.focus_prev();
cx.notify();
cx.on_next_frame(window, |_, window, cx| {
window.focus_prev();
cx.notify();
});
});
cx.notify();
return;