oak-team/oak-gpui
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

editor: Add toggle diagnostics to command palette (#31358)

Browse Source 
Follow-up to #30316

This PR adds the `editor: toggle diagnostics` action to the comand
palette so that it can also be invoked that way.

I also ensures this, the `toggle inline diagnostics` and `toggle
minimap` actions are only registered if these are supported by the
current editor instance.

Release Notes:

- N/A
This commit is contained in:
Finn Evers
2025-05-24 20:41:02 +00:00
committed by GitHub
parent 34be7830a3
commit a204510cfc
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/editor/src/editor.rs
+1 -2
View File
@@ -15446,8 +15446,7 @@ impl Editor {
.max_severity
.unwrap_or(self.diagnostics_max_severity);
if self.mode.is_minimap()
|| !self.inline_diagnostics_enabled()
if !self.inline_diagnostics_enabled()
|| !self.show_inline_diagnostics
|| max_severity == DiagnosticSeverity::Off
{
crates/editor/src/element.rs
+9 -2
View File
@@ -426,8 +426,15 @@ impl EditorElement {
register_action(editor, window, Editor::toggle_indent_guides);
register_action(editor, window, Editor::toggle_inlay_hints);
register_action(editor, window, Editor::toggle_edit_predictions);
register_action(editor, window, Editor::toggle_inline_diagnostics);
register_action(editor, window, Editor::toggle_minimap);
if editor.read(cx).diagnostics_enabled() {
register_action(editor, window, Editor::toggle_diagnostics);
}
if editor.read(cx).inline_diagnostics_enabled() {
register_action(editor, window, Editor::toggle_inline_diagnostics);
}
if editor.read(cx).supports_minimap(cx) {
register_action(editor, window, Editor::toggle_minimap);
}
register_action(editor, window, hover_popover::hover);
register_action(editor, window, Editor::reveal_in_finder);
register_action(editor, window, Editor::copy_path);