Redact sensitive environment variables in LSP Logs: Server Info (#43480)

Follow-up to: 
- https://github.com/zed-industries/zed/pull/43436
- https://github.com/zed-industries/zed/pull/42831

The changes in #42831 resulted in a regression where environment
variables in the Server Info view were no longer redact. The changes in
#43436 were insufficient as I was still seeing sensitive values in
Nightly e6fe95b4f2 (which includes
#43436).

CC: @SomeoneToIgnore (Hi! 👋 Thanks for keeping this redaction
functionality alive)

Release Notes:

- N/A
This commit is contained in:
Peter Tripp
2025-11-25 21:00:31 +02:00
committed by GitHub
parent 7ecbf8cf60
commit 83f0a3fd13
+5 -5
View File
@@ -340,11 +340,11 @@ impl LspLogView {
* Configuration: {CONFIGURATION}",
NAME = info.status.name,
ID = info.id,
BINARY = info.status.binary.as_ref().map_or_else(
|| "Unknown".to_string(),
|binary| serde_json::to_string_pretty(binary)
.unwrap_or_else(|e| format!("Failed to serialize binary info: {e:#}"))
),
BINARY = info
.status
.binary
.as_ref()
.map_or_else(|| "Unknown".to_string(), |binary| format!("{:#?}", binary)),
WORKSPACE_FOLDERS = info
.status
.workspace_folders