oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable next/previous hunk menu items when there are no hunks (#32907)

Browse Source 
Closes #32887

Release Notes:

- Button menu hunk is disabled if there are no changes
This commit is contained in:
Alvaro Parker
2025-06-22 00:43:00 +03:00
committed by GitHub
parent 0ed6b4ef1a
commit 6fb1081b61
1 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/zed/src/zed/quick_action_bar.rs
+18 -2
View File
@@ -217,6 +217,12 @@ impl Render for QuickActionBar {
});
let editor_selections_dropdown = selection_menu_enabled.then(|| {
let has_diff_hunks = editor
.read(cx)
.buffer()
.read(cx)
.snapshot(cx)
.has_diff_hunks();
let focus = editor.focus_handle(cx);
PopoverMenu::new("editor-selections-dropdown")
@@ -251,8 +257,18 @@ impl Render for QuickActionBar {
.action("Next Problem", Box::new(GoToDiagnostic))
.action("Previous Problem", Box::new(GoToPreviousDiagnostic))
.separator()
.action("Next Hunk", Box::new(GoToHunk))
.action("Previous Hunk", Box::new(GoToPreviousHunk))
.map(|menu| {
if has_diff_hunks {
menu.action("Next Hunk", Box::new(GoToHunk))
.action("Previous Hunk", Box::new(GoToPreviousHunk))
} else {
menu.disabled_action("Next Hunk", Box::new(GoToHunk))
.disabled_action(
"Previous Hunk",
Box::new(GoToPreviousHunk),
)
}
})
.separator()
.action("Move Line Up", Box::new(MoveLineUp))
.action("Move Line Down", Box::new(MoveLineDown))