Do not unwrap when updating inline diagnostics (#31814)

Also do not hold the strong editor reference while debounced.

Release Notes:

- N/A
This commit is contained in:
Kirill Bulatov
2025-05-31 10:10:15 +00:00
committed by GitHub
parent 40c91d5df0
commit 4f1728e5ee
+5 -6
View File
@@ -15703,15 +15703,14 @@ impl Editor {
None
};
self.inline_diagnostics_update = cx.spawn_in(window, async move |editor, cx| {
let editor = editor.upgrade().unwrap();
if let Some(debounce) = debounce {
cx.background_executor().timer(debounce).await;
}
let Some(snapshot) = editor
.update(cx, |editor, cx| editor.buffer().read(cx).snapshot(cx))
.ok()
else {
let Some(snapshot) = editor.upgrade().and_then(|editor| {
editor
.update(cx, |editor, cx| editor.buffer().read(cx).snapshot(cx))
.ok()
}) else {
return;
};