oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

windows: Don't flood windows message queue with gpui messages (#41595)

Browse Source 
Release Notes:

- N/A

Co-authored by: Max Brunsfeld <max@zed.dev>
This commit is contained in:
Lukas Wirth
2025-10-30 20:09:32 +01:00
committed by GitHub
parent ac3b232dda
commit 3944234bab
1 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/gpui/src/platform/windows/dispatcher.rs
+19 -7
View File
@@ -80,15 +80,27 @@ impl PlatformDispatcher for WindowsDispatcher {
}
fn dispatch_on_main_thread(&self, runnable: Runnable) {
let was_empty = self.main_sender.is_empty();
match self.main_sender.send(runnable) {
Ok(_) => unsafe {
PostMessageW(
Some(self.platform_window_handle.as_raw()),
WM_GPUI_TASK_DISPATCHED_ON_MAIN_THREAD,
WPARAM(self.validation_number),
LPARAM(0),
)
.log_err();
// Only send a `WM_GPUI_TASK_DISPATCHED_ON_MAIN_THREAD` to the
// queue if we have no runnables queued up yet, otherwise we
// risk filling the message queue with gpui messages causing us
// to starve the message loop of system messages, resulting in a
// process hang.
//
// When the message loop receives a
// `WM_GPUI_TASK_DISPATCHED_ON_MAIN_THREAD` message we drain the
// runnable queue entirely.
if was_empty {
PostMessageW(
Some(self.platform_window_handle.as_raw()),
WM_GPUI_TASK_DISPATCHED_ON_MAIN_THREAD,
WPARAM(self.validation_number),
LPARAM(0),
)
.log_err();
}
},
Err(runnable) => {
// NOTE: Runnable may wrap a Future that is !Send.