oak-team/oak-gpui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Properly check chunk version on lsp store update (#42951)

Browse Source 
Release Notes:

- N/A

Co-authored-by: Lukas Wirth <lukas@zed.dev>
This commit is contained in:
Kirill Bulatov
2025-11-18 09:13:32 +00:00
committed by GitHub
co-authored by Lukas Wirth
parent 5225a84aff
commit 2a3bcbfe0f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/project/src/lsp_store.rs
+3 -3
View File
@@ -6732,6 +6732,7 @@ impl LspStore {
let buffer_snapshot = buffer.read(cx).snapshot();
let next_hint_id = self.next_hint_id.clone();
let lsp_data = self.latest_lsp_data(&buffer, cx);
let query_version = lsp_data.buffer_version.clone();
let mut lsp_refresh_requested = false;
let for_server = if let InvalidationStrategy::RefreshRequested {
server_id,
@@ -6834,6 +6835,7 @@ impl LspStore {
for (chunk, range_to_query) in ranges_to_query.into_iter().flatten() {
let next_hint_id = next_hint_id.clone();
let buffer = buffer.clone();
let query_version = query_version.clone();
let new_inlay_hints = cx
.spawn(async move |lsp_store, cx| {
let new_fetch_task = lsp_store.update(cx, |lsp_store, cx| {
@@ -6844,9 +6846,7 @@ impl LspStore {
.and_then(|new_hints_by_server| {
lsp_store.update(cx, |lsp_store, cx| {
let lsp_data = lsp_store.latest_lsp_data(&buffer, cx);
let update_cache = !lsp_data
.buffer_version
.changed_since(&buffer.read(cx).version());
let update_cache = lsp_data.buffer_version == query_version;
if new_hints_by_server.is_empty() {
if update_cache {
lsp_data.inlay_hints.invalidate_for_chunk(chunk);