Fix spacing around hidden status bar items (#39992)
This is a follow-up PR to https://github.com/zed-industries/zed/pull/39609, and attempts to address hidden status bar items still contributing to the layout and creating extra spacing.  - 203cbd634bfb1489b8afa4952d9594615a956b77 Adds a `.none()` method to the `gpui::Styled` helper trait, so that status items can set their display type to none inside their `render` method. - 249f06e3de63b0ab32814f20e7105d8e2b642f02 Applies `.none()` to all the status items. - ~~499f564906c88336608c81615b11ebc9ab43d832~~ At first I was adding an `is_visible` method to the `StatusBarView` trait, which would be used to skip status bar items which would just render an empty div anyway, but I felt duplicating the conditions for hiding the buttons between the status items `is_visible` and `render` methods could be an attraction for bugs, so I tried to find another approach. This commit contains those changes, reverted immediately (if the `is_visible` approach is preferred I can bring it back!) - f37cb75f0519ceea1f3e1cc4f97087a5cb34b0fd (bonus!) Adds a condition to the vim mode indicator to avoid a leading space when there are no pending keys. Release Notes: - N/A
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
use gpui::{Context, Element, Entity, Render, Subscription, WeakEntity, Window, div};
|
||||
use gpui::{Context, Entity, Render, Subscription, WeakEntity, Window, div};
|
||||
use ui::text_for_keystrokes;
|
||||
use workspace::{StatusItemView, item::ItemHandle, ui::prelude::*};
|
||||
|
||||
@@ -89,7 +89,7 @@ impl Render for ModeIndicator {
|
||||
fn render(&mut self, _: &mut Window, cx: &mut Context<Self>) -> impl IntoElement {
|
||||
let vim = self.vim();
|
||||
let Some(vim) = vim else {
|
||||
return div().into_any();
|
||||
return div().hidden().into_any_element();
|
||||
};
|
||||
|
||||
let vim_readable = vim.read(cx);
|
||||
|
||||
Reference in New Issue
Block a user