Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
314 lines
9.0 KiB
C++
314 lines
9.0 KiB
C++
/***
|
|
|
|
Olive - Non-Linear Video Editor
|
|
Copyright (C) 2022 Olive Team
|
|
Modifications Copyright (C) 2025 mikesolar
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
***/
|
|
|
|
#include "h264section.h"
|
|
|
|
#include <QCheckBox>
|
|
#include <QComboBox>
|
|
#include <QGridLayout>
|
|
#include <QLabel>
|
|
|
|
#include "common/qtutils.h"
|
|
#include "widget/slider/integerslider.h"
|
|
|
|
namespace olive
|
|
{
|
|
|
|
H264Section::H264Section(QWidget *parent)
|
|
: H264Section(H264CRFSection::k_default_h264_crf, parent)
|
|
{
|
|
}
|
|
|
|
H264Section::H264Section(int default_crf, QWidget *parent)
|
|
: CodecSection(parent)
|
|
{
|
|
QGridLayout *layout = new QGridLayout(this);
|
|
layout->setContentsMargins(0, 0, 0, 0);
|
|
|
|
int row = 0;
|
|
layout->addWidget(new QLabel(tr("Encode Speed:")), row, 0);
|
|
|
|
preset_combobox_ = new QComboBox();
|
|
preset_combobox_->setToolTip(tr(
|
|
"This setting allows you to tweak the ratio of export speed to compression quality. \n\n"
|
|
"If using Constant Rate Factor, slower speeds will result in smaller file sizes for the same quality. \n\n"
|
|
"If using Target Bit Rate or Target File Size, slower speeds will result in higher quality for the same bitrate/filesize. \n\n"
|
|
"This setting is equivalent to the `preset` setting in libx264."));
|
|
|
|
preset_combobox_->addItem(tr("Ultra Fast"));
|
|
preset_combobox_->addItem(tr("Super Fast"));
|
|
preset_combobox_->addItem(tr("Very Fast"));
|
|
preset_combobox_->addItem(tr("Faster"));
|
|
preset_combobox_->addItem(tr("Fast"));
|
|
preset_combobox_->addItem(tr("Medium"));
|
|
preset_combobox_->addItem(tr("Slow"));
|
|
preset_combobox_->addItem(tr("Slower"));
|
|
preset_combobox_->addItem(tr("Very Slow"));
|
|
|
|
//Default to "medium"
|
|
preset_combobox_->setCurrentIndex(5);
|
|
|
|
layout->addWidget(preset_combobox_, row, 1);
|
|
|
|
row++;
|
|
|
|
layout->addWidget(new QLabel(tr("Compression Method:")), row, 0);
|
|
|
|
QComboBox *compression_box = new QComboBox();
|
|
|
|
// These items must correspond to the CompressionMethod enum
|
|
compression_box->addItem(tr("Constant Rate Factor"));
|
|
compression_box->addItem(tr("Target Bit Rate"));
|
|
compression_box->addItem(tr("Target File Size"));
|
|
|
|
layout->addWidget(compression_box, row, 1);
|
|
|
|
row++;
|
|
|
|
compression_method_stack_ = new QStackedWidget();
|
|
layout->addWidget(compression_method_stack_, row, 0, 1, 2);
|
|
|
|
crf_section_ = new H264CRFSection(default_crf);
|
|
compression_method_stack_->addWidget(crf_section_);
|
|
|
|
bitrate_section_ = new H264BitRateSection();
|
|
compression_method_stack_->addWidget(bitrate_section_);
|
|
|
|
filesize_section_ = new H264FileSizeSection();
|
|
compression_method_stack_->addWidget(filesize_section_);
|
|
|
|
connect(
|
|
compression_box,
|
|
static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
|
|
compression_method_stack_, &QStackedWidget::setCurrentIndex);
|
|
}
|
|
|
|
void H264Section::add_opts(EncodingParams *params)
|
|
{
|
|
// FIXME: Implement two-pass
|
|
|
|
CompressionMethod method = static_cast<CompressionMethod>(
|
|
compression_method_stack_->currentIndex());
|
|
|
|
// This option is not used by the encoder (nor is anything with the ove_ prefix), it's to help us
|
|
// identify which option was chosen when params are restored
|
|
params->set_video_option(QStringLiteral("ove_compressionmethod"),
|
|
QString::number(method));
|
|
|
|
if (method == k_constant_rate_factor) {
|
|
// Simply set CRF value
|
|
params->set_video_option(QStringLiteral("crf"),
|
|
QString::number(crf_section_->get_value()));
|
|
|
|
} else {
|
|
int64_t target_rate, max_rate, min_rate;
|
|
|
|
if (method == k_target_bit_rate) {
|
|
// Use user-supplied values for the bit rate
|
|
target_rate = bitrate_section_->get_target_bit_rate();
|
|
min_rate = 0;
|
|
max_rate = bitrate_section_->get_maximum_bit_rate();
|
|
} else {
|
|
// Calculate the bit rate from the file size divided by the sequence length in seconds (bits per second)
|
|
int64_t target_fs = filesize_section_->get_file_size();
|
|
target_rate = qRound64(static_cast<double>(target_fs) /
|
|
params->get_export_length().to_double());
|
|
min_rate = target_rate;
|
|
max_rate = target_rate;
|
|
|
|
params->set_video_option(QStringLiteral("ove_targetfilesize"),
|
|
QString::number(target_fs));
|
|
}
|
|
|
|
// Disable CRF encoding
|
|
params->set_video_option(QStringLiteral("crf"), QStringLiteral("-1"));
|
|
|
|
params->set_video_bit_rate(target_rate);
|
|
params->set_video_min_bit_rate(min_rate);
|
|
params->set_video_max_bit_rate(max_rate);
|
|
params->set_video_buffer_size(2000000);
|
|
}
|
|
|
|
params->set_video_option(QStringLiteral("preset"),
|
|
QString::number(preset_combobox_->currentIndex()));
|
|
}
|
|
|
|
void H264Section::set_opts(const EncodingParams *p)
|
|
{
|
|
CompressionMethod method = static_cast<CompressionMethod>(
|
|
p->video_option(QStringLiteral("ove_compressionmethod")).toInt());
|
|
|
|
compression_method_stack_->setCurrentIndex(method);
|
|
|
|
if (method == k_constant_rate_factor) {
|
|
crf_section_->set_value(p->video_option(QStringLiteral("crf")).toInt());
|
|
} else {
|
|
int64_t target_rate = p->video_bit_rate();
|
|
int64_t max_rate = p->video_max_bit_rate();
|
|
|
|
if (method == k_target_bit_rate) {
|
|
// Use user-supplied values for the bit rate
|
|
bitrate_section_->set_target_bit_rate(target_rate);
|
|
bitrate_section_->set_maximum_bit_rate(max_rate);
|
|
} else {
|
|
// Calculate the bit rate from the file size divided by the sequence length in seconds (bits per second)
|
|
filesize_section_->set_file_size(
|
|
p->video_option(QStringLiteral("ove_targetfilesize"))
|
|
.toLongLong());
|
|
}
|
|
}
|
|
}
|
|
|
|
H264CRFSection::H264CRFSection(int default_crf, QWidget *parent)
|
|
: QWidget(parent)
|
|
{
|
|
QHBoxLayout *layout = new QHBoxLayout(this);
|
|
layout->setContentsMargins(0, 0, 0, 0);
|
|
|
|
crf_slider_ = new QSlider(Qt::Horizontal);
|
|
crf_slider_->setMinimum(k_minimum_crf);
|
|
crf_slider_->setMaximum(k_maximum_crf);
|
|
crf_slider_->setValue(default_crf);
|
|
layout->addWidget(crf_slider_);
|
|
|
|
IntegerSlider *crf_input = new IntegerSlider();
|
|
crf_input->setMaximumWidth(QtUtils::q_font_metrics_width(
|
|
crf_input->fontMetrics(), QStringLiteral("HHHH")));
|
|
crf_input->set_minimum(k_minimum_crf);
|
|
crf_input->set_maximum(k_maximum_crf);
|
|
crf_input->set_value(default_crf);
|
|
crf_input->SetDefaultValue(default_crf);
|
|
layout->addWidget(crf_input);
|
|
|
|
connect(crf_slider_, &QSlider::valueChanged, crf_input,
|
|
&IntegerSlider::set_value);
|
|
connect(crf_input, &IntegerSlider::value_changed, crf_slider_,
|
|
&QSlider::setValue);
|
|
}
|
|
|
|
int H264CRFSection::get_value() const
|
|
{
|
|
return crf_slider_->value();
|
|
}
|
|
|
|
void H264CRFSection::set_value(int c)
|
|
{
|
|
crf_slider_->setValue(c);
|
|
}
|
|
|
|
H264BitRateSection::H264BitRateSection(QWidget *parent)
|
|
: QWidget(parent)
|
|
{
|
|
QGridLayout *layout = new QGridLayout(this);
|
|
layout->setContentsMargins(0, 0, 0, 0);
|
|
|
|
int row = 0;
|
|
|
|
layout->addWidget(new QLabel(tr("Target Bit Rate (Mbps):")), row, 0);
|
|
|
|
target_rate_ = new FloatSlider();
|
|
target_rate_->set_minimum(0);
|
|
layout->addWidget(target_rate_, row, 1);
|
|
|
|
row++;
|
|
|
|
layout->addWidget(new QLabel(tr("Maximum Bit Rate (Mbps):")), row, 0);
|
|
|
|
max_rate_ = new FloatSlider();
|
|
max_rate_->set_minimum(0);
|
|
layout->addWidget(max_rate_, row, 1);
|
|
|
|
row++;
|
|
|
|
layout->addWidget(new QLabel(tr("Two-Pass")), row, 0);
|
|
|
|
QCheckBox *two_pass_box = new QCheckBox();
|
|
layout->addWidget(two_pass_box, row, 1);
|
|
|
|
// Bit rate defaults
|
|
target_rate_->set_value(16.0);
|
|
max_rate_->set_value(32.0);
|
|
}
|
|
|
|
int64_t H264BitRateSection::get_target_bit_rate() const
|
|
{
|
|
return qRound64(target_rate_->get_value() * 1000000.0);
|
|
}
|
|
|
|
void H264BitRateSection::set_target_bit_rate(int64_t b)
|
|
{
|
|
target_rate_->set_value(double(b) * 0.000001);
|
|
}
|
|
|
|
int64_t H264BitRateSection::get_maximum_bit_rate() const
|
|
{
|
|
return qRound64(max_rate_->get_value() * 1000000.0);
|
|
}
|
|
|
|
void H264BitRateSection::set_maximum_bit_rate(int64_t b)
|
|
{
|
|
max_rate_->set_value(double(b) * 0.000001);
|
|
}
|
|
|
|
H264FileSizeSection::H264FileSizeSection(QWidget *parent)
|
|
: QWidget(parent)
|
|
{
|
|
QGridLayout *layout = new QGridLayout(this);
|
|
layout->setContentsMargins(0, 0, 0, 0);
|
|
|
|
int row = 0;
|
|
|
|
layout->addWidget(new QLabel(tr("Target File Size (MB):")), row, 0);
|
|
|
|
file_size_ = new FloatSlider();
|
|
file_size_->set_minimum(0);
|
|
layout->addWidget(file_size_, row, 1);
|
|
|
|
row++;
|
|
|
|
layout->addWidget(new QLabel(tr("Two-Pass")), row, 0);
|
|
|
|
QCheckBox *two_pass_box = new QCheckBox();
|
|
layout->addWidget(two_pass_box, row, 1);
|
|
|
|
// File size defaults
|
|
file_size_->set_value(700.0);
|
|
}
|
|
|
|
int64_t H264FileSizeSection::get_file_size() const
|
|
{
|
|
// Convert megabytes to BITS
|
|
return qRound64(file_size_->get_value() * 1024.0 * 1024.0 * 8.0);
|
|
}
|
|
|
|
void H264FileSizeSection::set_file_size(int64_t f)
|
|
{
|
|
// Convert bits back to megabytes
|
|
file_size_->set_value(double(f) / 8.0 / 1024.0 / 1024.0);
|
|
}
|
|
|
|
H265Section::H265Section(QWidget *parent)
|
|
: H264Section(H264CRFSection::k_default_h265_crf, parent)
|
|
{
|
|
}
|
|
|
|
}
|