Mike-Solar
13ddd8c0e7
The macOS job finally reached the build (after the vcpkg manifest fix) and hit a macOS-only compile error in the VideoToolbox import: `*ptr as *const T` parses as `(*ptr) as *const T`, so `sw_format` was read off a pointer instead of the AVHWFramesContext. Bind the frames pointer first. Also fix the warnings the cross-check surfaced: the redundant MTLPixelFormat import, and doc comments on an extern block and a thread_local! (rustdoc does not document those). Verified locally with a host-cc wrapper: `cargo check -p oak-core -p oak-codec -p oak-node -p oak-render -p oak-task -p oak-plugin --target aarch64-apple-darwin` is clean. (oak-app itself needs a real Apple toolchain for ring.)
oakcore-rs — Rust value-type foundation for the oak Rust modules
Status: declaration draft for review (no implementation, not wired into any build). Companion to
crates/oaknodeandcrates/oakrender.
Rust reimplementation of the oakcore C++ value types that cross every
module boundary: Rational, TimeRange, TimeRangeList, pixel/sample
format enums. These are pure data types with value semantics — the one
place where duplicating the C++ layout discipline in plain Rust is both
safe and required (a Rust crate cannot hold C++ objects by value).
Rules:
- Bit-exact arithmetic compatibility with
olive::core::Rational(reduction, overflow behavior, comparison) — the golden rule is the C++ test-suite semantics, not "ideal" rational math. #[repr(C)]only where a type crosses the C ABI; everything else is plain Rust withCopy + Clone + Eq + Hash.- No I/O, no allocation in arithmetic paths, no panics on degenerate input (denominator zero follows the C++ sentinel semantics).