Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
94 lines
2.8 KiB
C++
94 lines
2.8 KiB
C++
/*
|
|
* Oak Video Editor - Non-Linear Video Editor
|
|
* Copyright (C) 2025 Olive CE Team
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "exportsubtitlestab.h"
|
|
|
|
#include <QGridLayout>
|
|
|
|
namespace olive
|
|
{
|
|
|
|
ExportSubtitlesTab::ExportSubtitlesTab(QWidget *parent)
|
|
: QWidget(parent)
|
|
{
|
|
QVBoxLayout *outer_layout = new QVBoxLayout(this);
|
|
|
|
QGridLayout *layout = new QGridLayout();
|
|
outer_layout->addLayout(layout);
|
|
|
|
int row = 0;
|
|
|
|
sidecar_checkbox_ = new QCheckBox(tr("Export to sidecar file"));
|
|
layout->addWidget(sidecar_checkbox_, row, 0, 1, 2);
|
|
|
|
row++;
|
|
|
|
sidecar_format_label_ = new QLabel(tr("Sidecar Format:"));
|
|
sidecar_format_label_->setVisible(false);
|
|
layout->addWidget(sidecar_format_label_, row, 0);
|
|
|
|
sidecar_format_combobox_ =
|
|
new ExportFormatComboBox(ExportFormatComboBox::k_show_subtitles_only);
|
|
sidecar_format_combobox_->setVisible(true);
|
|
layout->addWidget(sidecar_format_combobox_, row, 1);
|
|
|
|
row++;
|
|
|
|
layout->addWidget(new QLabel(tr("Codec:")), row, 0);
|
|
|
|
codec_combobox_ = new QComboBox();
|
|
layout->addWidget(codec_combobox_, row, 1);
|
|
|
|
outer_layout->addStretch();
|
|
|
|
connect(sidecar_checkbox_, &QCheckBox::toggled, sidecar_format_label_,
|
|
&QWidget::setVisible);
|
|
connect(sidecar_checkbox_, &QCheckBox::toggled, sidecar_format_combobox_,
|
|
&QWidget::setVisible);
|
|
}
|
|
|
|
int ExportSubtitlesTab::set_format(ExportFormat::Format format)
|
|
{
|
|
auto vcodecs = ExportFormat::get_video_codecs(format);
|
|
auto acodecs = ExportFormat::get_audio_codecs(format);
|
|
|
|
auto scodecs = ExportFormat::get_subtitle_codecs(format);
|
|
|
|
if (!scodecs.empty() && vcodecs.empty() && acodecs.empty()) {
|
|
// If format supports ONLY scodecs, default this to off and disable it
|
|
sidecar_checkbox_->setChecked(false);
|
|
sidecar_checkbox_->setEnabled(false);
|
|
} else {
|
|
// If format does not support scodecs, default this to checked and disable it
|
|
sidecar_checkbox_->setChecked(scodecs.empty());
|
|
sidecar_checkbox_->setEnabled(!scodecs.empty());
|
|
}
|
|
|
|
scodecs =
|
|
ExportFormat::get_subtitle_codecs(sidecar_format_combobox_->get_format());
|
|
|
|
codec_combobox_->clear();
|
|
foreach (ExportCodec::Codec scodec, scodecs) {
|
|
codec_combobox_->addItem(ExportCodec::get_codec_name(scodec), scodec);
|
|
}
|
|
|
|
return scodecs.size();
|
|
}
|
|
|
|
}
|