Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
261 lines
5.5 KiB
C++
261 lines
5.5 KiB
C++
/***
|
|
|
|
Olive - Non-Linear Video Editor
|
|
Copyright (C) 2022 Olive Team
|
|
Modifications Copyright (C) 2025 mikesolar
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
***/
|
|
|
|
#include "nodeviewedge.h"
|
|
|
|
#include <QApplication>
|
|
#include <QDebug>
|
|
#include <QGraphicsSceneMouseEvent>
|
|
#include <QStyleOptionGraphicsItem>
|
|
|
|
#include "common/lerp.h"
|
|
#include "nodeview.h"
|
|
#include "nodeviewitem.h"
|
|
#include "nodeviewscene.h"
|
|
|
|
namespace olive
|
|
{
|
|
|
|
#define super QGraphicsPathItem
|
|
|
|
NodeViewEdge::NodeViewEdge(Node *output, const NodeInput &input,
|
|
NodeViewItem *from_item, NodeViewItem *to_item,
|
|
QGraphicsItem *parent)
|
|
: super(parent)
|
|
, output_(output)
|
|
, input_(input)
|
|
, from_item_(from_item)
|
|
, to_item_(to_item)
|
|
{
|
|
init();
|
|
set_connected(true);
|
|
|
|
from_item_->add_edge(this);
|
|
to_item_->add_edge(this);
|
|
}
|
|
|
|
NodeViewEdge::NodeViewEdge(QGraphicsItem *parent)
|
|
: QGraphicsPathItem(parent)
|
|
, from_item_(nullptr)
|
|
, to_item_(nullptr)
|
|
{
|
|
init();
|
|
}
|
|
|
|
NodeViewEdge::~NodeViewEdge()
|
|
{
|
|
if (from_item_) {
|
|
from_item_->remove_edge(this);
|
|
}
|
|
|
|
if (to_item_) {
|
|
to_item_->remove_edge(this);
|
|
}
|
|
}
|
|
|
|
void NodeViewEdge::set_from_item(NodeViewItem *i)
|
|
{
|
|
if (from_item_) {
|
|
from_item_->remove_edge(this);
|
|
}
|
|
|
|
from_item_ = i;
|
|
|
|
if (from_item_) {
|
|
from_item_->add_edge(this);
|
|
}
|
|
|
|
adjust();
|
|
}
|
|
|
|
void NodeViewEdge::set_to_item(NodeViewItem *i)
|
|
{
|
|
if (to_item_) {
|
|
to_item_->remove_edge(this);
|
|
}
|
|
|
|
to_item_ = i;
|
|
|
|
if (to_item_) {
|
|
to_item_->add_edge(this);
|
|
}
|
|
|
|
adjust();
|
|
}
|
|
|
|
void NodeViewEdge::adjust()
|
|
{
|
|
// Draw a line between the two
|
|
set_points(from_item()->get_output_point(), to_item()->get_input_point());
|
|
}
|
|
|
|
void NodeViewEdge::set_connected(bool c)
|
|
{
|
|
connected_ = c;
|
|
|
|
update();
|
|
}
|
|
|
|
void NodeViewEdge::set_highlighted(bool e)
|
|
{
|
|
highlighted_ = e;
|
|
|
|
update();
|
|
}
|
|
|
|
void NodeViewEdge::set_points(const QPointF &start, const QPointF &end)
|
|
{
|
|
cached_start_ = start;
|
|
cached_end_ = end;
|
|
|
|
update_curve();
|
|
}
|
|
|
|
void NodeViewEdge::set_curved(bool e)
|
|
{
|
|
curved_ = e;
|
|
|
|
update_curve();
|
|
}
|
|
|
|
void NodeViewEdge::paint(QPainter *painter,
|
|
const QStyleOptionGraphicsItem *option, QWidget *)
|
|
{
|
|
QPalette::ColorGroup group;
|
|
QPalette::ColorRole role;
|
|
|
|
if (connected_) {
|
|
group = QPalette::Active;
|
|
} else {
|
|
group = QPalette::Disabled;
|
|
}
|
|
|
|
if (highlighted_ != bool(option->state & QStyle::State_Selected)) {
|
|
role = QPalette::Highlight;
|
|
} else {
|
|
role = QPalette::Text;
|
|
}
|
|
|
|
// Draw main path
|
|
QColor edge_color = qApp->palette().color(group, role);
|
|
|
|
painter->setPen(QPen(edge_color, edge_width_));
|
|
painter->setBrush(Qt::NoBrush);
|
|
painter->drawPath(path());
|
|
}
|
|
|
|
void NodeViewEdge::init()
|
|
{
|
|
connected_ = false;
|
|
highlighted_ = false;
|
|
curved_ = true;
|
|
|
|
setFlag(QGraphicsItem::ItemIsSelectable);
|
|
|
|
// Ensures this UI object is drawn behind other objects
|
|
setZValue(-1);
|
|
|
|
// Use font metrics to set edge width for basic high DPI support
|
|
edge_width_ = QFontMetrics(QFont()).height() / 12;
|
|
}
|
|
|
|
void NodeViewEdge::update_curve()
|
|
{
|
|
const QPointF &start = cached_start_;
|
|
const QPointF &end = cached_end_;
|
|
|
|
QPainterPath path;
|
|
path.moveTo(start);
|
|
|
|
double angle = std::atan2(end.y() - start.y(), end.x() - start.x());
|
|
|
|
if (curved_) {
|
|
double half_x = lerp(start.x(), end.x(), 0.5);
|
|
double half_y = lerp(start.y(), end.y(), 0.5);
|
|
|
|
QPointF cp1, cp2;
|
|
|
|
NodeViewCommon::FlowDirection from_flow =
|
|
from_item_ ? from_item_->get_flow_direction() :
|
|
NodeViewCommon::k_invalid_direction;
|
|
NodeViewCommon::FlowDirection to_flow =
|
|
to_item_ ? to_item_->get_flow_direction() :
|
|
NodeViewCommon::k_invalid_direction;
|
|
|
|
if (from_flow == NodeViewCommon::k_invalid_direction &&
|
|
to_flow == NodeViewCommon::k_invalid_direction) {
|
|
// This is a technically unsupported scenario, but to avoid issues, we'll use a fallback
|
|
from_flow = NodeViewCommon::k_left_to_right;
|
|
to_flow = NodeViewCommon::k_left_to_right;
|
|
} else if (from_flow == NodeViewCommon::k_invalid_direction) {
|
|
from_flow = to_flow;
|
|
} else if (to_flow == NodeViewCommon::k_invalid_direction) {
|
|
to_flow = from_flow;
|
|
}
|
|
|
|
if (NodeViewCommon::get_flow_orientation(from_flow) == Qt::Horizontal) {
|
|
cp1 = QPointF(half_x, start.y());
|
|
} else {
|
|
cp1 = QPointF(start.x(), half_y);
|
|
}
|
|
|
|
if (NodeViewCommon::get_flow_orientation(to_flow) == Qt::Horizontal) {
|
|
cp2 = QPointF(half_x, end.y());
|
|
} else {
|
|
cp2 = QPointF(end.x(), half_y);
|
|
}
|
|
|
|
path.cubicTo(cp1, cp2, end);
|
|
|
|
if (!qFuzzyCompare(start.x(), end.x())) {
|
|
double continue_x = end.x() - std::cos(angle);
|
|
|
|
double x1 = start.x();
|
|
double x2 = cp1.x();
|
|
double x3 = cp2.x();
|
|
double x4 = end.x();
|
|
double y1 = start.y();
|
|
double y2 = cp1.y();
|
|
double y3 = cp2.y();
|
|
double y4 = end.y();
|
|
|
|
if (start.x() >= end.x()) {
|
|
std::swap(x1, x4);
|
|
std::swap(x2, x3);
|
|
std::swap(y1, y4);
|
|
std::swap(y2, y3);
|
|
}
|
|
|
|
double t = Bezier::cubic_xto_t(continue_x, x1, x2, x3, x4);
|
|
double y = Bezier::cubic_tto_y(y1, y2, y3, y4, t);
|
|
|
|
angle = std::atan2(end.y() - y, end.x() - continue_x);
|
|
}
|
|
|
|
} else {
|
|
path.lineTo(end);
|
|
}
|
|
|
|
setPath(mapFromScene(path));
|
|
}
|
|
|
|
}
|