Mike-Solar
bb40b4923e
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
37 lines
1.1 KiB
C++
37 lines
1.1 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include "common/debug.h"
|
|
|
|
TEST(CommonDebug, DebugHandlerFormatsAllLevels)
|
|
{
|
|
// DebugHandler writes "[LEVEL] message" lines to stderr
|
|
testing::internal::CaptureStderr();
|
|
QtMessageHandler old = qInstallMessageHandler(olive::debug_handler);
|
|
|
|
qDebug() << "debug message";
|
|
qInfo() << "info message";
|
|
qWarning() << "warning message";
|
|
qCritical() << "critical message";
|
|
|
|
qInstallMessageHandler(old);
|
|
std::string out = testing::internal::GetCapturedStderr();
|
|
|
|
// Each level must get its own tag, paired with its message on one line
|
|
QString output = QString::fromStdString(out);
|
|
const QStringList lines = output.split('\n');
|
|
auto has_line = [&lines](const char *tag, const char *text) {
|
|
for (const QString &line : lines) {
|
|
if (line.contains(QString::fromLatin1(tag)) &&
|
|
line.contains(QString::fromLatin1(text))) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
};
|
|
|
|
EXPECT_TRUE(has_line("[DEBUG]", "debug message"));
|
|
EXPECT_TRUE(has_line("[INFO]", "info message"));
|
|
EXPECT_TRUE(has_line("[WARNING]", "warning message"));
|
|
EXPECT_TRUE(has_line("[ERROR]", "critical message"));
|
|
}
|