Mike-Solar
bb40b4923e
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
56 lines
1.2 KiB
C++
56 lines
1.2 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include "node/traverser.h"
|
|
#include "node/value.h"
|
|
#include "render/job/pluginjob.h"
|
|
#include "render/texture.h"
|
|
#include "render/videoparams.h"
|
|
|
|
namespace
|
|
{
|
|
|
|
class PluginJobTraverser : public olive::NodeTraverser {
|
|
public:
|
|
void resolve(olive::NodeValue &value)
|
|
{
|
|
resolve_jobs(value);
|
|
}
|
|
|
|
bool called() const
|
|
{
|
|
return called_;
|
|
}
|
|
|
|
protected:
|
|
olive::TexturePtr process_plugin_job(olive::TexturePtr /*texture*/,
|
|
olive::TexturePtr destination,
|
|
const olive::Node * /*node*/) override
|
|
{
|
|
called_ = true;
|
|
return destination;
|
|
}
|
|
|
|
private:
|
|
bool called_ = false;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
TEST(PluginRenderPipeline, PluginJobIsResolved)
|
|
{
|
|
olive::VideoParams params(320, 240, olive::core::PixelFormat::u8, 4);
|
|
|
|
olive::plugin::PluginJob job(nullptr, nullptr, olive::NodeValueRow());
|
|
olive::TexturePtr job_tex = olive::Texture::job(params, job);
|
|
|
|
olive::NodeValue val(olive::NodeValue::k_texture, job_tex);
|
|
|
|
PluginJobTraverser traverser;
|
|
traverser.set_cache_video_params(params);
|
|
traverser.resolve(val);
|
|
|
|
EXPECT_TRUE(traverser.called());
|
|
ASSERT_TRUE(val.to_texture());
|
|
EXPECT_NE(val.to_texture().get(), job_tex.get());
|
|
}
|