Compiler hygiene (all platforms): - Silence warnings across the tree: missing override, -Wreorder ctor init, -Wshadow, -Wsign-compare, missing switch cases, unused functions/captures, Qt 6.11 deprecations (QMouseEvent/QDropEvent accessors, qAsConst, Q_FOREACH over non-shared containers, AA_UseHighDpiPixmaps) and the .bak/ backup tree removal. - Fix regressions from the cleanup: missing clip decls in capi/timeline.cpp, plugin.cpp rename fallout, panel setFocus ambiguity, QGraphicsItem::pos vs event->position(), duplicate k_push_button case, boolean test variable. Windows: - Qt portability: CommandLineParser is_set/add_option, QTimeZone systemTimeZone (QTimeZone::LocalTime is 6.11-only), k_progress_* enum. - Linking: stop adding oakengine to OLIVE_LIBRARIES (import lib plus oakengine-obj caused multiple definitions); add OAKENGINE_STATIC so internal consumers no longer reference __imp_* stubs. - oakengine.ver: export olive::Renderer typeinfo so liboakgl.so can be dlopened (Linux), DynamicRenderer no longer dlcloses backend libraries (crash in RenderManager's dtor calling into unmapped memory). - OTIO runtime: copy DLLs next to every binary on Windows instead of relying on PATH (0xc0000135 in gtest discovery). - Headless GL: the runner only has GDI OpenGL 1.1, killing every render worker. Deploy Mesa llvmpipe as opengl32sw.dll (Qt's software-GL channel) with QT_OPENGL=software, and let QT_OPENGL override the AA_UseDesktopOpenGL default. ExportTask fails fast after 8 consecutive undelivered frames instead of segfaulting or grinding forever; FFmpegEncoder::write_frame tolerates null frames. - Tests: GetTempPathA+PID temp dirs, GetLongPathNameA for 8.3 names, forward-slash normalization when comparing project filenames. Linux: - Install libshaderc-dev so oakvulkan compiles GLSL (Vulkan tests). - Accept UNORM floor-or-round (63/64) in the blit ping-pong test. - Skip MainWindow construction test on the offscreen QPA (cannot paint QOpenGLWidget). Also: oak_cli_transcode gets a 300s ctest timeout, worker logs GL context version and LoadGraph/render_frame stages, and docs/plans/eliminate-event-bridge-issues.md (English translation).
249 lines
6.8 KiB
C++
249 lines
6.8 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include <QDebug>
|
|
#include <QTemporaryDir>
|
|
#include <QTemporaryFile>
|
|
|
|
#include "common/filefunctions.h"
|
|
|
|
namespace
|
|
{
|
|
|
|
// Collects qDebug/qWarning/qCritical output for inspection
|
|
QStringList g_captured_messages;
|
|
|
|
void capture_message_handler(QtMsgType, const QMessageLogContext &,
|
|
const QString &msg)
|
|
{
|
|
g_captured_messages.append(msg);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
TEST(CommonFileFunctions, EnsureFilenameExtension)
|
|
{
|
|
EXPECT_EQ(olive::FileFunctions::ensure_filename_extension(
|
|
QStringLiteral("project"), QStringLiteral("ove")),
|
|
QStringLiteral("project.ove"));
|
|
EXPECT_EQ(olive::FileFunctions::ensure_filename_extension(
|
|
QStringLiteral("project.ove"), QStringLiteral("ove")),
|
|
QStringLiteral("project.ove"));
|
|
EXPECT_EQ(olive::FileFunctions::ensure_filename_extension(
|
|
QStringLiteral("PROJECT"), QStringLiteral("ove")),
|
|
QStringLiteral("PROJECT.ove"));
|
|
EXPECT_TRUE(olive::FileFunctions::ensure_filename_extension(
|
|
QString(), QStringLiteral("ove"))
|
|
.isEmpty());
|
|
EXPECT_EQ(olive::FileFunctions::ensure_filename_extension(
|
|
QStringLiteral("project"), QString()),
|
|
QStringLiteral("project"));
|
|
}
|
|
|
|
TEST(CommonFileFunctions, GetSafeTemporaryFilename)
|
|
{
|
|
QTemporaryDir dir;
|
|
ASSERT_TRUE(dir.isValid());
|
|
|
|
QString base = dir.filePath(QStringLiteral("test.ove"));
|
|
QString first = olive::FileFunctions::get_safe_temporary_filename(base);
|
|
EXPECT_FALSE(QFileInfo::exists(first));
|
|
EXPECT_TRUE(first.contains(QStringLiteral(".tmp0.")));
|
|
|
|
QFile f(first);
|
|
(void)f.open(QIODevice::WriteOnly);
|
|
f.close();
|
|
|
|
QString second = olive::FileFunctions::get_safe_temporary_filename(base);
|
|
EXPECT_NE(first, second);
|
|
EXPECT_TRUE(second.contains(QStringLiteral(".tmp1.")));
|
|
}
|
|
|
|
TEST(CommonFileFunctions, DirectoryIsValid)
|
|
{
|
|
QTemporaryDir dir;
|
|
ASSERT_TRUE(dir.isValid());
|
|
|
|
EXPECT_TRUE(
|
|
olive::FileFunctions::directory_is_valid(QDir(dir.path()), false));
|
|
|
|
QDir nonexistent(dir.filePath(QStringLiteral("subdir/nested")));
|
|
EXPECT_TRUE(olive::FileFunctions::directory_is_valid(nonexistent, true));
|
|
EXPECT_TRUE(nonexistent.exists());
|
|
}
|
|
|
|
TEST(CommonFileFunctions, RenameFileAllowOverwrite)
|
|
{
|
|
QTemporaryDir dir;
|
|
ASSERT_TRUE(dir.isValid());
|
|
|
|
QString from = dir.filePath(QStringLiteral("from.txt"));
|
|
QString to = dir.filePath(QStringLiteral("to.txt"));
|
|
|
|
QFile f(from);
|
|
(void)f.open(QIODevice::WriteOnly);
|
|
f.write("source");
|
|
f.close();
|
|
|
|
QFile t(to);
|
|
(void)t.open(QIODevice::WriteOnly);
|
|
t.write("existing");
|
|
t.close();
|
|
|
|
EXPECT_TRUE(olive::FileFunctions::rename_file_allow_overwrite(from, to));
|
|
EXPECT_FALSE(QFileInfo::exists(from));
|
|
QFile result(to);
|
|
(void)result.open(QIODevice::ReadOnly);
|
|
EXPECT_EQ(result.readAll(), QByteArray("source"));
|
|
}
|
|
|
|
TEST(CommonFileFunctions, CanCopyDirectoryWithoutOverwriting)
|
|
{
|
|
QTemporaryDir src;
|
|
QTemporaryDir dst;
|
|
ASSERT_TRUE(src.isValid());
|
|
ASSERT_TRUE(dst.isValid());
|
|
|
|
QString src_file = QDir(src.path()).filePath(QStringLiteral("file.txt"));
|
|
QFile f(src_file);
|
|
(void)f.open(QIODevice::WriteOnly);
|
|
f.close();
|
|
|
|
EXPECT_TRUE(olive::FileFunctions::can_copy_directory_without_overwriting(
|
|
src.path(), dst.path()));
|
|
|
|
QString dst_file = QDir(dst.path()).filePath(QStringLiteral("file.txt"));
|
|
QFile g(dst_file);
|
|
(void)g.open(QIODevice::WriteOnly);
|
|
g.close();
|
|
|
|
EXPECT_FALSE(olive::FileFunctions::can_copy_directory_without_overwriting(
|
|
src.path(), dst.path()));
|
|
}
|
|
|
|
TEST(CommonFileFunctions, CopyDirectory)
|
|
{
|
|
QTemporaryDir src;
|
|
QTemporaryDir dst;
|
|
ASSERT_TRUE(src.isValid());
|
|
ASSERT_TRUE(dst.isValid());
|
|
|
|
QString src_file = QDir(src.path()).filePath(QStringLiteral("file.txt"));
|
|
QFile f(src_file);
|
|
(void)f.open(QIODevice::WriteOnly);
|
|
f.write("copied");
|
|
f.close();
|
|
|
|
QString dst_dir = QDir(dst.path()).filePath(QStringLiteral("copied"));
|
|
olive::FileFunctions::copy_directory(src.path(), dst_dir, false);
|
|
|
|
QFile result(QDir(dst_dir).filePath(QStringLiteral("file.txt")));
|
|
EXPECT_TRUE(result.open(QIODevice::ReadOnly));
|
|
EXPECT_EQ(result.readAll(), QByteArray("copied"));
|
|
}
|
|
|
|
TEST(CommonFileFunctions, ReadFileAsString)
|
|
{
|
|
QTemporaryFile f;
|
|
ASSERT_TRUE(f.open());
|
|
f.write("hello world");
|
|
f.close();
|
|
|
|
EXPECT_EQ(olive::FileFunctions::read_file_as_string(f.fileName()),
|
|
QStringLiteral("hello world"));
|
|
EXPECT_TRUE(olive::FileFunctions::read_file_as_string(
|
|
QStringLiteral("/nonexistent/path"))
|
|
.isEmpty());
|
|
}
|
|
|
|
TEST(CommonFileFunctions, GetUniqueFileIdentifier)
|
|
{
|
|
QTemporaryFile f;
|
|
ASSERT_TRUE(f.open());
|
|
f.close();
|
|
|
|
QString id1 = olive::FileFunctions::get_unique_file_identifier(f.fileName());
|
|
QString id2 = olive::FileFunctions::get_unique_file_identifier(f.fileName());
|
|
EXPECT_FALSE(id1.isEmpty());
|
|
EXPECT_EQ(id1, id2);
|
|
|
|
EXPECT_TRUE(olive::FileFunctions::get_unique_file_identifier(
|
|
QStringLiteral("/nonexistent"))
|
|
.isEmpty());
|
|
}
|
|
|
|
TEST(CommonFileFunctions, GetConfigurationLocation)
|
|
{
|
|
QString loc = olive::FileFunctions::get_configuration_location();
|
|
EXPECT_FALSE(loc.isEmpty());
|
|
EXPECT_TRUE(QDir(loc).exists());
|
|
}
|
|
|
|
TEST(CommonFileFunctions, GetTempFilePath)
|
|
{
|
|
QString temp = olive::FileFunctions::get_temp_file_path();
|
|
EXPECT_FALSE(temp.isEmpty());
|
|
EXPECT_TRUE(QDir(temp).exists());
|
|
}
|
|
|
|
TEST(CommonFileFunctions, GetAutoRecoveryRoot)
|
|
{
|
|
QString root = olive::FileFunctions::get_auto_recovery_root();
|
|
EXPECT_FALSE(root.isEmpty());
|
|
}
|
|
|
|
TEST(CommonFileFunctions, DirectoryIsValidExisting)
|
|
{
|
|
QTemporaryDir dir;
|
|
ASSERT_TRUE(dir.isValid());
|
|
EXPECT_TRUE(
|
|
olive::FileFunctions::directory_is_valid(QDir(dir.path()), false));
|
|
}
|
|
|
|
TEST(CommonFileFunctions, CopyDirectoryWithOverwrite)
|
|
{
|
|
QTemporaryDir src;
|
|
QTemporaryDir dst;
|
|
ASSERT_TRUE(src.isValid());
|
|
ASSERT_TRUE(dst.isValid());
|
|
|
|
QString src_file = QDir(src.path()).filePath(QStringLiteral("file.txt"));
|
|
QFile f(src_file);
|
|
(void)f.open(QIODevice::WriteOnly);
|
|
f.write("new content");
|
|
f.close();
|
|
|
|
QString dst_file = QDir(dst.path()).filePath(QStringLiteral("file.txt"));
|
|
QFile g(dst_file);
|
|
(void)g.open(QIODevice::WriteOnly);
|
|
g.write("old content");
|
|
g.close();
|
|
|
|
olive::FileFunctions::copy_directory(src.path(), dst.path(), true);
|
|
|
|
QFile result(dst_file);
|
|
(void)result.open(QIODevice::ReadOnly);
|
|
EXPECT_EQ(result.readAll(), QByteArray("new content"));
|
|
}
|
|
|
|
TEST(CommonFileFunctions, CopyDirectorySourceMissing)
|
|
{
|
|
QTemporaryDir dst;
|
|
ASSERT_TRUE(dst.isValid());
|
|
|
|
// A missing source must log a critical error naming the source and
|
|
// leave the destination untouched
|
|
g_captured_messages.clear();
|
|
QtMessageHandler old = qInstallMessageHandler(capture_message_handler);
|
|
olive::FileFunctions::copy_directory(QStringLiteral("/nonexistent/path"),
|
|
dst.path(), false);
|
|
qInstallMessageHandler(old);
|
|
|
|
ASSERT_EQ(g_captured_messages.size(), 1);
|
|
EXPECT_TRUE(g_captured_messages.first().contains(
|
|
QStringLiteral("Failed to copy directory")));
|
|
EXPECT_TRUE(g_captured_messages.first().contains(
|
|
QStringLiteral("/nonexistent/path")));
|
|
EXPECT_TRUE(
|
|
QDir(dst.path()).entryList(QDir::NoDotAndDotDot).isEmpty());
|
|
}
|