implemented value node

Also implements changes necessary to support an input data type
that changes. Much of that foundation was built in
`nodearchchanges`, but hadn't been finalized. This commit
finalizes and provides a reference implementation/test with the
"Value" node.

Fixes #1443

app/widget/nodeparamview/nodeparamviewitem.cpp

@@ -36,6 +36,9 @@ const int NodeParamViewItemBody::kKeyControlColumn = 10;
 const int NodeParamViewItemBody::kArrayInsertColumn = kKeyControlColumn-1;
 const int NodeParamViewItemBody::kArrayRemoveColumn = kArrayInsertColumn-1;
 
+// 0 is for the array collapse button, 1 is for the main label, widgets start at 2
+const int NodeParamViewItemBody::kWidgetStartColumn = 2;
+
 #define super QDockWidget
 
 NodeParamViewItem::NodeParamViewItem(Node *node, QWidget *parent) :
@@ -261,6 +264,10 @@ void NodeParamViewItemBody::CreateWidgets(QGridLayout* layout, Node *node, const
 
   InputUI ui_objects;
 
+  // Store layout and row
+  ui_objects.layout = layout;
+  ui_objects.row = row;
+
   // Add descriptor label
   ui_objects.main_label = new QLabel();
 
@@ -303,23 +310,24 @@ void NodeParamViewItemBody::CreateWidgets(QGridLayout* layout, Node *node, const
 
   // Create a widget/input bridge for this input
   ui_objects.widget_bridge = new NodeParamViewWidgetBridge(NodeInput(node, input, element), this);
+  connect(ui_objects.widget_bridge, &NodeParamViewWidgetBridge::WidgetsRecreated, this, &NodeParamViewItemBody::ReplaceWidgets);
   connect(ui_objects.widget_bridge, &NodeParamViewWidgetBridge::ArrayWidgetDoubleClicked, this, &NodeParamViewItemBody::ToggleArrayExpanded);
 
-  // 0 is for the array collapse button, 1 is for the main label, widgets start at 2
-  const int widget_start = 2;
+  // Place widgets into layout
+  PlaceWidgetsFromBridge(layout, ui_objects.widget_bridge, row);
 
   // Add widgets for this parameter to the layout
   for (int i=0; i<ui_objects.widget_bridge->widgets().size(); i++) {
     QWidget* w = ui_objects.widget_bridge->widgets().at(i);
 
-    layout->addWidget(w, row, i+widget_start);
+    layout->addWidget(w, row, i+kWidgetStartColumn);
   }
 
   if (node->IsInputConnectable(input)) {
     // Create clickable label used when an input is connected
     ui_objects.connected_label = new NodeParamViewConnectedLabel(input_ref);
     connect(ui_objects.connected_label, &NodeParamViewConnectedLabel::RequestSelectNode, this, &NodeParamViewItemBody::RequestSelectNode);
-    layout->addWidget(ui_objects.connected_label, row, widget_start);
+    layout->addWidget(ui_objects.connected_label, row, kWidgetStartColumn);
   }
 
   // Add keyframe control to this layout if parameter is keyframable
@@ -418,6 +426,16 @@ void NodeParamViewItemBody::UpdateUIForEdgeConnection(const NodeInput& input)
   }
 }
 
+void NodeParamViewItemBody::PlaceWidgetsFromBridge(QGridLayout* layout, NodeParamViewWidgetBridge *bridge, int row)
+{
+  // Add widgets for this parameter to the layout
+  for (int i=0; i<bridge->widgets().size(); i++) {
+    QWidget* w = bridge->widgets().at(i);
+
+    layout->addWidget(w, row, i+kWidgetStartColumn);
+  }
+}
+
 void NodeParamViewItemBody::ArrayCollapseBtnPressed(bool checked)
 {
   const NodeInputPair& input = array_collapse_buttons_.key(static_cast<CollapseButton*>(sender()));
@@ -514,6 +532,12 @@ void NodeParamViewItemBody::ToggleArrayExpanded()
   }
 }
 
+void NodeParamViewItemBody::ReplaceWidgets(const NodeInput &input)
+{
+  InputUI ui = input_ui_map_.value(input);
+  PlaceWidgetsFromBridge(ui.layout, ui.widget_bridge, ui.row);
+}
+
 NodeParamViewItemBody::InputUI::InputUI() :
   main_label(nullptr),
   widget_bridge(nullptr),

app/widget/nodeparamview/nodeparamviewitem.h

@@ -97,6 +97,8 @@ private:
 
   void UpdateUIForEdgeConnection(const NodeInput &input);
 
+  void PlaceWidgetsFromBridge(QGridLayout *layout, NodeParamViewWidgetBridge* bridge, int row);
+
   struct InputUI {
     InputUI();
 
@@ -104,6 +106,8 @@ private:
     NodeParamViewWidgetBridge* widget_bridge;
     NodeParamViewConnectedLabel* connected_label;
     NodeParamViewKeyframeControl* key_control;
+    QGridLayout* layout;
+    int row;
 
     NodeParamViewArrayButton* array_insert_btn;
     NodeParamViewArrayButton* array_remove_btn;
@@ -132,6 +136,8 @@ private:
   static const int kArrayInsertColumn;
   static const int kArrayRemoveColumn;
 
+  static const int kWidgetStartColumn;
+
 private slots:
   void EdgeChanged(const NodeOutput &output, const NodeInput &input);
 
@@ -147,6 +153,8 @@ private slots:
 
   void ToggleArrayExpanded();
 
+  void ReplaceWidgets(const NodeInput& input);
+
 };
 
 class NodeParamViewItem : public QDockWidget

app/widget/nodeparamview/nodeparamviewwidgetbridge.cpp

@@ -49,6 +49,7 @@ NodeParamViewWidgetBridge::NodeParamViewWidgetBridge(const NodeInput &input, QOb
 
   connect(input_.node(), &Node::ValueChanged, this, &NodeParamViewWidgetBridge::InputValueChanged);
   connect(input_.node(), &Node::InputPropertyChanged, this, &NodeParamViewWidgetBridge::PropertyChanged);
+  connect(input_.node(), &Node::InputDataTypeChanged, this, &NodeParamViewWidgetBridge::InputDataTypeChanged);
 }
 
 void NodeParamViewWidgetBridge::SetTime(const rational &time)
@@ -756,6 +757,22 @@ void NodeParamViewWidgetBridge::PropertyChanged(const QString& input, const QStr
   }
 }
 
+void NodeParamViewWidgetBridge::InputDataTypeChanged(const QString &input, NodeValue::Type type)
+{
+  Q_UNUSED(type)
+  if (input == this->input_.input()) {
+    // Delete all widgets
+    qDeleteAll(widgets_);
+    widgets_.clear();
+
+    // Create new widgets
+    CreateWidgets();
+
+    // Signal that widgets are new
+    emit WidgetsRecreated(input_);
+  }
+}
+
 bool NodeParamViewScrollBlocker::eventFilter(QObject *watched, QEvent *event)
 {
   Q_UNUSED(watched)

app/widget/nodeparamview/nodeparamviewwidgetbridge.h

@@ -52,6 +52,8 @@ public:
 signals:
   void ArrayWidgetDoubleClicked();
 
+  void WidgetsRecreated(const NodeInput& input);
+
 private:
   void CreateWidgets();
 
@@ -85,6 +87,8 @@ private slots:
 
   void PropertyChanged(const QString &input, const QString& key, const QVariant& value);
 
+  void InputDataTypeChanged(const QString& input, NodeValue::Type type);
+
 };
 
 }