Closes https://github.com/zed-industries/zed/issues/38690 Closes #37353 ### Background On Windows, paths are normally separated by `\`, unlike mac and linux where they are separated by `/`. When editing code in a project that uses a different path style than your local system (e.g. remoting from Windows to Linux, using WSL, and collaboration between windows and unix users), the correct separator for a path may differ from the "native" separator. Previously, to work around this, Zed converted paths' separators in numerous places. This was applied to both absolute and relative paths, leading to incorrect conversions in some cases. ### Solution Many code paths in Zed use paths that are *relative* to either a worktree root or a git repository. This PR introduces a dedicated type for these paths called `RelPath`, which stores the path in the same way regardless of host platform, and offers `Path`-like manipulation APIs. RelPath supports *displaying* the path using either separator, so that we can display paths in a style that is determined at runtime based on the current project. The representation of absolute paths is left untouched, for now. Absolute paths are different from relative paths because (except in contexts where we know that the path refers to the local filesystem) they should generally be treated as opaque strings. Currently we use a mix of types for these paths (std::path::Path, String, SanitizedPath). Release Notes: - N/A --------- Co-authored-by: Cole Miller <cole@zed.dev> Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com> Co-authored-by: Peter Tripp <petertripp@gmail.com> Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com> Co-authored-by: Lukas Wirth <me@lukaswirth.dev>
160 lines
5.3 KiB
Rust
160 lines
5.3 KiB
Rust
use anyhow::{Context as _, Result, anyhow};
|
|
use assistant_slash_command::{
|
|
ArgumentCompletion, SlashCommand, SlashCommandOutput, SlashCommandOutputSection,
|
|
SlashCommandResult,
|
|
};
|
|
use fs::Fs;
|
|
use gpui::{App, Entity, Task, WeakEntity};
|
|
use language::{BufferSnapshot, LspAdapterDelegate};
|
|
use project::{Project, ProjectPath};
|
|
use std::{
|
|
fmt::Write,
|
|
path::Path,
|
|
sync::{Arc, atomic::AtomicBool},
|
|
};
|
|
use ui::prelude::*;
|
|
use util::rel_path::RelPath;
|
|
use workspace::Workspace;
|
|
|
|
pub struct CargoWorkspaceSlashCommand;
|
|
|
|
impl CargoWorkspaceSlashCommand {
|
|
async fn build_message(fs: Arc<dyn Fs>, path_to_cargo_toml: &Path) -> Result<String> {
|
|
let buffer = fs.load(path_to_cargo_toml).await?;
|
|
let cargo_toml: cargo_toml::Manifest = toml::from_str(&buffer)?;
|
|
|
|
let mut message = String::new();
|
|
writeln!(message, "You are in a Rust project.")?;
|
|
|
|
if let Some(workspace) = cargo_toml.workspace {
|
|
writeln!(
|
|
message,
|
|
"The project is a Cargo workspace with the following members:"
|
|
)?;
|
|
for member in workspace.members {
|
|
writeln!(message, "- {member}")?;
|
|
}
|
|
|
|
if !workspace.default_members.is_empty() {
|
|
writeln!(message, "The default members are:")?;
|
|
for member in workspace.default_members {
|
|
writeln!(message, "- {member}")?;
|
|
}
|
|
}
|
|
|
|
if !workspace.dependencies.is_empty() {
|
|
writeln!(
|
|
message,
|
|
"The following workspace dependencies are installed:"
|
|
)?;
|
|
for dependency in workspace.dependencies.keys() {
|
|
writeln!(message, "- {dependency}")?;
|
|
}
|
|
}
|
|
} else if let Some(package) = cargo_toml.package {
|
|
writeln!(
|
|
message,
|
|
"The project name is \"{name}\".",
|
|
name = package.name
|
|
)?;
|
|
|
|
let description = package
|
|
.description
|
|
.as_ref()
|
|
.and_then(|description| description.get().ok().cloned());
|
|
if let Some(description) = description.as_ref() {
|
|
writeln!(message, "It describes itself as \"{description}\".")?;
|
|
}
|
|
|
|
if !cargo_toml.dependencies.is_empty() {
|
|
writeln!(message, "The following dependencies are installed:")?;
|
|
for dependency in cargo_toml.dependencies.keys() {
|
|
writeln!(message, "- {dependency}")?;
|
|
}
|
|
}
|
|
}
|
|
|
|
Ok(message)
|
|
}
|
|
|
|
fn path_to_cargo_toml(project: Entity<Project>, cx: &mut App) -> Option<Arc<Path>> {
|
|
let worktree = project.read(cx).worktrees(cx).next()?;
|
|
let worktree = worktree.read(cx);
|
|
let entry = worktree.entry_for_path(RelPath::new("Cargo.toml").unwrap())?;
|
|
let path = ProjectPath {
|
|
worktree_id: worktree.id(),
|
|
path: entry.path.clone(),
|
|
};
|
|
Some(Arc::from(
|
|
project.read(cx).absolute_path(&path, cx)?.as_path(),
|
|
))
|
|
}
|
|
}
|
|
|
|
impl SlashCommand for CargoWorkspaceSlashCommand {
|
|
fn name(&self) -> String {
|
|
"cargo-workspace".into()
|
|
}
|
|
|
|
fn description(&self) -> String {
|
|
"insert project workspace metadata".into()
|
|
}
|
|
|
|
fn menu_text(&self) -> String {
|
|
"Insert Project Workspace Metadata".into()
|
|
}
|
|
|
|
fn complete_argument(
|
|
self: Arc<Self>,
|
|
_arguments: &[String],
|
|
_cancel: Arc<AtomicBool>,
|
|
_workspace: Option<WeakEntity<Workspace>>,
|
|
_window: &mut Window,
|
|
_cx: &mut App,
|
|
) -> Task<Result<Vec<ArgumentCompletion>>> {
|
|
Task::ready(Err(anyhow!("this command does not require argument")))
|
|
}
|
|
|
|
fn requires_argument(&self) -> bool {
|
|
false
|
|
}
|
|
|
|
fn run(
|
|
self: Arc<Self>,
|
|
_arguments: &[String],
|
|
_context_slash_command_output_sections: &[SlashCommandOutputSection<language::Anchor>],
|
|
_context_buffer: BufferSnapshot,
|
|
workspace: WeakEntity<Workspace>,
|
|
_delegate: Option<Arc<dyn LspAdapterDelegate>>,
|
|
_window: &mut Window,
|
|
cx: &mut App,
|
|
) -> Task<SlashCommandResult> {
|
|
let output = workspace.update(cx, |workspace, cx| {
|
|
let project = workspace.project().clone();
|
|
let fs = workspace.project().read(cx).fs().clone();
|
|
let path = Self::path_to_cargo_toml(project, cx);
|
|
let output = cx.background_spawn(async move {
|
|
let path = path.with_context(|| "Cargo.toml not found")?;
|
|
Self::build_message(fs, &path).await
|
|
});
|
|
|
|
cx.foreground_executor().spawn(async move {
|
|
let text = output.await?;
|
|
let range = 0..text.len();
|
|
Ok(SlashCommandOutput {
|
|
text,
|
|
sections: vec![SlashCommandOutputSection {
|
|
range,
|
|
icon: IconName::FileTree,
|
|
label: "Project".into(),
|
|
metadata: None,
|
|
}],
|
|
run_commands_in_text: false,
|
|
}
|
|
.into_event_stream())
|
|
})
|
|
});
|
|
output.unwrap_or_else(|error| Task::ready(Err(error)))
|
|
}
|
|
}
|