Kirill Bulatov
16366cf9f2
https://github.com/zed-industries/zed/issues/30972 brought up another case where our context is not enough to track the actual source of the issue: we get a general top-level error without inner error. The reason for this was `.ok_or_else(|| anyhow!("failed to read HEAD SHA"))?; ` on the top level. The PR finally reworks the way we use anyhow to reduce such issues (or at least make it simpler to bubble them up later in a fix). On top of that, uses a few more anyhow methods for better readability. * `.ok_or_else(|| anyhow!("..."))`, `map_err` and other similar error conversion/option reporting cases are replaced with `context` and `with_context` calls * in addition to that, various `anyhow!("failed to do ...")` are stripped with `.context("Doing ...")` messages instead to remove the parasitic `failed to` text * `anyhow::ensure!` is used instead of `if ... { return Err(...); }` calls * `anyhow::bail!` is used instead of `return Err(anyhow!(...));` Release Notes: - N/A
46 lines
1.2 KiB
Rust
46 lines
1.2 KiB
Rust
use std::path::{Path, PathBuf};
|
|
|
|
use anyhow::{Context as _, Result};
|
|
use clap::Parser;
|
|
|
|
use crate::workspace::load_workspace;
|
|
|
|
#[derive(Parser)]
|
|
pub struct LicensesArgs {}
|
|
|
|
pub fn run_licenses(_args: LicensesArgs) -> Result<()> {
|
|
const LICENSE_FILES: &[&str] = &["LICENSE-APACHE", "LICENSE-GPL", "LICENSE-AGPL"];
|
|
|
|
let workspace = load_workspace()?;
|
|
|
|
for package in workspace.workspace_packages() {
|
|
let crate_dir = package
|
|
.manifest_path
|
|
.parent()
|
|
.with_context(|| format!("no crate directory for {}", package.name))?;
|
|
|
|
if let Some(license_file) = first_license_file(crate_dir, LICENSE_FILES) {
|
|
if !license_file.is_symlink() {
|
|
println!("{} is not a symlink", license_file.display());
|
|
}
|
|
|
|
continue;
|
|
}
|
|
|
|
println!("Missing license: {}", package.name);
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn first_license_file(path: impl AsRef<Path>, license_files: &[&str]) -> Option<PathBuf> {
|
|
for license_file in license_files {
|
|
let path_to_license = path.as_ref().join(license_file);
|
|
if path_to_license.exists() {
|
|
return Some(path_to_license);
|
|
}
|
|
}
|
|
|
|
None
|
|
}
|