Finn Evers f6d4a73c34
terminal: Prevent [] from being sanitized into clickable file link ( #20386 ) ...
This PR prevents `[]` from being sanitized into an empty string and thus
becoming a "valid", clickable file link in the integrated terminal.
Whenever you type `[]` into the terminal and hover over it while
pressing `cmd`, an empty popup appears and the cursor indicates that
this is a clickable element. Once you click on the brackets, the
worktree root is selected and focused within the file picker.
<img width="87" alt="grafik"
src="https://github.com/user-attachments/assets/01790323-88be-4373-a1ec-a345bcf2521e ">
This is because in #2906 support was added for sanititzing file links
like `[/some/path/[slug].tsx]` to `/some/path/[slug].tsx`. In the case
`[]` where an empty string is returned from the sanitation, the string
is considered a valid file path and thus `[]` becomes a valid and
clickable navigation target.
Given that this an edge-case just for this specific one set of brackets
and otherwise no empty strings are matched from the regexes `URL_REGEX`
and `WORD_REGEX`, it seemed that this was the best place to fix this
bug.
Release Notes:
- `[]` is no longer considered a clickable link in the terminal
2024-11-08 02:41:30 +02:00
2024-11-01 12:53:02 -04:00
2024-10-23 15:13:52 -04:00
2024-09-13 17:44:16 -04:00
2024-11-07 18:23:25 -05:00
2024-11-06 16:24:43 -08:00
2024-09-04 14:32:20 -04:00
2024-09-16 21:55:32 -06:00
2024-11-05 13:37:54 -07:00
2024-09-27 11:06:48 +02:00
2024-11-01 13:20:30 -04:00
2024-10-27 19:44:21 -07:00
2024-10-24 12:14:03 -06:00
2024-11-05 14:05:51 -07:00
2024-10-07 16:28:33 -07:00
2024-11-07 18:23:25 -05:00
2024-10-28 12:55:55 -07:00
2024-09-06 11:58:39 +02:00
2024-09-06 11:58:39 +02:00
2024-11-07 18:23:25 -05:00
2024-11-07 16:03:12 -05:00
2024-10-07 01:29:58 +02:00
2024-10-24 12:14:03 -06:00
2024-11-04 12:16:02 -07:00
2024-08-26 11:43:13 -04:00
2024-11-08 01:19:54 +02:00
2024-10-11 14:58:58 -07:00
2024-11-06 10:06:25 -07:00
2024-11-04 11:02:19 -05:00
2024-11-01 13:20:30 -04:00
2024-11-06 10:06:25 -07:00
2024-11-06 10:06:25 -07:00
2024-10-29 11:30:07 -07:00
2024-11-05 12:07:17 -05:00
2024-10-28 17:21:41 -07:00
2024-07-29 14:21:41 +02:00
2024-11-06 20:36:59 -07:00
2024-08-13 23:06:07 -07:00
2024-11-06 09:43:39 +01:00
2024-10-30 11:16:44 -04:00
2024-11-05 03:49:37 +02:00
2024-11-04 17:01:08 -05:00
2024-11-07 09:45:23 -07:00
2024-09-13 17:44:16 -04:00
2024-09-06 11:58:39 +02:00
2024-10-15 23:32:44 -07:00
2024-11-04 10:18:21 +01:00
2024-11-06 10:06:25 -07:00
2024-10-21 13:05:30 +03:00
2024-09-06 11:58:39 +02:00
2024-11-06 10:06:25 -07:00
2024-11-04 10:55:20 +01:00
2024-09-10 15:51:01 -04:00
2024-11-07 14:36:29 +02:00
2024-11-07 12:44:34 -08:00
2024-09-06 11:58:39 +02:00
2024-10-11 14:58:58 -07:00
2024-10-26 03:32:22 +03:00
2024-11-01 13:28:34 -06:00
2024-11-04 17:23:32 +01:00
2024-08-28 22:12:49 -07:00
2024-07-15 17:04:15 -06:00
2024-11-07 09:17:43 -07:00
2024-11-04 16:00:51 -05:00
2024-09-29 10:30:48 -06:00
2024-09-27 00:36:17 -06:00
2024-09-26 14:01:05 -06:00
2024-11-04 11:54:37 -05:00
2024-11-08 01:19:54 +02:00
2024-11-06 10:06:25 -07:00
2024-11-07 14:36:29 +02:00
2024-10-30 14:49:47 +02:00
2024-11-07 11:40:33 -05:00
2024-11-07 20:03:55 +01:00
2024-09-16 16:20:17 -06:00
2024-11-06 16:24:43 -08:00
2024-09-27 11:06:48 +02:00
2024-11-05 22:16:38 -07:00
2024-09-06 11:58:39 +02:00
2024-11-06 10:06:25 -07:00
2024-11-06 20:36:59 -07:00
2024-10-31 07:01:46 -07:00
2024-10-18 09:57:00 -07:00
2024-09-10 11:16:27 -04:00
2024-11-06 13:18:30 +01:00
2024-10-27 15:50:54 -07:00
2024-11-07 10:56:10 -03:00
2024-10-23 12:34:51 -04:00
2024-10-07 01:29:58 +02:00
2024-11-04 14:25:44 -05:00
2024-11-01 15:34:20 -04:00
2024-07-22 00:57:34 +02:00
2024-10-07 01:29:58 +02:00
2024-10-02 13:27:16 +02:00
2024-10-29 12:30:55 -07:00
2024-10-05 12:58:45 +03:00
2024-09-06 11:58:39 +02:00
2024-11-01 15:34:20 -04:00
2024-10-30 10:59:03 +01:00
2024-10-23 10:36:14 +03:00
2024-09-06 11:58:39 +02:00
2024-10-04 10:37:41 -04:00
2024-10-31 14:25:57 +01:00
2024-10-28 17:21:41 -07:00
2024-10-31 16:21:26 -07:00
2024-11-08 02:41:30 +02:00
2024-11-04 09:19:48 +01:00
2024-11-07 09:17:43 -07:00
2024-11-01 15:34:20 -04:00
2024-09-07 02:36:55 +02:00
2024-11-01 15:34:20 -04:00
2024-09-06 11:58:39 +02:00
2024-10-29 12:13:21 +01:00
2024-10-28 15:34:03 +01:00
2024-11-07 10:56:10 -03:00
2024-07-08 17:05:30 -04:00
2024-09-13 16:45:16 -04:00
2024-10-27 15:50:54 -07:00
2024-11-04 12:17:11 +02:00
2024-11-07 11:20:19 +02:00
2024-11-07 15:22:53 -05:00
2024-11-07 11:20:19 +02:00
2024-11-06 20:36:59 -07:00
2024-11-06 10:06:25 -07:00
2024-10-30 11:26:54 -06:00
Finn Evers
f6d4a73c34