oak-gpui/crates/eval/examples/standardized_docker_dependency_checks/diff_criteria.md at f0ef3110d3f54c0cbe4ee3d920cdaecd81efde78

oak-team/oak-gpui

Fork 0

Files

T

bab28560ef Systematically optimize agentic editing performance (#28961 )

Now that we've established a proper eval in tree, this PR is reboots of
our agent loop back to a set of minimal tools and simpler prompts. We
should aim to get this branch feeling subjectively competitive with
what's on main and then merge it, and build from there.

Let's invest in our eval and use it to drive better performance of the
agent loop. How you can help: Pick an example, and then make the outcome
faster or better. It's fine to even use your own subjective judgment, as
our evaluation criteria likely need tuning as well at this point. Focus
on making the agent work better in your own subjective experience first.
Let's focus on simple/practical improvements to make this thing work
better, then determine how we can craft our judgment criteria to lock
those improvements in.

Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>
Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Agus <agus@zed.dev>
Co-authored-by: Richard <richard@zed.dev>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Michael Sloan <mgsloan@gmail.com>

2025-04-19 02:47:59 +00:00

1.6 KiB

Raw Blame History

The changes introduce a new DependencyError class in kamal/cli.rb alongside other error classes like BootError and HookError. This new error class will be used to handle dependency-related failures.
In kamal/cli/base.rb, a new method ensure_docker_installed is added which checks for Docker and buildx plugin installation locally. It raises the new DependencyError with appropriate messages if either Docker or buildx plugin are not found, replacing similar functionality that was previously scattered elsewhere.
The kamal/cli/build.rb file is modified to use the new ensure_docker_installed method instead of the removed verify_local_dependencies method. The error handling is now consistent, using DependencyError instead of BuildError for dependency-related failures.
The kamal/cli/registry.rb file now includes a call to ensure_docker_installed at the start of the login method, ensuring Docker is available before attempting registry operations.
The kamal/commands/base.rb file adds a new public method ensure_docker_installed that combines checks for both Docker and buildx plugin installation, moving this functionality from the Builder class.
The kamal/commands/builder.rb file is simplified by removing the ensure_local_dependencies_installed method and related private methods, as this functionality has been moved to the base commands class.
Test files are updated to reflect these changes, with build_test.rb now expecting DependencyError instead of BuildError for dependency failures, and registry_test.rb adding a new test case for Docker dependency checking during login.

1.6 KiB Raw Blame History

1.6 KiB

Raw Blame History