3 people 5ae93ce68d Add initial inline diagnostics support (#25297) ...

https://github.com/user-attachments/assets/eb881707-e575-47ef-9ae0-67d8085d8065

Closes https://github.com/zed-industries/zed/pull/22668
Closes https://github.com/zed-industries/zed/issues/4901

Takes https://github.com/zed-industries/zed/pull/22668 and fixes all
review items on top.
Inline diagnostics are disabled by default, but can be enabled via
settings permanently, or temporarily toggled with the `editor:
ToggleInlineDiagnostics` action and the corresponding editor menu item
<img width="242" alt="image"
src="https://github.com/user-attachments/assets/8e177511-4626-4434-902b-d6aa4d3fafd0"
/>

Inline diagnostics does not show currently active diagnostics group, as
it gets inline into the editor too, inside the text.
Inline git blame takes precedence and is shown instead of the
diagnostics, edit predictions dim the diagnostics if located on the same
line.

One notable drawback of the implementation is the inability to wrap,
making inline diagnostics cut off the right side:


![image](https://github.com/user-attachments/assets/6e87268a-b51a-4a2b-8b8d-01d932c62fea)

(same as inline git blame and other elements to the right of the text)
Given that it's disabled by default and go to next/prev diagnostics will
show them better, seems fine to leave in the first iteration.


Release Notes:

- Added initial inline diagnostics support

---------

Co-authored-by: Paul J. Davis <paul.davis@tiledb.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>

2025-02-20 23:39:47 +00:00

..

display_map

assistant2: Highlight crease on selection (#24358)

2025-02-20 13:25:08 -03:00

git

Remove language::markdown (#25136)

2025-02-19 08:55:36 -07:00

scroll

Rework edit prediction preview mode (#24700)

2025-02-11 23:14:12 +00:00

test

Color staged and unstaged hunks differently by opacity (#25108)

2025-02-19 18:33:21 +00:00

actions.rs

Add initial inline diagnostics support (#25297)

2025-02-20 23:39:47 +00:00

blink_manager.rs

Eliminate GPUI View, ViewContext, and WindowContext types (#22632)

2025-01-26 03:02:45 +00:00

clangd_ext.rs

Eliminate GPUI View, ViewContext, and WindowContext types (#22632)

2025-01-26 03:02:45 +00:00

code_context_menus.rs

Remove language::markdown (#25136)

2025-02-19 08:55:36 -07:00

commit_tooltip.rs

Remove language::markdown (#25136)

2025-02-19 08:55:36 -07:00

display_map.rs

Revert "file_finder: Remove common segments of long paths in search results (#25049)" (#25163)

2025-02-19 15:32:29 +00:00

editor_settings_controls.rs

Eliminate GPUI View, ViewContext, and WindowContext types (#22632)

2025-01-26 03:02:45 +00:00

editor_settings.rs

Hide the mouse when the user is typing in the editor (#25040)

2025-02-20 15:54:01 -03:00

editor_tests.rs

html: Open extra newline between opening and closing HTML tags (#25130)

2025-02-20 01:09:19 -05:00

editor.rs

Add initial inline diagnostics support (#25297)

2025-02-20 23:39:47 +00:00

element.rs

Add initial inline diagnostics support (#25297)

2025-02-20 23:39:47 +00:00

git.rs

Project Diff 2 (#23891)

2025-02-03 13:18:50 -07:00

highlight_matching_bracket.rs

Eliminate GPUI View, ViewContext, and WindowContext types (#22632)

2025-01-26 03:02:45 +00:00

hover_links.rs

windows: Fix tests on Windows (#22616)

2025-02-05 14:30:09 +00:00

hover_popover.rs

Remove language::markdown (#25136)

2025-02-19 08:55:36 -07:00

indent_guides.rs

cx.background_executor().spawn(...) -> cx.background_spawn(...) (#25103)

2025-02-18 20:30:33 +00:00

inlay_hint_cache.rs

cx.background_executor().spawn(...) -> cx.background_spawn(...) (#25103)

2025-02-18 20:30:33 +00:00

inline_completion_tests.rs

Require alt-tab for AcceptEditPrediction when tab inserting whitespace is desired (#24705)

2025-02-12 01:14:09 +00:00

items.rs

cx.background_executor().spawn(...) -> cx.background_spawn(...) (#25103)

2025-02-18 20:30:33 +00:00

linked_editing_ranges.rs

Eliminate GPUI View, ViewContext, and WindowContext types (#22632)

2025-01-26 03:02:45 +00:00

lsp_ext.rs

project: Fine-grained language server management (#24038)

2025-02-14 15:41:49 +01:00

mouse_context_menu.rs

editor: Disable "Open in Terminal" when it's not possible (#25059)

2025-02-18 04:07:04 -03:00

movement.rs

Persist selections for editors (#25083)

2025-02-18 14:27:00 +00:00

persistence.rs

Do not fail hard on selection persistence if the editor is removed (#25120)

2025-02-18 22:52:23 +00:00

proposed_changes_editor.rs

Display case-sensitive keybindings for vim commands (#24322)

2025-02-14 22:03:59 -07:00

rust_analyzer_ext.rs

Eliminate GPUI View, ViewContext, and WindowContext types (#22632)

2025-01-26 03:02:45 +00:00

scroll.rs

Revert "file_finder: Remove common segments of long paths in search results (#25049)" (#25163)

2025-02-19 15:32:29 +00:00

selections_collection.rs

Eliminate GPUI View, ViewContext, and WindowContext types (#22632)

2025-01-26 03:02:45 +00:00

signature_help.rs

Remove language::markdown (#25136)

2025-02-19 08:55:36 -07:00

tasks.rs

cx.background_executor().spawn(...) -> cx.background_spawn(...) (#25103)

2025-02-18 20:30:33 +00:00

test.rs

windows: Fix tests on Windows (#22616)

2025-02-05 14:30:09 +00:00