Files
oak-gpui/crates
Piotr Osiewicz 6da57cbc6e Decouple workspace from call (#3380)
This PR decouples `call2` from `workspace2` in order to improve our
compile times.
Why pick such a small, innocent crate as `call`? It depends on
`live_kit_client`, which is not-so-innocent and is in fact stalling our
clean builds.
In this PR, `call2` depends on `workspace2`; workspace crate defines a
`CallHandler` trait for which the implementation resides in `call`; it
it then all tied together in `zed`, which passes a factory of `Box<dyn
CallHandler>` into workspace's `AppState`.
Clean debug build before this change: ~1m45s
Clean debug build after this change: ~1m25s

Clean release build before this change: ~6m30s
Clean release build after this change: ~4m30s

~Gonna follow up with release timings where I expect the change to be
more impactful (as this allows 2/3 of the infamous trio of
"project-workspace-editor" long pole to proceed quicker, without being
blocked on live-kit-client build script)~.
This should have little effect (if any) in incremental scenarios, where
live_kit_client is already built.
[release
timings.zip](https://github.com/zed-industries/zed/files/13431121/release.timings.zip)

Release Notes:
- N/A
2023-11-22 22:31:47 +01:00
..
2023-11-14 08:28:57 -05:00
2023-11-14 08:28:57 -05:00
2023-11-02 10:55:02 -07:00
2023-11-17 12:54:16 -08:00
WIP
2023-11-20 14:46:01 -08:00
2023-11-19 22:00:01 -05:00
2023-11-19 22:00:01 -05:00
2023-11-22 13:05:29 -05:00
2023-11-22 19:23:58 +01:00
2023-11-21 01:05:29 -05:00
WIP
2023-11-20 14:46:01 -08:00
WIP
2023-11-13 15:53:04 -08:00
2023-11-02 10:55:02 -07:00
2023-11-21 01:05:29 -05:00
WIP
2023-11-20 14:46:01 -08:00
2023-10-12 16:17:41 +03:00
2023-11-03 12:15:23 -04:00
2023-11-02 10:55:02 -07:00
2023-11-02 19:18:01 -06:00
2023-11-21 01:05:29 -05:00
2023-11-14 00:06:33 -08:00
2023-11-20 11:55:27 -08:00
2023-11-14 00:06:33 -08:00
2023-11-18 10:46:35 -08:00
2023-11-02 10:55:02 -07:00
2023-11-09 13:14:11 -07:00
2023-11-08 21:23:31 -08:00
2023-11-21 01:05:29 -05:00
WIP
2023-11-20 14:46:01 -08:00
2023-11-17 21:40:57 +02:00
2023-11-21 00:47:47 +01:00
2023-11-17 13:23:12 -07:00
WIP
2023-11-16 10:40:02 +02:00
2023-11-21 14:28:00 -05:00
2023-11-16 10:04:18 +02:00
2023-11-03 14:53:08 +01:00
2023-11-03 12:15:23 -04:00
2023-11-22 12:44:51 -05:00
wip
2023-11-01 13:53:45 -06:00
2023-10-23 11:06:58 +02:00
2023-10-25 15:53:34 +02:00
2023-11-22 12:57:32 -05:00
2023-11-22 22:31:47 +01:00
2023-10-28 11:37:25 -04:00