Files
oak-gpui/crates
e9b4f59e0f Fix external agent authentication with spaces in paths (#38175)
This fixes terminal-based authentication for external ACP agents (Claude
Code, Gemini CLI) when file paths contain spaces, like "Application
Support" on macOS and "Program Files" on Windows.

When users click authentication buttons or type `/login`, they get
errors like `Cannot find module '/Users/username/Library/Application'`
because the path gets split at the space.

The fix removes redundant `shlex::try_quote` calls from
`spawn_external_agent_login`. These were causing double-quoting since
the terminal spawning code already handles proper shell escaping.

Added a test to verify paths with spaces aren't pre-quoted.

Release Notes:

- Fixed external agent authentication failures when file paths contain
spaces

---------

Co-authored-by: Hakan Ensari <hakanensari@users.noreply.github.com>
Co-authored-by: Claude <claude@anthropic.com>
2025-09-15 10:20:27 +00:00
..
2025-09-12 18:07:59 +02:00
2025-09-08 21:53:17 -06:00
2025-09-03 22:10:14 +00:00
2025-09-12 14:45:38 -04:00
2025-09-12 14:45:38 -04:00
2025-09-08 21:53:17 -06:00
2025-09-10 16:13:41 -04:00
2025-09-08 21:53:17 -06:00