张小白 and Piotr Osiewicz
14fc726cae
windows: Fix ssh reporting wrong password even it's actually correct ( #38263 )
...
Closes #34393
Currently, we’re using `zed.exe --askpass` kind of like an `nc`
substitute, it prints out the SSH password to stdout with something like
`println!("user-pwd")`. `ssh.exe` then reads the password from stdout so
it can establish the connection.
The problem is that in release builds we set `subsystem=windows` to
avoid Windows spawning a black console window by default. The side
effect is that `zed.exe` no longer has a stdout, so `ssh.exe` can’t read
the password.
Through testing, I confirmed that neither allocating a new console for
`zed.exe` nor attaching it to the parent process’s stdout resolves the
issue. As a result, this PR updates the implementation to use `cli.exe
--askpass` instead.
TODO:
- [ ] Check that the `cli` path is correct on macOS
- [ ] Check that the `cli` path is correct on Linux
Release Notes:
- N/A
---------
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com >
2025-09-30 21:03:06 +08:00
..
2025-09-29 22:15:00 +00:00
2025-08-25 16:04:44 -06:00
2025-09-24 18:57:33 -04:00
2025-09-16 08:07:02 +00:00
2025-09-27 14:50:10 +00:00
2025-09-27 14:50:10 +00:00
2025-09-29 11:34:52 +00:00
2025-09-19 17:05:39 +02:00
2025-09-30 06:55:09 +00:00
2025-09-25 02:11:48 +00:00
2025-09-29 18:56:03 +00:00
2025-09-30 21:03:06 +08:00
2025-08-13 13:25:52 -06:00
2025-09-25 14:41:49 +02:00
2025-09-27 14:50:10 +00:00
2025-09-30 11:41:49 +00:00
2025-09-25 22:24:32 +00:00
2025-09-29 22:15:00 +00:00
2025-09-29 16:50:17 +00:00
2025-09-26 15:17:36 +00:00
2025-09-30 21:02:46 +08:00
2025-09-14 14:01:04 +02:00
2025-07-22 11:55:24 -04:00
2025-09-29 18:56:03 +00:00
2025-08-27 23:24:19 +00:00
2025-09-24 14:35:38 +02:00
2025-09-27 09:20:55 -04:00
2025-09-08 21:53:17 -06:00
2025-09-30 21:03:06 +08:00
2025-09-25 14:42:32 -07:00
2025-09-19 01:39:26 +02:00
2025-09-10 20:11:07 +00:00
2025-09-29 15:48:58 +00:00
2025-09-26 07:57:28 +00:00
2025-09-30 11:04:34 +02:00
2025-09-30 06:55:09 +00:00
2025-09-26 15:17:36 +00:00
2025-09-22 14:36:10 -07:00
2025-09-05 14:22:32 +02:00
2025-09-08 12:23:33 +03:00
2025-09-27 14:50:10 +00:00
2025-09-29 15:48:58 +00:00
2025-09-29 09:03:00 -07:00
2025-08-19 21:26:17 +02:00
2025-09-27 14:50:10 +00:00
2025-09-27 14:50:10 +00:00
2025-09-03 22:10:14 +00:00
2025-09-27 14:50:10 +00:00
2025-08-20 12:20:13 +02:00
2025-09-29 19:18:57 +00:00
2025-09-04 05:51:48 +00:00
2025-09-25 15:11:12 +02:00
2025-09-30 11:41:49 +00:00
2025-09-29 10:11:48 -04:00
2025-09-29 15:48:58 +00:00
2025-09-26 12:42:06 -06:00
2025-09-30 08:06:31 +00:00
2025-09-30 11:41:49 +00:00
2025-09-27 14:50:10 +00:00
2025-09-27 14:50:10 +00:00
2025-09-26 11:41:26 -04:00
2025-09-11 13:56:06 -07:00
2025-09-26 15:17:36 +00:00
2025-09-27 14:50:10 +00:00
2025-09-24 18:57:33 -04:00
2025-09-25 02:11:48 +00:00
2025-08-21 19:59:42 -04:00
2025-09-25 14:42:32 -07:00
2025-09-12 14:55:25 -04:00
2025-09-27 14:50:10 +00:00
2025-09-26 22:28:52 +00:00
2025-09-25 14:42:32 -07:00
2025-09-30 06:55:09 +00:00
2025-09-18 21:13:49 +00:00
2025-09-30 12:32:48 +00:00
2025-09-24 18:57:33 -04:00
2025-09-18 16:47:23 +00:00
2025-09-30 13:01:25 +00:00
2025-09-24 18:07:34 +00:00
2025-08-21 17:19:57 +00:00
2025-08-19 13:27:24 +00:00
2025-09-19 01:39:26 +02:00
2025-09-17 10:47:09 +00:00
2025-09-27 14:50:10 +00:00
2025-09-24 18:57:33 -04:00
2025-09-09 20:56:08 +02:00
2025-09-24 18:57:33 -04:00
2025-09-29 14:24:17 +00:00
2025-09-26 11:41:26 -04:00
2025-09-30 11:41:49 +00:00
2025-09-27 14:50:10 +00:00
2025-09-26 03:19:12 +00:00
2025-09-29 18:56:03 +00:00
2025-09-15 09:43:04 +02:00
2025-09-10 23:06:09 +05:30
2025-09-25 14:42:32 -07:00
2025-09-30 08:19:23 +00:00
2025-09-10 23:06:09 +05:30
2025-09-25 15:11:12 +02:00
2025-09-03 01:22:57 +02:00
2025-09-12 09:37:45 +00:00
2025-09-29 22:15:00 +00:00
2025-09-30 12:39:22 +02:00
2025-09-26 15:17:36 +00:00
2025-07-02 21:14:33 -04:00
2025-08-20 12:20:13 +02:00
2025-09-24 04:31:06 +00:00
2025-09-30 11:41:49 +00:00
2025-07-17 14:25:55 +00:00
2025-07-08 14:34:57 +00:00
2025-08-19 20:33:44 +00:00
2025-09-24 14:35:38 +02:00
2025-09-24 02:19:52 -06:00
2025-09-30 06:55:09 +00:00
2025-09-18 16:47:23 +00:00
2025-09-18 16:47:23 +00:00
2025-09-24 18:57:33 -04:00
2025-09-27 14:50:10 +00:00
2025-08-20 12:20:13 +02:00
2025-09-25 14:42:32 -07:00
2025-09-22 15:07:40 +00:00
2025-09-24 18:57:33 -04:00
2025-09-30 11:41:49 +00:00
2025-09-29 15:53:59 -06:00
2025-09-24 18:57:33 -04:00
2025-09-24 18:57:33 -04:00
2025-09-24 18:57:33 -04:00
2025-09-30 06:55:09 +00:00
2025-09-12 23:24:04 +03:00
2025-09-25 14:42:32 -07:00
2025-09-29 09:03:00 -07:00
2025-09-27 14:50:10 +00:00
2025-09-03 00:52:04 +00:00
2025-08-19 13:27:24 +00:00
2025-09-24 14:35:38 +02:00
2025-09-08 21:53:17 -06:00
2025-09-10 15:38:19 +00:00
2025-09-25 13:03:56 -06:00
2025-09-28 11:35:36 +00:00
2025-09-24 21:16:06 +00:00
2025-09-30 06:55:09 +00:00
2025-09-18 22:28:17 -06:00
2025-09-22 19:35:44 +00:00
2025-09-26 05:22:57 +00:00
2025-08-19 21:26:17 +02:00
2025-09-26 11:41:26 -04:00
2025-09-27 11:01:04 +02:00
2025-09-17 10:11:51 +02:00
2025-08-20 12:20:13 +02:00
2025-08-19 20:33:44 +00:00
2025-09-04 17:14:53 +02:00
2025-09-24 14:35:38 +02:00
2025-09-29 15:48:58 +00:00
2025-09-14 14:01:04 +02:00
2025-09-24 18:57:33 -04:00
2025-09-26 15:17:36 +00:00
2025-09-24 18:57:33 -04:00
2025-09-29 09:43:50 +00:00
2025-09-27 14:50:10 +00:00
2025-09-12 23:24:04 +03:00
2025-08-15 15:37:52 -04:00
2025-09-27 14:50:10 +00:00
2025-09-30 06:55:09 +00:00
2025-09-29 15:33:21 +02:00
2025-09-22 22:30:27 +00:00
2025-09-22 14:36:10 -07:00
2025-09-18 16:47:23 +00:00
2025-09-24 18:57:33 -04:00
2025-09-29 18:08:47 +02:00
2025-09-30 06:55:09 +00:00
2025-09-18 15:09:44 -03:00
2025-09-18 16:47:23 +00:00
2025-09-29 10:09:31 -03:00
2025-09-30 21:03:06 +08:00
2025-09-29 21:16:00 +00:00
2025-08-15 13:54:24 +03:00
2025-09-29 22:43:05 +00:00
2025-09-18 21:13:49 +00:00
2025-08-25 14:28:11 -04:00
2025-08-20 12:20:13 +02:00
2025-08-19 20:33:44 +00:00
2025-09-30 11:41:49 +00:00
2025-09-29 22:15:00 +00:00
2025-09-29 11:38:55 +00:00
2025-09-30 21:03:06 +08:00
2025-09-23 21:40:22 +00:00
2025-09-15 03:36:24 +00:00
2025-09-29 15:48:58 +00:00
2025-09-29 22:15:00 +00:00
2025-09-29 22:15:00 +00:00
2025-09-30 08:06:31 +00:00
2025-09-26 11:41:26 -04:00
2025-09-18 21:13:49 +00:00