Finn EversandMarshall Bowers
3476705bbb
Tried fixing a keybind in https://github.com/zed-industries/zed/pull/27217 just to find out it [still doesnt render afterwards](https://zed.dev/docs/extensions/languages#language-metadata) 😅 This PR is a quick follow-up to fix this issue. Issue here is (as seen in the code comment) that the `editor::ToggleComments` command has additional arguments which caused the match to fail. However, simply adding the missing arguments does not work, since the regex only matches the first closing brace and fails to match multiple closing braces. I decided against changing the matching since it additionally looked confusing and unintuitive to use. To not be too intrusive with this change, I just decided to add some processing for the action string (the `KeymapAction` is not exported from the settings and the `Value` it holds is also private). The processing basically reverts the conversion done in `keymap_file.rs` https://github.com/zed-industries/zed/blob/4b5df2189b9d6d2ed183cfbced7e502884cd3d48/crates/settings/src/keymap_file.rs#L102-L115 and extracts just the action name. It changes nothing for existing keybinds and fixes the aforementioned issue. Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <git@maxdeviant.com>