Ben KunkleandMichael
4aac5642c1
Closes #ISSUE Improves the efficiency of our interactions with the Zed language server. Previously, on startup and after every workspace configuration changed notification, we would send >1MB of JSON Schemas to the JSON LSP. The only reason this had to happen was due to the case where an extension was installed that would result in a change to the JSON schema for settings (i.e. added language, theme, etc). This PR changes the behavior to use the URI LSP extensions of `vscode-json-language-server` in order to send the server URI's that it can then use to fetch the schemas as needed (i.e. the settings schema is only generated and sent when `settings.json` is opened. This brings the JSON we send to on startup and after every workspace configuration changed notification down to a couple of KB. Additionally, using another LSP extension request we can notify the server when a schema has changed using the URI as a key, so we no longer have to send a workspace configuration changed notification, and the schema contents will only be re-requested and regenerated if the schema is in use. Release Notes: - Improved the efficiency of communication with the builtin JSON LSP. JSON Schemas are no longer sent to the JSON language server in their full form. If you wish to view a builtin JSON schema in the language server info tab of the language server logs (`dev: open language server logs`), you must now use the `editor: open url` action with your cursor over the URL that is sent to the server. - Made it so that Zed urls (`zed://...`) are resolved locally when opened within the editor instead of being resolved through the OS. Users who could not previously open `zed://*` URLs in the editor can now do so by pasting the link into a buffer and using the `editor: open url` action (please open an issue if this is the case for you!). --------- Co-authored-by: Michael <michael@zed.dev>
44 lines
1.1 KiB
Rust
44 lines
1.1 KiB
Rust
use std::sync::Arc;
|
|
|
|
use gpui::{App, AppContext as _, Context, Entity, EventEmitter, Global};
|
|
|
|
use crate::ExtensionManifest;
|
|
|
|
pub fn init(cx: &mut App) {
|
|
let extension_events = cx.new(ExtensionEvents::new);
|
|
cx.set_global(GlobalExtensionEvents(extension_events));
|
|
}
|
|
|
|
struct GlobalExtensionEvents(Entity<ExtensionEvents>);
|
|
|
|
impl Global for GlobalExtensionEvents {}
|
|
|
|
/// An event bus for broadcasting extension-related events throughout the app.
|
|
pub struct ExtensionEvents;
|
|
|
|
impl ExtensionEvents {
|
|
/// Returns the global [`ExtensionEvents`].
|
|
pub fn try_global(cx: &App) -> Option<Entity<Self>> {
|
|
cx.try_global::<GlobalExtensionEvents>()
|
|
.map(|g| g.0.clone())
|
|
}
|
|
|
|
fn new(_cx: &mut Context<Self>) -> Self {
|
|
Self
|
|
}
|
|
|
|
pub fn emit(&mut self, event: Event, cx: &mut Context<Self>) {
|
|
cx.emit(event)
|
|
}
|
|
}
|
|
|
|
#[derive(Clone, Debug)]
|
|
pub enum Event {
|
|
ExtensionInstalled(Arc<ExtensionManifest>),
|
|
ExtensionUninstalled(Arc<ExtensionManifest>),
|
|
ExtensionsInstalledChanged,
|
|
ConfigureExtensionRequested(Arc<ExtensionManifest>),
|
|
}
|
|
|
|
impl EventEmitter<Event> for ExtensionEvents {}
|