There's still a bit more work to do on this, but this PR is compiling (with warnings) after eliminating the key types. When the tasks below are complete, this will be the new narrative for GPUI: - `Entity<T>` - This replaces `View<T>`/`Model<T>`. It represents a unit of state, and if `T` implements `Render`, then `Entity<T>` implements `Element`. - `&mut App` This replaces `AppContext` and represents the app. - `&mut Context<T>` This replaces `ModelContext` and derefs to `App`. It is provided by the framework when updating an entity. - `&mut Window` Broken out of `&mut WindowContext` which no longer exists. Every method that once took `&mut WindowContext` now takes `&mut Window, &mut App` and every method that took `&mut ViewContext<T>` now takes `&mut Window, &mut Context<T>` Not pictured here are the two other failed attempts. It's been quite a month! Tasks: - [x] Remove `View`, `ViewContext`, `WindowContext` and thread through `Window` - [x] [@cole-miller @mikayla-maki] Redraw window when entities change - [x] [@cole-miller @mikayla-maki] Get examples and Zed running - [x] [@cole-miller @mikayla-maki] Fix Zed rendering - [x] [@mikayla-maki] Fix todo! macros and comments - [x] Fix a bug where the editor would not be redrawn because of view caching - [x] remove publicness window.notify() and replace with `AppContext::notify` - [x] remove `observe_new_window_models`, replace with `observe_new_models` with an optional window - [x] Fix a bug where the project panel would not be redrawn because of the wrong refresh() call being used - [x] Fix the tests - [x] Fix warnings by eliminating `Window` params or using `_` - [x] Fix conflicts - [x] Simplify generic code where possible - [x] Rename types - [ ] Update docs ### issues post merge - [x] Issues switching between normal and insert mode - [x] Assistant re-rendering failure - [x] Vim test failures - [x] Mac build issue Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <me@as-cii.com> Co-authored-by: Cole Miller <cole@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev> Co-authored-by: Joseph <joseph@zed.dev> Co-authored-by: max <max@zed.dev> Co-authored-by: Michael Sloan <michael@zed.dev> Co-authored-by: Mikayla Maki <mikaylamaki@Mikaylas-MacBook-Pro.local> Co-authored-by: Mikayla <mikayla.c.maki@gmail.com> Co-authored-by: joão <joao@zed.dev>
78 lines
2.3 KiB
Rust
78 lines
2.3 KiB
Rust
use std::collections::BTreeMap;
|
|
use std::fs;
|
|
use std::path::Path;
|
|
|
|
use anyhow::{anyhow, Context as _, Result};
|
|
use cargo_toml::{Dependency, Manifest};
|
|
use clap::Parser;
|
|
|
|
use crate::workspace::load_workspace;
|
|
|
|
#[derive(Parser)]
|
|
pub struct PackageConformityArgs {}
|
|
|
|
pub fn run_package_conformity(_args: PackageConformityArgs) -> Result<()> {
|
|
let workspace = load_workspace()?;
|
|
|
|
let mut non_workspace_dependencies = BTreeMap::new();
|
|
|
|
for package in workspace.workspace_packages() {
|
|
let is_extension = package
|
|
.manifest_path
|
|
.parent()
|
|
.and_then(|parent| parent.parent())
|
|
.map_or(false, |grandparent_dir| {
|
|
grandparent_dir.ends_with("extensions")
|
|
});
|
|
|
|
let cargo_toml = read_cargo_toml(&package.manifest_path)?;
|
|
|
|
let is_using_workspace_lints = cargo_toml.lints.map_or(false, |lints| lints.workspace);
|
|
if !is_using_workspace_lints {
|
|
eprintln!(
|
|
"{package:?} is not using workspace lints",
|
|
package = package.name
|
|
);
|
|
}
|
|
|
|
// Extensions should not use workspace dependencies.
|
|
if is_extension {
|
|
continue;
|
|
}
|
|
|
|
for dependencies in [
|
|
&cargo_toml.dependencies,
|
|
&cargo_toml.dev_dependencies,
|
|
&cargo_toml.build_dependencies,
|
|
] {
|
|
for (name, dependency) in dependencies {
|
|
if let Dependency::Inherited(_) = dependency {
|
|
continue;
|
|
}
|
|
|
|
non_workspace_dependencies
|
|
.entry(name.to_owned())
|
|
.or_insert_with(Vec::new)
|
|
.push(package.name.clone());
|
|
}
|
|
}
|
|
}
|
|
|
|
for (dependency, packages) in non_workspace_dependencies {
|
|
eprintln!(
|
|
"{dependency} is being used as a non-workspace dependency: {}",
|
|
packages.join(", ")
|
|
);
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
/// Returns the contents of the `Cargo.toml` file at the given path.
|
|
fn read_cargo_toml(path: impl AsRef<Path>) -> Result<Manifest> {
|
|
let path = path.as_ref();
|
|
let cargo_toml_bytes = fs::read(path)?;
|
|
Manifest::from_slice(&cargo_toml_bytes)
|
|
.with_context(|| anyhow!("failed to read Cargo.toml at {path:?}"))
|
|
}
|