Files
oak-gpui/crates
Shish e3ff2ced79 [terminal] Consider "main.cs(20,5)" to be a single clickable word (#19004)
[terminal] Consider "main.cs(20,5)" to be a single clickable word

First, adding unit tests for the regexes because I'm not certain how
these regexes are _intended_ to work, and unit tests work nicely as
demonstrations of intended behaviour.

The comment string, and the regex itself, seem to imply that
"main.cs(20,5)" is supposed be a single "word" (for the purposes of
being clicked on)... but the regex doesn't actually work like that. This
PR makes it work :)

(I don't know _why_ "word with an optional `(\d+,\d+)` on the end"
doesn't match the full string, while "word with a required `(\d+,\d+)`
on the end" _does_ match the full string - aren't regexes supposed to
match as much as possible, so it should take the optional extra whenever
the extra exists? Either way, "word with a required (\d+,\d+), or word
by itself" has the correct behaviour, as demonstrated by the unit test)

Release Notes:

- N/A
2024-10-10 13:56:48 +03:00
..
2024-10-08 11:54:28 +02:00
2024-10-09 01:07:18 -07:00
2024-09-13 13:17:49 -04:00
2024-04-30 23:31:59 -06:00
2024-08-13 23:06:07 -07:00
2024-09-23 15:28:04 -06:00
2024-03-11 10:45:57 +01:00
2024-07-15 17:04:15 -06:00
2024-09-23 15:28:04 -06:00
2024-09-27 13:30:25 -04:00
2024-10-02 13:27:16 +02:00
2024-09-16 08:29:46 -04:00