oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
c5991e74bb6f305c299684dc7ac3f6ee9055efcd
oak-gpui/crates
T
History
Smit Barmase c5991e74bb project: Handle textDocument/didSave and textDocument/didChange (un)registration and usage correctly (#36441) 
Follow-up of https://github.com/zed-industries/zed/pull/35306

This PR contains two changes:

Both changes are inspired from:
https://github.com/microsoft/vscode-languageserver-node/blob/d90a87f9557a0df9142cfb33e251cfa6fe27d970/client/src/common/textSynchronization.ts

1. Handling `textDocument/didSave` and `textDocument/didChange`
registration and unregistration correctly:

```rs
#[derive(Debug, Eq, PartialEq, Clone, Deserialize, Serialize)]
#[serde(untagged)]
pub enum TextDocumentSyncCapability {
    Kind(TextDocumentSyncKind),
    Options(TextDocumentSyncOptions),
}
```

- `textDocument/didSave` dynamic registration contains "includeText"
- `textDocument/didChange` dynamic registration contains "syncKind"

While storing this to Language Server, we use
`TextDocumentSyncCapability::Options` instead of
`TextDocumentSyncCapability::Kind` since it also include
[change](https://github.com/gluon-lang/lsp-types/blob/be7336e92a6ad23f214df19bcdceab17f39531a9/src/lib.rs#L1714-L1717)
field as `TextDocumentSyncCapability::Kind` as well as
[save](https://github.com/gluon-lang/lsp-types/blob/be7336e92a6ad23f214df19bcdceab17f39531a9/src/lib.rs#L1727-L1729)
field as `TextDocumentSyncSaveOptions`. This way while registering or
unregistering both of them, we don't accidentaly mess with other data.

So, if at intialization we end up getting
`TextDocumentSyncCapability::Kind` and we receive any above kind of
dynamic registration, we change `TextDocumentSyncCapability::Kind` to
`TextDocumentSyncCapability::Options` so we can store more data anyway.

2. Modify `include_text` method to only depend on
`TextDocumentSyncSaveOptions`, instead of depending on
`TextDocumentSyncKind`. Idea behind this is,
`TextDocumentSyncSaveOptions` should be responsible for
"textDocument/didSave" notification, and `TextDocumentSyncKind` should
be responsible for "textDocument/didChange", which it already is:
https://github.com/zed-industries/zed/blob/4b79eade1da2f5f7dfa18208cf882c8e6ca8a97f/crates/project/src/lsp_store.rs#L7324-L7331

Release Notes:

- N/A
2025-08-19 02:27:40 +05:30
..
acp_thread
Handle auth for claude (#36442)
2025-08-18 20:40:59 +00:00
action_log
agent2: Port more tools (#35987)
2025-08-11 17:24:48 +00:00
activity_indicator
windows: Fix auto update failure when launching from the cli (#34303)
2025-08-12 17:04:30 -07:00
agent
Standardize on canceled instead of cancelled (#36385)
2025-08-18 04:07:32 +00:00
agent2
agent: Restore last used agent session on startup (#36401)
2025-08-18 10:22:00 +00:00
agent_servers
Handle auth for claude (#36442)
2025-08-18 20:40:59 +00:00
agent_settings
agent: Update use_modifier_to_send behavior description for Windows (#36230)
2025-08-15 21:03:50 +00:00
agent_ui
Handle auth for claude (#36442)
2025-08-18 20:40:59 +00:00
ai_onboarding
Handle auth for claude (#36442)
2025-08-18 20:40:59 +00:00
anthropic
Add Claude Opus 4.1 (#35653)
2025-08-05 18:16:47 +00:00
askpass
Revert "git: Intercept signing prompt from GPG when committing" (#34306)
2025-07-11 23:20:35 +00:00
assets
Use IBM Plex Sans / Lilex (#36084)
2025-08-13 13:25:52 -06:00
assistant_context
Fully support all mention kinds (#36134)
2025-08-13 20:11:32 +00:00
assistant_slash_command
Stop extensions' servers and message loops before removing their files (#34208)
2025-07-10 19:25:10 +00:00
assistant_slash_commands
Remove /docs slash command (#36325)
2025-08-16 19:00:31 +00:00
assistant_tool
Pull action_log into its own crate (#35959)
2025-08-10 21:57:55 +00:00
assistant_tools
Add locations to native agent tool calls, and wire them up to UI (#36058)
2025-08-13 01:48:28 +00:00
audio
Add component NotificationFrame & CaptureAudio parts for testing (#36081)
2025-08-15 10:10:52 +00:00
auto_update
windows: Fix auto update failure when launching from the cli (#34303)
2025-08-12 17:04:30 -07:00
auto_update_helper
In auto-update-helper, fix parsing of --launch false (#36148)
2025-08-13 15:01:00 -07:00
auto_update_ui
Fix documentation of view release notes actions (#33851)
2025-07-03 14:22:28 +00:00
aws_http_client
bedrock: Fix remaining streaming delays (#33931)
2025-07-22 11:55:24 -04:00
bedrock
Add Claude Opus 4.1 (#35653)
2025-08-05 18:16:47 +00:00
breadcrumbs
breadcrumbs: Stylize filename in breadcrumbs when tab-bar is off and file is dirty (#30507)
2025-05-30 08:32:54 -07:00
buffer_diff
sum_tree: Store context on cursor (#34904)
2025-07-22 18:20:48 +02:00
call
Add FutureExt::with_timeout and use it for for Room::maintain_connection (#36175)
2025-08-14 17:02:51 +02:00
channel
sum_tree: Do not implement Dimension on tuples, use new Dimensions wrapper instead (#35482)
2025-08-05 00:37:22 +00:00
cli
cli: Do not rely on Spotlight for --channel support (#36082)
2025-08-12 22:37:11 +00:00
client
client: Parse auth callback query parameters before showing sign-in success page (#36440)
2025-08-18 19:57:28 +00:00
clock
…
cloud_api_client
Establish WebSocket connection to Cloud (#35734)
2025-08-07 01:28:41 +00:00
cloud_api_types
Establish WebSocket connection to Cloud (#35734)
2025-08-07 01:28:41 +00:00
cloud_llm_client
agent2: Add now, grep, and web search tools (#35974)
2025-08-11 15:34:34 +02:00
collab
collab: Drop rate_buckets table (#36315)
2025-08-16 14:11:36 +00:00
collab_ui
Remove some redundant entity clones (#36274)
2025-08-15 20:27:44 +00:00
collections
…
command_palette
Add key contexts for Pickers (#35665)
2025-08-06 15:28:18 -04:00
command_palette_hooks
…
component
Recategorize a few items in the component preview (#35681)
2025-08-05 23:11:43 +00:00
context_server
Update to new agent schema (#35578)
2025-08-04 13:49:41 +00:00
copilot
copilot: Fix Copilot fails to sign in on newer versions (#36195)
2025-08-14 23:28:15 +05:30
crashes
Separate minidump crashes from panics (#36267)
2025-08-16 06:33:32 +00:00
credentials_provider
…
dap
debugger: Filter out debug scenarios with invalid Adapters from debug picker (#35744)
2025-08-06 18:10:17 -04:00
dap_adapters
python: Use pip provided by our 'base' venv (#36414)
2025-08-18 14:48:38 +00:00
db
Misc nitpicks, changes too small / unrelated to be in other PRs (#32768)
2025-06-15 19:51:04 +00:00
debug_adapter_extension
Allow remote loading for DAP-only extensions (#33981)
2025-07-06 14:52:16 +02:00
debugger_tools
debugger: Improve appearance of session list for JavaScript debugging (#34322)
2025-07-12 15:56:05 +00:00
debugger_ui
Remove some redundant entity clones (#36274)
2025-08-15 20:27:44 +00:00
deepseek
language_models: Emit UsageUpdate events for token usage in DeepSeek and OpenAI (#33242)
2025-06-25 09:42:30 +02:00
diagnostics
editor: Add access method for project (#36266)
2025-08-15 18:34:22 +00:00
docs_preprocessor
Properly use static instead of const for global types that need a single init (#35955)
2025-08-10 18:01:54 +00:00
edit_prediction
completions: Add subtle/eager behavior to Supermaven and Copilot (#35548)
2025-08-07 18:27:29 +03:00
edit_prediction_button
Remove some redundant entity clones (#36274)
2025-08-15 20:27:44 +00:00
editor
editor: Add tests to ensure no horizontal scrolling is possible in soft wrap mode (#36411)
2025-08-18 12:35:54 +00:00
eval
Use distinct user agents in agent eval and zeta-cli (#35897)
2025-08-08 23:26:38 +00:00
explorer_command_injector
Just Zed instead of Zed Editor (#34146)
2025-07-10 21:08:43 +02:00
extension
Remove /docs slash command (#36325)
2025-08-16 19:00:31 +00:00
extension_api
Move language-specific debugging docs to the page for each language (#33692)
2025-07-01 20:02:12 +00:00
extension_cli
Remove /docs slash command (#36325)
2025-08-16 19:00:31 +00:00
extension_host
lsp: Identify language servers by their configuration (#35270)
2025-08-18 11:43:52 +02:00
extensions_ui
gpui: Add support for custom prompt text in PathPromptOptions (#36410)
2025-08-18 19:48:02 +00:00
feature_flags
client: Only connect to Collab automatically for Zed staff (#35827)
2025-08-07 22:14:25 +00:00
feedback
gpui: Store action documentation (#33809)
2025-07-02 21:14:33 -04:00
file_finder
file_finder: Fix right border not rendering (#35684)
2025-08-08 18:32:13 -03:00
file_icons
Enhance icon detection for files with custom suffixes (#34170)
2025-08-13 11:59:59 -04:00
fs
agent2: Initial infra for checkpoints and message editing (#36120)
2025-08-13 15:46:28 +00:00
fsevent
…
fuzzy
Prevent out of bounds access in recursive_score_match (#35630)
2025-08-06 10:53:20 +02:00
git
agent2: Initial infra for checkpoints and message editing (#36120)
2025-08-13 15:46:28 +00:00
git_hosting_providers
git_hosting_providers: Extract Bitbucket pull request number (#34584)
2025-08-08 01:39:32 +00:00
git_ui
gpui: Add support for custom prompt text in PathPromptOptions (#36410)
2025-08-18 19:48:02 +00:00
go_to_line
Add setting for hiding the status_bar.cursor_position_button (#36288)
2025-08-16 09:19:38 +03:00
google_ai
Update Gemini Models (#32902)
2025-06-17 20:26:27 +00:00
gpui
Handle auth for claude (#36442)
2025-08-18 20:40:59 +00:00
gpui_macros
Fix running vim tests with --features neovim (#36014)
2025-08-12 05:08:58 +00:00
gpui_tokio
…
html_to_markdown
agent: Fix crash with pathological fetch output (#34253)
2025-07-11 21:01:09 -04:00
http_client
languages: Don't remove old artifacts on download failure (#35967)
2025-08-11 07:20:03 +00:00
http_client_tls
…
icons
ui: Reduce icons stroke width (#36361)
2025-08-17 13:25:05 -03:00
image_viewer
Option to auto-close deleted files with no unsaved edits (#31920)
2025-06-03 13:18:29 +02:00
inspector_ui
Disable minimap in the inspector (#34607)
2025-07-17 09:22:04 +00:00
install_cli
gpui: Store action documentation (#33809)
2025-07-02 21:14:33 -04:00
jj
Add a picker for jj bookmark list (#30883)
2025-05-17 16:42:45 +00:00
jj_ui
editor: Improve code completion filtering to provide fewer and more accurate suggestions (#32928)
2025-06-18 16:01:28 +05:30
journal
gpui: Store action documentation (#33809)
2025-07-02 21:14:33 -04:00
language
language: Clean up allocations (#36418)
2025-08-18 18:58:12 +03:00
language_extension
lsp: Identify language servers by their configuration (#35270)
2025-08-18 11:43:52 +02:00
language_model
Handle auth for claude (#36442)
2025-08-18 20:40:59 +00:00
language_models
Handle auth for claude (#36442)
2025-08-18 20:40:59 +00:00
language_selector
Add setting to hide active language button in the status bar (#33977)
2025-08-08 05:04:30 +00:00
language_tools
Remove some redundant entity clones (#36274)
2025-08-15 20:27:44 +00:00
languages
lsp: Always report innermost workspace_folders (#36407)
2025-08-18 11:48:21 +00:00
livekit_api
Use anyhow more idiomatically (#31052)
2025-05-20 23:06:07 +00:00
livekit_client
Add component NotificationFrame & CaptureAudio parts for testing (#36081)
2025-08-15 10:10:52 +00:00
lmstudio
lmstudio: Propagate actual error message from server (#34538)
2025-07-25 09:36:43 -04:00
lsp
project: Print error causes when failing to spawn lsp command (#36163)
2025-08-14 08:16:25 +00:00
markdown
Use IBM Plex Sans / Lilex (#36084)
2025-08-13 13:25:52 -06:00
markdown_preview
Simplify ListState API (#35685)
2025-08-06 00:02:26 +00:00
media
Use anyhow more idiomatically (#31052)
2025-05-20 23:06:07 +00:00
menu
gpui: Store action documentation (#33809)
2025-07-02 21:14:33 -04:00
migrator
Rename remaining mentions of "inline completion" to "edit prediction" (#35512)
2025-08-04 16:22:18 +00:00
mistral
language_models: Add thinking to Mistral Provider (#32476)
2025-08-09 15:25:47 -04:00
multi_buffer
sum_tree: Do not implement Dimension on tuples, use new Dimensions wrapper instead (#35482)
2025-08-05 00:37:22 +00:00
nc
Claude experiment (#34577)
2025-07-17 14:25:55 +00:00
net
windows: Add support for SSH (#29145)
2025-07-08 14:34:57 +00:00
node_runtime
copilot: Fix Copilot fails to sign in on newer versions (#36195)
2025-08-14 23:28:15 +05:30
notifications
Redesign and clean up all icons across Zed (#35856)
2025-08-08 15:34:36 -03:00
ollama
ollama: Add support for gpt-oss (#35648)
2025-08-06 10:44:15 -04:00
onboarding
Handle auth for claude (#36442)
2025-08-18 20:40:59 +00:00
open_ai
open_ai: Fix error response parsing (#36390)
2025-08-18 08:54:31 +00:00
open_router
open_router: Fix tool_choice getting serialized to null (#34532)
2025-07-16 11:44:08 -04:00
outline
Remove into SelectionEffects from .change_selections (#33554)
2025-06-27 14:31:31 -06:00
outline_panel
Remove some redundant entity clones (#36274)
2025-08-15 20:27:44 +00:00
panel
git panel: Add some design refinements (#34064)
2025-07-08 11:23:36 -03:00
paths
paths: Fix using relative path as custom_data_dir (#35256)
2025-07-29 15:31:54 +00:00
picker
Simplify ListState API (#35685)
2025-08-06 00:02:26 +00:00
prettier
Shutdown language servers better (#35038)
2025-07-24 15:24:53 +00:00
project
project: Handle textDocument/didSave and textDocument/didChange (un)registration and usage correctly (#36441)
2025-08-19 02:27:40 +05:30
project_panel
project panel: Add git clone action to empty state (#36371)
2025-08-17 17:27:42 +00:00
project_symbols
Remove into SelectionEffects from .change_selections (#33554)
2025-06-27 14:31:31 -06:00
prompt_store
Fully support all mention kinds (#36134)
2025-08-13 20:11:32 +00:00
proto
Separate minidump crashes from panics (#36267)
2025-08-16 06:33:32 +00:00
recent_projects
git: Refine clone repo modal design (#36369)
2025-08-17 17:03:58 +00:00
refineable
Add a live Rust style editor to inspector to edit a sequence of no-argument style modifiers (#31443)
2025-05-26 17:43:57 +00:00
release_channel
Use shortened SHA when displaying version to install (#31281)
2025-05-23 14:53:53 +00:00
remote
Separate minidump crashes from panics (#36267)
2025-08-16 06:33:32 +00:00
remote_server
lsp: Identify language servers by their configuration (#35270)
2025-08-18 11:43:52 +02:00
repl
Remove some redundant entity clones (#36274)
2025-08-15 20:27:44 +00:00
reqwest_client
Add minidump crash reporting (#35263)
2025-08-04 18:19:42 -07:00
rich_text
…
rope
Reduce amount of allocations in RustLsp label handling (#35786)
2025-08-07 13:24:29 +00:00
rpc
Move timing fields into span (#35833)
2025-08-07 23:07:33 +00:00
rules_library
Rename remaining mentions of "inline completion" to "edit prediction" (#35512)
2025-08-04 16:22:18 +00:00
schema_generator
…
search
search: Fix recently introduced issues with the search bars (#36271)
2025-08-15 22:21:21 +02:00
semantic_index
Simplify ListState API (#35685)
2025-08-06 00:02:26 +00:00
semantic_version
Use anyhow more idiomatically (#31052)
2025-05-20 23:06:07 +00:00
session
…
settings
keymap_ui: Ensure keybind with empty arguments can be saved (#36393)
2025-08-18 11:01:32 +00:00
settings_profile_selector
Tighten up settings profile selector modal width (#35419)
2025-07-31 17:31:12 +00:00
settings_ui
keymap_ui: Ensure keybind with empty arguments can be saved (#36393)
2025-08-18 11:01:32 +00:00
snippet
Use anyhow more idiomatically (#31052)
2025-05-20 23:06:07 +00:00
snippet_provider
Default `#[schemars(deny_unknown_fields)] for json-language-server schemas (#33883)
2025-07-04 00:57:43 +00:00
snippets_ui
Redesign and clean up all icons across Zed (#35856)
2025-08-08 15:34:36 -03:00
sqlez
Use anyhow more idiomatically (#31052)
2025-05-20 23:06:07 +00:00
sqlez_macros
…
story
gpui: Add a standard text example (#30747)
2025-05-16 17:35:44 +02:00
storybook
Remove some redundant entity clones (#36274)
2025-08-15 20:27:44 +00:00
streaming_diff
…
sum_tree
sum_tree: Do not implement Dimension on tuples, use new Dimensions wrapper instead (#35482)
2025-08-05 00:37:22 +00:00
supermaven
completions: Add subtle/eager behavior to Supermaven and Copilot (#35548)
2025-08-07 18:27:29 +03:00
supermaven_api
supermaven_api: Ensure downloaded Supermaven binary has executable permissions set (#32576)
2025-06-17 14:39:45 +00:00
svg_preview
gpui: Store action documentation (#33809)
2025-07-02 21:14:33 -04:00
tab_switcher
gpui: Store action documentation (#33809)
2025-07-02 21:14:33 -04:00
task
Add support for Nushell in shell builder (#33806)
2025-07-08 14:57:37 +00:00
tasks_ui
Revise and clean up some icons (#35582)
2025-08-04 11:58:31 -03:00
telemetry
…
telemetry_events
Remove old telemetry events and transformation layer (#36263)
2025-08-15 15:37:52 -04:00
terminal
Move the cursor on search in Terminal if ViMode is active (#33305)
2025-08-13 17:45:50 -04:00
terminal_view
Remove some redundant entity clones (#36274)
2025-08-15 20:27:44 +00:00
text
helix: Change f and t motions (#35216)
2025-08-14 13:04:07 -04:00
theme
Make agent font size inherit the UI font size by default (#36306)
2025-08-16 14:35:06 +00:00
theme_extension
…
theme_importer
theme_importer: Add missing color imports for the minimap thumb (#34724)
2025-07-18 16:55:03 +00:00
theme_selector
Redesign and clean up all icons across Zed (#35856)
2025-08-08 15:34:36 -03:00
time_format
…
title_bar
title_bar: Fix screensharing errors not being shown to the user (#36424)
2025-08-18 16:27:26 +00:00
toolchain_selector
python: Fix flickering in the status bar (#36039)
2025-08-12 13:36:28 +00:00
ui
keymap_ui: Ensure keybind with empty arguments can be saved (#36393)
2025-08-18 11:01:32 +00:00
ui_input
keymap editor: Refine how we display matching keystrokes (#35796)
2025-08-07 11:50:11 -03:00
ui_macros
Update syn crate from 1.0.109 to 2.0.101 (#31301)
2025-05-23 19:31:25 +00:00
ui_prompt
ui_prompt: Fix prompt dialog is hard to see on large screen (#35348)
2025-07-30 23:03:53 +05:30
util
Make alphabetical sorting the default (#32315)
2025-08-13 18:07:49 -04:00
util_macros
Remove separator! macro and make path! handle relative paths (#32527)
2025-06-13 06:32:29 +00:00
vercel
openai: Don't send prompt_cache_key for OpenAI-compatible models (#36231)
2025-08-15 13:54:24 +03:00
vim
vim: Fix ap text object selection when there is line wrapping (#35485)
2025-08-18 09:57:53 -06:00
vim_mode_setting
vim: Fix escape key switching back to default mode instead of normal mode (#31843)
2025-06-18 21:26:12 +00:00
watch
chore: Fix warnings for Rust 1.89 (#32378)
2025-06-09 13:11:57 +02:00
web_search
Replace zed_llm_client with cloud_llm_client (#35309)
2025-07-30 00:09:14 +00:00
web_search_providers
Replace zed_llm_client with cloud_llm_client (#35309)
2025-07-30 00:09:14 +00:00
workspace
gpui: Add support for custom prompt text in PathPromptOptions (#36410)
2025-08-18 19:48:02 +00:00
worktree
sum_tree: Do not implement Dimension on tuples, use new Dimensions wrapper instead (#35482)
2025-08-05 00:37:22 +00:00
x_ai
openai: Don't send prompt_cache_key for OpenAI-compatible models (#36231)
2025-08-15 13:54:24 +03:00
zed
gpui: Add support for custom prompt text in PathPromptOptions (#36410)
2025-08-18 19:48:02 +00:00
zed_actions
Allow editing Agent2 messages (#36155)
2025-08-14 13:39:33 +00:00
zeta
zeta: Add latency telemetry for 1% of edit predictions (#36020)
2025-08-12 06:47:54 +00:00
zeta_cli
Use distinct user agents in agent eval and zeta-cli (#35897)
2025-08-08 23:26:38 +00:00
zlog
Add meta description tag to docs pages (#35112)
2025-07-29 23:01:03 +00:00
zlog_settings
…