6fca1d2b0b
There's still a bit more work to do on this, but this PR is compiling (with warnings) after eliminating the key types. When the tasks below are complete, this will be the new narrative for GPUI: - `Entity<T>` - This replaces `View<T>`/`Model<T>`. It represents a unit of state, and if `T` implements `Render`, then `Entity<T>` implements `Element`. - `&mut App` This replaces `AppContext` and represents the app. - `&mut Context<T>` This replaces `ModelContext` and derefs to `App`. It is provided by the framework when updating an entity. - `&mut Window` Broken out of `&mut WindowContext` which no longer exists. Every method that once took `&mut WindowContext` now takes `&mut Window, &mut App` and every method that took `&mut ViewContext<T>` now takes `&mut Window, &mut Context<T>` Not pictured here are the two other failed attempts. It's been quite a month! Tasks: - [x] Remove `View`, `ViewContext`, `WindowContext` and thread through `Window` - [x] [@cole-miller @mikayla-maki] Redraw window when entities change - [x] [@cole-miller @mikayla-maki] Get examples and Zed running - [x] [@cole-miller @mikayla-maki] Fix Zed rendering - [x] [@mikayla-maki] Fix todo! macros and comments - [x] Fix a bug where the editor would not be redrawn because of view caching - [x] remove publicness window.notify() and replace with `AppContext::notify` - [x] remove `observe_new_window_models`, replace with `observe_new_models` with an optional window - [x] Fix a bug where the project panel would not be redrawn because of the wrong refresh() call being used - [x] Fix the tests - [x] Fix warnings by eliminating `Window` params or using `_` - [x] Fix conflicts - [x] Simplify generic code where possible - [x] Rename types - [ ] Update docs ### issues post merge - [x] Issues switching between normal and insert mode - [x] Assistant re-rendering failure - [x] Vim test failures - [x] Mac build issue Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <me@as-cii.com> Co-authored-by: Cole Miller <cole@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev> Co-authored-by: Joseph <joseph@zed.dev> Co-authored-by: max <max@zed.dev> Co-authored-by: Michael Sloan <michael@zed.dev> Co-authored-by: Mikayla Maki <mikaylamaki@Mikaylas-MacBook-Pro.local> Co-authored-by: Mikayla <mikayla.c.maki@gmail.com> Co-authored-by: joão <joao@zed.dev>
56 lines
1.5 KiB
Rust
56 lines
1.5 KiB
Rust
use gpui::{px, rems, App, Pixels, Rems};
|
|
use settings::Settings;
|
|
use theme::{ThemeSettings, UiDensity};
|
|
use ui_macros::derive_dynamic_spacing;
|
|
|
|
// Derives [DynamicSpacing]. See [ui_macros::derive_dynamic_spacing].
|
|
//
|
|
// There are 3 UI density settings: Compact, Default, and Comfortable.
|
|
//
|
|
// When a tuple of three values is provided, the values are used directly.
|
|
//
|
|
// Example: (1, 2, 4) => Compact: 1px, Default: 2px, Comfortable: 4px
|
|
//
|
|
// When a single value is provided, the standard spacing formula is
|
|
// used to derive the of spacing values. This formula can be found in
|
|
// the macro.
|
|
//
|
|
// Example:
|
|
//
|
|
// Assuming the standard formula is (n-4, n, n+4)
|
|
//
|
|
// 24 => Compact: 20px, Default: 24px, Comfortable: 28px
|
|
//
|
|
// The [DynamicSpacing] enum variants use a BaseXX format,
|
|
// where XX = the pixel value @ default rem size and the default UI density.
|
|
//
|
|
// Example:
|
|
//
|
|
// DynamicSpacing::Base16 would return 16px at the default UI scale & density.
|
|
derive_dynamic_spacing![
|
|
(0, 0, 0),
|
|
(1, 1, 2),
|
|
(1, 2, 4),
|
|
(2, 3, 4),
|
|
(2, 4, 6),
|
|
(3, 6, 8),
|
|
(4, 8, 10),
|
|
(10, 12, 14),
|
|
(14, 16, 18),
|
|
(18, 20, 22),
|
|
24,
|
|
32,
|
|
40,
|
|
48
|
|
];
|
|
|
|
/// Returns the current [`UiDensity`] setting. Use this to
|
|
/// modify or show something in the UI other than spacing.
|
|
///
|
|
/// Do not use this to calculate spacing values.
|
|
///
|
|
/// Always use [DynamicSpacing] for spacing values.
|
|
pub fn ui_density(cx: &mut App) -> UiDensity {
|
|
ThemeSettings::get_global(cx).ui_density
|
|
}
|