oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
9c54bd1bd4afe7f19113e896b041dd79d14fd8d6
oak-gpui/crates
T
History
Thorsten BallandAntonio 9c54bd1bd4 macOS: Drop input handler to avoid editor/project not being dropped (#18898) 
This fixes the problem of a `Project` sometimes not being dropped when
closing the single, last window of Zed.

Turns out, it wasn't get dropped for the following reason:

1. `editor::Editor` held a reference to project
2. The macOS `input_handler` on the `Window` held a reference to that
`Editor`
3. The AppKit window (and its input handler) get dropped asynchronously
(in the code in this diff), after the window is closed.
4. After the window is closed and no `cx.update()` calls are made
anymore, `flush_effects` is not called anymore.
5. But `flush_effects` is where we dropped entities that don't have any
more references.

In short: we dropped `Editor`, which held a reference to `Project`, out
of band, `flush_effects` wasn't called anymore, and thus the `Project`
wasn't dropped.

cc @ConradIrwin @bennetbo since we talked about this.

Release Notes:

- N/A

Co-authored-by: Antonio <antonio@zed.dev>
2024-10-09 10:45:35 +02:00
..
activity_indicator
Direnv warn (#18850)
2024-10-08 11:54:28 +02:00
anthropic
collab: Track cache writes/reads in LLM usage (#18834)
2024-10-07 17:32:49 -04:00
assets
add ui::Vector and separate images from icons (#17815)
2024-09-13 17:44:16 -04:00
assistant
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
assistant_slash_command
Introduce a new /delta command (#17903)
2024-09-17 08:47:08 -06:00
assistant_tool
assistant: Add basic tool invocation (#17368)
2024-09-04 14:32:20 -04:00
audio
Update Rust crate rodio to 0.19.0 (#17389)
2024-09-16 21:55:32 -06:00
auto_update
Continue to redirect to GitHub commits for nightly and dev release notes (#18487)
2024-09-28 15:20:32 -04:00
breadcrumbs
Add missing shortcuts in tooltips (#18282)
2024-09-27 11:06:48 +02:00
call
Fix renames over language server for SSH remoting (#17897)
2024-09-16 16:20:17 -06:00
channel
Pass Summary::Context to Item::summarize (#18510)
2024-09-29 10:30:48 -06:00
cli
zed: Use CLI env for lang servers, tasks, terminal (#17075)
2024-08-29 18:09:06 +02:00
client
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
clock
Fix bugs with applying hunks from branch buffers (#18721)
2024-10-07 16:28:33 -07:00
collab
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
collab_ui
Fix renames over language server for SSH remoting (#17897)
2024-09-16 16:20:17 -06:00
collections
gpui: Add SVG rendering to img element and generic asset cache (#9931)
2024-03-29 17:09:49 -07:00
command_palette
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
command_palette_hooks
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
context_servers
context_servers: Remove context_type from ResourceContent (#18097)
2024-09-19 15:51:48 -04:00
copilot
Stop leaking isahc assumption (#18408)
2024-09-26 14:01:05 -06:00
db
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
dev_server_projects
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
diagnostics
Tweak warning diagnostic toggle (#18637)
2024-10-02 13:57:20 -03:00
docs_preprocessor
Don't rely on relative path for docs preprocessor (#16883)
2024-08-26 11:43:13 -04:00
editor
Fix bugs in expanding diff hunk (#18885)
2024-10-08 17:30:42 -07:00
evals
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
extension
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
extension_api
zed_extension_api: Use v0.2.0 WIT types (#17802)
2024-09-13 14:49:50 -04:00
extension_cli
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
extensions_ui
Extract Protocol Buffers support into an extension (#18704)
2024-10-03 13:37:43 -04:00
feature_flags
/auto (#16696)
2024-09-13 13:17:49 -04:00
feedback
Stop leaking isahc assumption (#18408)
2024-09-26 14:01:05 -06:00
file_finder
Avoid unwrap in file finder (#18374)
2024-09-26 10:31:17 +03:00
file_icons
chore: Clean up allocs around project panel (#15422)
2024-07-29 14:21:41 +02:00
fs
Fix file watching for symlinks (#17609)
2024-09-30 23:04:35 -07:00
fsevent
Retain run loop (#11241)
2024-04-30 23:31:59 -06:00
fuzzy
Improve slash commands (#16195)
2024-08-13 23:06:07 -07:00
git
Pass Summary::Context to Item::summarize (#18510)
2024-09-29 10:30:48 -06:00
git_hosting_providers
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
go_to_line
More git hunk highlighting fixes (#18459)
2024-09-27 13:48:37 -07:00
google_ai
Stop leaking isahc assumption (#18408)
2024-09-26 14:01:05 -06:00
gpui
macOS: Drop input handler to avoid editor/project not being dropped (#18898)
2024-10-09 10:45:35 +02:00
gpui_macros
add ui::Vector and separate images from icons (#17815)
2024-09-13 17:44:16 -04:00
headless
Allow using system node (#18172)
2024-09-23 15:28:04 -06:00
html_to_markdown
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
http_client
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
image_viewer
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
indexed_docs
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
inline_completion_button
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
install_cli
…
isahc_http_client
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
journal
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
language
Fix bugs in expanding diff hunk (#18885)
2024-10-08 17:30:42 -07:00
language_model
telemetry: Add language_name and model_provider (#18640)
2024-10-04 14:37:27 -04:00
language_selector
use ssh lsp store (#17655)
2024-09-10 15:51:01 -04:00
language_tools
Improve language server log view split ergonomics (#18527)
2024-09-30 11:25:11 +03:00
languages
c: Add runnable for main function (#18720)
2024-10-04 17:28:12 +02:00
live_kit_client
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
live_kit_server
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
lsp
lsp: Remove reinstall, update config (#18318)
2024-09-25 10:45:56 -07:00
markdown
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
markdown_preview
Fix rendering of markdown tables (#18315)
2024-09-30 15:50:30 -07:00
media
Update Rust crate bindgen to 0.70.0 (#17024)
2024-08-28 22:12:49 -07:00
menu
open picker (#14524)
2024-07-15 17:04:15 -06:00
multi_buffer
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
node_runtime
Make python run local worktree LSPs (#18353)
2024-09-25 12:45:41 -07:00
notifications
Pass Summary::Context to Item::summarize (#18510)
2024-09-29 10:30:48 -06:00
ollama
Fix read timeout for ollama (#18417)
2024-09-27 00:36:17 -06:00
open_ai
Stop leaking isahc assumption (#18408)
2024-09-26 14:01:05 -06:00
outline
More git hunk highlighting fixes (#18459)
2024-09-27 13:48:37 -07:00
outline_panel
ssh remoting: Fix cmd-o (#18308)
2024-09-24 16:23:08 -06:00
paths
macos: Use ~/Library/Caches/Zed instead of ~/.cache/zed (#17949)
2024-09-17 13:51:11 -04:00
picker
Update typos-cli to v1.24.6. Add scripts/check-spelling. Fix typos (#17961)
2024-09-17 15:08:14 -04:00
prettier
Allow using system node (#18172)
2024-09-23 15:28:04 -06:00
project
Direnv warn (#18850)
2024-10-08 11:54:28 +02:00
project_panel
Project panel horizontal scrollbar (#18513)
2024-10-01 18:32:16 +03:00
project_symbols
Fix renames over language server for SSH remoting (#17897)
2024-09-16 16:20:17 -06:00
proto
ssh remoting: Enable reconnecting after connection losses (#18586)
2024-10-07 11:40:59 +02:00
quick_action_bar
Add missing shortcuts in tooltips (#18282)
2024-09-27 11:06:48 +02:00
recent_projects
ssh: Fix text wrapping in loading text (#18876)
2024-10-08 18:37:04 -03:00
refineable
…
release_channel
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
remote
ssh: Limit amount of reconnect attempts (#18819)
2024-10-08 11:37:54 +02:00
remote_server
remote server: Add more debug logging (#18855)
2024-10-08 13:57:26 +02:00
repl
Styling option for separating terminal view background from background color (#17611)
2024-09-17 12:51:31 -04:00
rich_text
Disable definition lists in Markdown (#17648)
2024-09-10 11:16:27 -04:00
rope
Pass Summary::Context to Item::summarize (#18510)
2024-09-29 10:30:48 -06:00
rpc
Remove Qwen2 model (#18444)
2024-09-27 13:30:25 -04:00
search
Adjust spacing and sizing of buffer search bar icon buttons (#18638)
2024-10-02 13:57:03 -03:00
semantic_index
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
semantic_version
Extract SemanticVersion into its own crate (#9956)
2024-03-29 12:11:57 -04:00
session
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
settings
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
settings_ui
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
snippet
Correct escaping in snippets (#14912)
2024-07-22 00:57:34 +02:00
snippet_provider
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
snippets_ui
Add snippet commands (#18453)
2024-10-02 13:27:16 +02:00
sqlez
Compare migrations formatted uniformly (#18760)
2024-10-05 12:58:45 +03:00
sqlez_macros
Compare migrations formatted uniformly (#18760)
2024-10-05 12:58:45 +03:00
story
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
storybook
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
sum_tree
Pass Summary::Context to Item::summarize (#18510)
2024-09-29 10:30:48 -06:00
supermaven
Implement grapheme support for supermaven completions (#18279)
2024-09-24 08:49:07 -06:00
supermaven_api
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
tab_switcher
tab_switcher: Use git-aware colors for file icons (#18733)
2024-10-04 10:37:41 -04:00
task
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
tasks_ui
ssh remoting: Fix cmd-o (#18308)
2024-09-24 16:23:08 -06:00
telemetry_events
Provide a default value for is_via_ssh when it isn't sent via older clients (#18874)
2024-10-08 16:16:38 -04:00
terminal
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
terminal_view
Add is_via_ssh field to edit events (#18867)
2024-10-08 13:13:40 -04:00
text
Fix bugs with applying hunks from branch buffers (#18721)
2024-10-07 16:28:33 -07:00
theme
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
2024-10-07 01:29:58 +02:00
theme_importer
chore: Another round of style lints fixes (#17519)
2024-09-07 02:36:55 +02:00
theme_selector
settings_ui: Add theme settings controls (#15115)
2024-07-24 16:25:52 -04:00
time_format
chore: Fix several style lints (#17488)
2024-09-06 11:58:39 +02:00
title_bar
ssh: Add tweaks to the UI (#18817)
2024-10-08 14:32:52 -03:00
ui
ui: Fix avatar indicators getting cut off (#18821)
2024-10-07 12:53:11 -04:00
ui_input
Rename ui_text_field crate to ui_input (#13949)
2024-07-08 17:05:30 -04:00
ui_macros
Add ui_macros crate & DerivePathStr derive macro (#17811)
2024-09-13 16:45:16 -04:00
util
windows: Fix sometimes log error messages don't show the crate name (#18706)
2024-10-03 13:00:33 -07:00
vcs_menu
vcs_menu: Streamline branch creation from branch selector (#18712)
2024-10-03 16:18:28 -04:00
vim
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
welcome
Welcome tweaks (#17874)
2024-09-16 08:29:46 -04:00
workspace
Add ssh initialization events (#18831)
2024-10-07 16:17:43 -04:00
worktree
worktree: Depend on rpc with test-support feature in tests (#18866)
2024-10-08 13:07:34 -04:00
zed
Revert http client changes (#18892)
2024-10-09 01:07:18 -07:00
zed_actions
Improve Linux terminal keymap and context menu (#16845)
2024-08-26 01:01:46 +03:00