oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
95c045ad9396f0a327aea61f7b46eaf35b97ec82
oak-gpui/crates
T
History
Kirill BulatovandPiotr Osiewicz 95c045ad93 Fix LSP violation when dismissing server notifications (#23531) 
Part of https://github.com/zed-industries/zed/issues/22606
Closes https://github.com/zed-industries/zed/issues/23509

When a user sees an odd notification from the language server like

<img width="508" alt="image"
src="https://github.com/user-attachments/assets/6f5ef1aa-0f09-4705-a02a-aaf81dd8620c"
/>

they usually dismiss that.

Zed uses channels to wait and handle user interactions with such
notifications, and, due to `?`, sends back
```json
{"jsonrpc":"2.0","id":1,"error":{"message":"receiving from an empty and closed channel"}}
```

which is not spec-compliant:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showMessageRequest

> Response:
>
> * result: the selected
[MessageActionItem](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#messageActionItem)
| null if none got selected.
> * error: code and message set in case an exception happens during
showing a message.

Unfortunately, vtsls (and, potentially, others) crash if receive such
non-compliant requests, and do not get back.

After the fix, the message is correct:
```json
{"jsonrpc":"2.0","id":1,"result":null}
```


Release Notes:

- Fixed vtsls crashing on notification dismiss

Co-authored-by: Piotr Osiewicz <piotr@zed.dev>
2025-01-23 13:30:35 +00:00
..
activity_indicator
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
anthropic
Fix older Anthropic models not supporting -latest tags (#23372)
2025-01-20 13:19:15 -05:00
assets
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
assistant
assistant2: Add button to open the prompt library (#23500)
2025-01-22 22:53:54 +00:00
assistant2
assistant2: Don't suggest thread context for inline assist without a ThreadStore (#23506)
2025-01-22 23:47:56 +00:00
assistant_context_editor
Extract ContextHistory to assistant_context_editor (#23437)
2025-01-22 01:32:24 +00:00
assistant_settings
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
assistant_slash_command
Add assistant_context_editor crate (#23429)
2025-01-21 21:22:59 +00:00
assistant_slash_commands
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
assistant_tool
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
assistant_tools
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
audio
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
auto_update
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
auto_update_ui
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
breadcrumbs
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
call
Allow filling co-authors in the git panel's commit input (#23329)
2025-01-18 22:57:17 +02:00
channel
Allow filling co-authors in the git panel's commit input (#23329)
2025-01-18 22:57:17 +02:00
cli
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
client
Require accepting ToS when enabling zeta (#23255)
2025-01-20 11:48:49 -03:00
clock
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
collab
project: Allow running multiple instances of a single language server within a single worktree (#23473)
2025-01-22 21:19:02 +01:00
collab_ui
Allow filling co-authors in the git panel's commit input (#23329)
2025-01-18 22:57:17 +02:00
collections
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
command_palette
Load all key bindings that parse and use markdown in error notifications (#23113)
2025-01-18 22:27:08 +00:00
command_palette_hooks
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
context_server
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
context_server_settings
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
copilot
project: Allow running multiple instances of a single language server within a single worktree (#23473)
2025-01-22 21:19:02 +01:00
db
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
diagnostics
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
docs_preprocessor
Prefer later bindings in keymap section for display in UI (#23378)
2025-01-20 23:20:15 +00:00
editor
project: Allow running multiple instances of a single language server within a single worktree (#23473)
2025-01-22 21:19:02 +01:00
evals
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
extension
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
extension_api
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
extension_cli
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
extension_host
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
extensions_ui
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
feature_flags
feature_flags: Enable assistant2 for all staff (#23502)
2025-01-22 23:02:53 +00:00
feedback
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
file_finder
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
file_icons
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
fireworks
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
fs
Fix pulling metadata out of broken symlinks (#22396)
2025-01-21 17:09:16 +00:00
fsevent
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
fuzzy
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
git
git: Handle git status output for deleted-in-index state (#23483)
2025-01-22 15:28:25 -05:00
git_hosting_providers
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
git_ui
theme: Add version control colors (#23529)
2025-01-23 07:56:49 -05:00
go_to_line
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
google_ai
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
gpui
Fix single line edit prediction detection (#23456)
2025-01-22 10:00:43 -03:00
gpui_macros
project: Allow running multiple instances of a single language server within a single worktree (#23473)
2025-01-22 21:19:02 +01:00
html_to_markdown
html_to_markdown: Restore ability to publish (#23293)
2025-01-17 17:57:13 +00:00
http_client
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
image_viewer
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
indexed_docs
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
inline_completion
Show "tab Accept" only for zeta (#23463)
2025-01-22 13:19:18 -03:00
inline_completion_button
Toggle inline completion menu from keyboard (#23380)
2025-01-20 19:11:13 -03:00
install_cli
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
journal
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
language
Omit tsdk_path from the servers' options if it does not exist (#23525)
2025-01-23 11:17:32 +00:00
language_extension
Omit tsdk_path from the servers' options if it does not exist (#23525)
2025-01-23 11:17:32 +00:00
language_model
open_ai: Move from o1-preview to o1 for OpenAI Assistant provider (#23425)
2025-01-21 15:05:21 -05:00
language_model_selector
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
language_models
open_ai: Move from o1-preview to o1 for OpenAI Assistant provider (#23425)
2025-01-21 15:05:21 -05:00
language_selector
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
language_tools
project: Allow running multiple instances of a single language server within a single worktree (#23473)
2025-01-22 21:19:02 +01:00
languages
Omit tsdk_path from the servers' options if it does not exist (#23525)
2025-01-23 11:17:32 +00:00
livekit_client
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
livekit_client_macos
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
livekit_server
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
lmstudio
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
lsp
project: Allow running multiple instances of a single language server within a single worktree (#23473)
2025-01-22 21:19:02 +01:00
markdown
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
markdown_preview
Load all key bindings that parse and use markdown in error notifications (#23113)
2025-01-18 22:27:08 +00:00
media
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
menu
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
multi_buffer
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
node_runtime
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
notifications
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
ollama
ollama: Add deepseek-r1 context size to defaults (#23420)
2025-01-21 18:31:15 +00:00
open_ai
open_ai: Move from o1-preview to o1 for OpenAI Assistant provider (#23425)
2025-01-21 15:05:21 -05:00
outline
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
outline_panel
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
paths
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
picker
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
prettier
project: Allow running multiple instances of a single language server within a single worktree (#23473)
2025-01-22 21:19:02 +01:00
project
Fix LSP violation when dismissing server notifications (#23531)
2025-01-23 13:30:35 +00:00
project_panel
project_panel: Adjust entry background and border colors (#23403)
2025-01-21 11:13:46 -03:00
project_symbols
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
prompt_library
Dedupe PromptBuilder construction (#23496)
2025-01-22 22:17:36 +00:00
proto
project: Allow running multiple instances of a single language server within a single worktree (#23473)
2025-01-22 21:19:02 +01:00
recent_projects
terminal: Add scrollbar (#23256)
2025-01-18 17:36:41 +01:00
refineable
project: Allow running multiple instances of a single language server within a single worktree (#23473)
2025-01-22 21:19:02 +01:00
release_channel
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
remote
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
remote_server
Fix project entry rename in Remote Development (#23382)
2025-01-21 12:48:40 +01:00
repl
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
reqwest_client
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
rich_text
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
rope
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
rpc
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
search
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
semantic_index
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
semantic_version
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
session
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
settings
Display keymap errors on initial load (#23394)
2025-01-21 07:14:46 +00:00
settings_ui
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
snippet
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
snippet_provider
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
snippets_ui
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
sqlez
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
sqlez_macros
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
story
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
storybook
Load all key bindings that parse and use markdown in error notifications (#23113)
2025-01-18 22:27:08 +00:00
streaming_diff
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
sum_tree
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
supermaven
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
supermaven_api
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
tab_switcher
tab_switcher: Preserve selected position on closed tabs (#22861)
2025-01-20 14:15:25 +02:00
task
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
tasks_ui
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
telemetry
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
telemetry_events
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
terminal
terminal: Add scrollbar (#23256)
2025-01-18 17:36:41 +01:00
terminal_view
Consolidate Assistant panels in assistant2 feature flag (#23442)
2025-01-22 02:56:42 +00:00
text
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
theme
theme: Add version control colors (#23529)
2025-01-23 07:56:49 -05:00
theme_extension
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
theme_importer
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
theme_selector
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
time_format
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
title_bar
title_bar: Simplify git-ui feature flag check (#23475)
2025-01-22 17:28:47 +00:00
toolchain_selector
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
ui
Fix button demo in the component preview (#23423)
2025-01-21 19:33:08 +00:00
ui_input
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
ui_macros
project: Allow running multiple instances of a single language server within a single worktree (#23473)
2025-01-22 21:19:02 +01:00
util
git: Implement a basic repository selector (#23419)
2025-01-21 18:11:53 -05:00
vcs_menu
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
vim
vim: Fix % not working for multi-char bracket pairs (#23471)
2025-01-22 17:39:11 +01:00
vim_mode_setting
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
welcome
Update "Book Onboarding" destination link (#23464)
2025-01-22 16:24:39 +00:00
workspace
Make app notifications appear in new workspaces + dismiss on all workspaces (#23432)
2025-01-22 05:39:04 +00:00
worktree
git: Handle git status output for deleted-in-index state (#23483)
2025-01-22 15:28:25 -05:00
zed
Dedupe PromptBuilder construction (#23496)
2025-01-22 22:17:36 +00:00
zed_actions
assistant2: Add button to open the prompt library (#23500)
2025-01-22 22:53:54 +00:00
zed_predict_tos
Require accepting ToS when enabling zeta (#23255)
2025-01-20 11:48:49 -03:00
zeta
Show "tab Accept" only for zeta (#23463)
2025-01-22 13:19:18 -03:00