tidely 7bdc99abc1 Fix clippy::redundant_clone lint violations (#36558) ...

This removes around 900 unnecessary clones, ranging from cloning a few
ints all the way to large data structures and images.

A lot of these were fixed using `cargo clippy --fix --workspace
--all-targets`, however it often breaks other lints and needs to be run
again. This was then followed up with some manual fixing.

I understand this is a large diff, but all the changes are pretty
trivial. Rust is doing some heavy lifting here for us. Once I get it up
to speed with main, I'd appreciate this getting merged rather sooner
than later.

Release Notes:

- N/A

2025-08-20 12:20:13 +02:00

..

acp_thread

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

action_log

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

activity_indicator

Another batch of lint fixes (#36521)

2025-08-19 20:33:44 +00:00

agent

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

agent2

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

agent_servers

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

agent_settings

lints: A bunch of extra style lint fixes (#36568)

2025-08-20 12:05:58 +02:00

agent_ui

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

ai_onboarding

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

anthropic

…

askpass

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

assets

…

assistant_context

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

assistant_slash_command

lints: A bunch of extra style lint fixes (#36568)

2025-08-20 12:05:58 +02:00

assistant_slash_commands

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

assistant_tool

Another batch of lint fixes (#36521)

2025-08-19 20:33:44 +00:00

assistant_tools

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

audio

Add component NotificationFrame & CaptureAudio parts for testing (#36081)

2025-08-15 10:10:52 +00:00

auto_update

Fix unnecessary-mut-passed lint (#36490)

2025-08-19 14:20:01 +00:00

auto_update_helper

lints: A bunch of extra style lint fixes (#36568)

2025-08-20 12:05:58 +02:00

auto_update_ui

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

aws_http_client

…

bedrock

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

breadcrumbs

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

buffer_diff

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

call

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

channel

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

cli

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

client

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

clock

…

cloud_api_client

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

cloud_api_types

…

cloud_llm_client

…

collab

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

collab_ui

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

collections

…

command_palette

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

command_palette_hooks

…

component

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

context_server

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

copilot

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

crashes

Attach minidump errors to uploaded crash events (#36527)

2025-08-19 15:37:39 -07:00

credentials_provider

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

dap

lints: A bunch of extra style lint fixes (#36568)

2025-08-20 12:05:58 +02:00

dap_adapters

Another batch of lint fixes (#36521)

2025-08-19 20:33:44 +00:00

db

Silence a bucketload of logs (#36534)

2025-08-19 20:26:56 -06:00

debug_adapter_extension

…

debugger_tools

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

debugger_ui

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

deepseek

…

diagnostics

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

docs_preprocessor

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

edit_prediction

…

edit_prediction_button

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

editor

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

eval

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

explorer_command_injector

…

extension

Another batch of lint fixes (#36521)

2025-08-19 20:33:44 +00:00

extension_api

lints: A bunch of extra style lint fixes (#36568)

2025-08-20 12:05:58 +02:00

extension_cli

Remove /docs slash command (#36325)

2025-08-16 19:00:31 +00:00

extension_host

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

extensions_ui

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

feature_flags

Rename acp flag (#36541)

2025-08-20 02:11:17 +00:00

feedback

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

file_finder

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

file_icons

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

fs

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

fsevent

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

fuzzy

…

git

lints: A bunch of extra style lint fixes (#36568)

2025-08-20 12:05:58 +02:00

git_hosting_providers

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

git_ui

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

go_to_line

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

google_ai

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

gpui

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

gpui_macros

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

gpui_tokio

…

html_to_markdown

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

http_client

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

http_client_tls

…

icons

thread view: Refine the UI a bit (#36504)

2025-08-20 01:47:28 -03:00

image_viewer

…

inspector_ui

Some clippy fixes (#36544)

2025-08-20 03:40:39 +00:00

install_cli

Fix clippy::needless_borrow lint violations (#36444)

2025-08-18 21:54:35 +00:00

jj

Another batch of lint fixes (#36521)

2025-08-19 20:33:44 +00:00

jj_ui

…

journal

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

language

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

language_extension

Fix clippy::needless_borrow lint violations (#36444)

2025-08-18 21:54:35 +00:00

language_model

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

language_models

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

language_selector

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

language_tools

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

languages

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

livekit_api

…

livekit_client

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

lmstudio

…

lsp

lsp: Enable dynamic registration for TextDocumentSyncClientCapabilities post revert (#36494)

2025-08-19 20:30:25 +05:30

markdown

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

markdown_preview

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

media

…

menu

…

migrator

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

mistral

…

multi_buffer

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

nc

…

net

…

node_runtime

Another batch of lint fixes (#36521)

2025-08-19 20:33:44 +00:00

notifications

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

ollama

…

onboarding

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

open_ai

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

open_router

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

outline

…

outline_panel

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

panel

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

paths

lints: A bunch of extra style lint fixes (#36568)

2025-08-20 12:05:58 +02:00

picker

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

prettier

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

project

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

project_panel

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

project_symbols

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

prompt_store

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

proto

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

recent_projects

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

refineable

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

release_channel

…

remote

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

remote_server

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

repl

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

reqwest_client

lints: A bunch of extra style lint fixes (#36568)

2025-08-20 12:05:58 +02:00

rich_text

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

rope

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

rpc

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

rules_library

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

schema_generator

…

search

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

semantic_index

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

semantic_version

…

session

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

settings

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

settings_profile_selector

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

settings_ui

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

snippet

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

snippet_provider

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

snippets_ui

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

sqlez

Auto-fix clippy::collapsible_if violations (#36428)

2025-08-19 13:27:24 +00:00

sqlez_macros

…

story

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

storybook

Another batch of lint fixes (#36521)

2025-08-19 20:33:44 +00:00

streaming_diff

Fix clippy::needless_borrow lint violations (#36444)

2025-08-18 21:54:35 +00:00

sum_tree

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

supermaven

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

supermaven_api

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

svg_preview

Another batch of lint fixes (#36521)

2025-08-19 20:33:44 +00:00

tab_switcher

…

task

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

tasks_ui

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

telemetry

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

telemetry_events

Remove old telemetry events and transformation layer (#36263)

2025-08-15 15:37:52 -04:00

terminal

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

terminal_view

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

text

Fix a bunch of other low-hanging style lints (#36498)

2025-08-19 21:26:17 +02:00

theme

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

theme_extension

…

theme_importer

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

theme_selector

…

time_format

…

title_bar

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

toolchain_selector

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

ui

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

ui_input

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

ui_macros

…

ui_prompt

…

util

lints: A bunch of extra style lint fixes (#36568)

2025-08-20 12:05:58 +02:00

util_macros

…

vercel

openai: Don't send prompt_cache_key for OpenAI-compatible models (#36231)

2025-08-15 13:54:24 +03:00

vim

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

vim_mode_setting

…

watch

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

web_search

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

web_search_providers

Another batch of lint fixes (#36521)

2025-08-19 20:33:44 +00:00

workspace

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

worktree

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

x_ai

lints: A bunch of extra style lint fixes (#36568)

2025-08-20 12:05:58 +02:00

zed

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

zed_actions

…

zeta

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

zeta_cli

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

zlog

Fix clippy::redundant_clone lint violations (#36558)

2025-08-20 12:20:13 +02:00

zlog_settings

…