Closes https://github.com/zed-industries/zed/issues/39104 This fixes an issue where the preview would not work for remote buffers in the process. Release Notes: - Fixed an issue where the SVG preview would not work in remote scenarios. - The SVG preview will now rerender on every keypress instead of only on saves.
348 lines
12 KiB
Rust
348 lines
12 KiB
Rust
use std::mem;
|
|
use std::sync::Arc;
|
|
|
|
use editor::Editor;
|
|
use file_icons::FileIcons;
|
|
use gpui::{
|
|
App, Context, Entity, EventEmitter, FocusHandle, Focusable, IntoElement, ParentElement, Render,
|
|
RenderImage, Styled, Subscription, Task, WeakEntity, Window, div, img,
|
|
};
|
|
use language::{Buffer, BufferEvent};
|
|
use ui::prelude::*;
|
|
use workspace::item::Item;
|
|
use workspace::{Pane, Workspace};
|
|
|
|
use crate::{OpenFollowingPreview, OpenPreview, OpenPreviewToTheSide};
|
|
|
|
pub struct SvgPreviewView {
|
|
focus_handle: FocusHandle,
|
|
buffer: Option<Entity<Buffer>>,
|
|
current_svg: Option<Result<Arc<RenderImage>, SharedString>>,
|
|
_refresh: Task<()>,
|
|
_buffer_subscription: Option<Subscription>,
|
|
_workspace_subscription: Option<Subscription>,
|
|
}
|
|
|
|
#[derive(Clone, Copy, Debug, PartialEq)]
|
|
pub enum SvgPreviewMode {
|
|
/// The preview will always show the contents of the provided editor.
|
|
Default,
|
|
/// The preview will "follow" the last active editor of an SVG file.
|
|
Follow,
|
|
}
|
|
|
|
impl SvgPreviewView {
|
|
pub fn new(
|
|
mode: SvgPreviewMode,
|
|
active_editor: Entity<Editor>,
|
|
workspace_handle: WeakEntity<Workspace>,
|
|
window: &mut Window,
|
|
cx: &mut Context<Workspace>,
|
|
) -> Entity<Self> {
|
|
cx.new(|cx| {
|
|
let workspace_subscription = if mode == SvgPreviewMode::Follow
|
|
&& let Some(workspace) = workspace_handle.upgrade()
|
|
{
|
|
Some(Self::subscribe_to_workspace(workspace, window, cx))
|
|
} else {
|
|
None
|
|
};
|
|
|
|
let buffer = active_editor
|
|
.read(cx)
|
|
.buffer()
|
|
.clone()
|
|
.read_with(cx, |buffer, _cx| buffer.as_singleton());
|
|
|
|
let subscription = buffer
|
|
.as_ref()
|
|
.map(|buffer| Self::create_buffer_subscription(buffer, window, cx));
|
|
|
|
let mut this = Self {
|
|
focus_handle: cx.focus_handle(),
|
|
buffer,
|
|
current_svg: None,
|
|
_buffer_subscription: subscription,
|
|
_workspace_subscription: workspace_subscription,
|
|
_refresh: Task::ready(()),
|
|
};
|
|
this.render_image(window, cx);
|
|
|
|
this
|
|
})
|
|
}
|
|
|
|
fn subscribe_to_workspace(
|
|
workspace: Entity<Workspace>,
|
|
window: &Window,
|
|
cx: &mut Context<Self>,
|
|
) -> Subscription {
|
|
cx.subscribe_in(
|
|
&workspace,
|
|
window,
|
|
move |this: &mut SvgPreviewView, workspace, event: &workspace::Event, window, cx| {
|
|
if let workspace::Event::ActiveItemChanged = event {
|
|
let workspace = workspace.read(cx);
|
|
if let Some(active_item) = workspace.active_item(cx)
|
|
&& let Some(editor) = active_item.downcast::<Editor>()
|
|
&& Self::is_svg_file(&editor, cx)
|
|
{
|
|
let Some(buffer) = editor.read(cx).buffer().read(cx).as_singleton() else {
|
|
return;
|
|
};
|
|
if this.buffer.as_ref() != Some(&buffer) {
|
|
this._buffer_subscription =
|
|
Some(Self::create_buffer_subscription(&buffer, window, cx));
|
|
this.buffer = Some(buffer);
|
|
this.render_image(window, cx);
|
|
cx.notify();
|
|
}
|
|
} else {
|
|
this.set_current(None, window, cx);
|
|
}
|
|
}
|
|
},
|
|
)
|
|
}
|
|
|
|
fn render_image(&mut self, window: &Window, cx: &mut Context<Self>) {
|
|
let Some(buffer) = self.buffer.as_ref() else {
|
|
return;
|
|
};
|
|
const SCALE_FACTOR: f32 = 1.0;
|
|
|
|
let renderer = cx.svg_renderer();
|
|
let content = buffer.read(cx).snapshot();
|
|
let background_task = cx.background_spawn(async move {
|
|
renderer.render_single_frame(content.text().as_bytes(), SCALE_FACTOR, true)
|
|
});
|
|
|
|
self._refresh = cx.spawn_in(window, async move |this, cx| {
|
|
let result = background_task.await;
|
|
|
|
this.update_in(cx, |view, window, cx| {
|
|
let current = result.map_err(|e| e.to_string().into());
|
|
view.set_current(Some(current), window, cx);
|
|
})
|
|
.ok();
|
|
});
|
|
}
|
|
|
|
fn set_current(
|
|
&mut self,
|
|
image: Option<Result<Arc<RenderImage>, SharedString>>,
|
|
window: &mut Window,
|
|
cx: &mut Context<Self>,
|
|
) {
|
|
if let Some(Ok(image)) = mem::replace(&mut self.current_svg, image) {
|
|
window.drop_image(image).ok();
|
|
}
|
|
cx.notify();
|
|
}
|
|
|
|
fn find_existing_preview_item_idx(
|
|
pane: &Pane,
|
|
editor: &Entity<Editor>,
|
|
cx: &App,
|
|
) -> Option<usize> {
|
|
let buffer_id = editor.read(cx).buffer().entity_id();
|
|
pane.items_of_type::<SvgPreviewView>()
|
|
.find(|view| {
|
|
view.read(cx)
|
|
.buffer
|
|
.as_ref()
|
|
.is_some_and(|buffer| buffer.entity_id() == buffer_id)
|
|
})
|
|
.and_then(|view| pane.index_for_item(&view))
|
|
}
|
|
|
|
pub fn resolve_active_item_as_svg_editor(
|
|
workspace: &Workspace,
|
|
cx: &mut Context<Workspace>,
|
|
) -> Option<Entity<Editor>> {
|
|
workspace
|
|
.active_item(cx)?
|
|
.act_as::<Editor>(cx)
|
|
.filter(|editor| Self::is_svg_file(&editor, cx))
|
|
}
|
|
|
|
fn create_svg_view(
|
|
mode: SvgPreviewMode,
|
|
workspace: &mut Workspace,
|
|
editor: Entity<Editor>,
|
|
window: &mut Window,
|
|
cx: &mut Context<Workspace>,
|
|
) -> Entity<SvgPreviewView> {
|
|
let workspace_handle = workspace.weak_handle();
|
|
SvgPreviewView::new(mode, editor, workspace_handle, window, cx)
|
|
}
|
|
|
|
fn create_buffer_subscription(
|
|
buffer: &Entity<Buffer>,
|
|
window: &Window,
|
|
cx: &mut Context<Self>,
|
|
) -> Subscription {
|
|
cx.subscribe_in(
|
|
buffer,
|
|
window,
|
|
move |this, _buffer, event: &BufferEvent, window, cx| match event {
|
|
BufferEvent::Edited | BufferEvent::Saved => {
|
|
this.render_image(window, cx);
|
|
}
|
|
_ => {}
|
|
},
|
|
)
|
|
}
|
|
|
|
pub fn is_svg_file(editor: &Entity<Editor>, cx: &App) -> bool {
|
|
editor
|
|
.read(cx)
|
|
.buffer()
|
|
.read(cx)
|
|
.as_singleton()
|
|
.and_then(|buffer| buffer.read(cx).file())
|
|
.is_some_and(|file| {
|
|
file.path()
|
|
.extension()
|
|
.is_some_and(|ext| ext.eq_ignore_ascii_case("svg"))
|
|
})
|
|
}
|
|
|
|
pub fn register(workspace: &mut Workspace, _window: &mut Window, _cx: &mut Context<Workspace>) {
|
|
workspace.register_action(move |workspace, _: &OpenPreview, window, cx| {
|
|
if let Some(editor) = Self::resolve_active_item_as_svg_editor(workspace, cx)
|
|
&& Self::is_svg_file(&editor, cx)
|
|
{
|
|
let view = Self::create_svg_view(
|
|
SvgPreviewMode::Default,
|
|
workspace,
|
|
editor.clone(),
|
|
window,
|
|
cx,
|
|
);
|
|
workspace.active_pane().update(cx, |pane, cx| {
|
|
if let Some(existing_view_idx) =
|
|
Self::find_existing_preview_item_idx(pane, &editor, cx)
|
|
{
|
|
pane.activate_item(existing_view_idx, true, true, window, cx);
|
|
} else {
|
|
pane.add_item(Box::new(view), true, true, None, window, cx)
|
|
}
|
|
});
|
|
cx.notify();
|
|
}
|
|
});
|
|
|
|
workspace.register_action(move |workspace, _: &OpenPreviewToTheSide, window, cx| {
|
|
if let Some(editor) = Self::resolve_active_item_as_svg_editor(workspace, cx)
|
|
&& Self::is_svg_file(&editor, cx)
|
|
{
|
|
let editor_clone = editor.clone();
|
|
let view = Self::create_svg_view(
|
|
SvgPreviewMode::Default,
|
|
workspace,
|
|
editor_clone,
|
|
window,
|
|
cx,
|
|
);
|
|
let pane = workspace
|
|
.find_pane_in_direction(workspace::SplitDirection::Right, cx)
|
|
.unwrap_or_else(|| {
|
|
workspace.split_pane(
|
|
workspace.active_pane().clone(),
|
|
workspace::SplitDirection::Right,
|
|
window,
|
|
cx,
|
|
)
|
|
});
|
|
pane.update(cx, |pane, cx| {
|
|
if let Some(existing_view_idx) =
|
|
Self::find_existing_preview_item_idx(pane, &editor, cx)
|
|
{
|
|
pane.activate_item(existing_view_idx, true, true, window, cx);
|
|
} else {
|
|
pane.add_item(Box::new(view), false, false, None, window, cx)
|
|
}
|
|
});
|
|
cx.notify();
|
|
}
|
|
});
|
|
|
|
workspace.register_action(move |workspace, _: &OpenFollowingPreview, window, cx| {
|
|
if let Some(editor) = Self::resolve_active_item_as_svg_editor(workspace, cx)
|
|
&& Self::is_svg_file(&editor, cx)
|
|
{
|
|
let view =
|
|
Self::create_svg_view(SvgPreviewMode::Follow, workspace, editor, window, cx);
|
|
workspace.active_pane().update(cx, |pane, cx| {
|
|
pane.add_item(Box::new(view), true, true, None, window, cx)
|
|
});
|
|
cx.notify();
|
|
}
|
|
});
|
|
}
|
|
}
|
|
|
|
impl Render for SvgPreviewView {
|
|
fn render(&mut self, _window: &mut Window, cx: &mut Context<Self>) -> impl IntoElement {
|
|
v_flex()
|
|
.id("SvgPreview")
|
|
.key_context("SvgPreview")
|
|
.track_focus(&self.focus_handle(cx))
|
|
.size_full()
|
|
.bg(cx.theme().colors().editor_background)
|
|
.flex()
|
|
.justify_center()
|
|
.items_center()
|
|
.map(|this| match self.current_svg.clone() {
|
|
Some(Ok(image)) => {
|
|
this.child(img(image).max_w_full().max_h_full().with_fallback(|| {
|
|
h_flex()
|
|
.p_4()
|
|
.gap_2()
|
|
.child(Icon::new(IconName::Warning))
|
|
.child("Failed to load SVG image")
|
|
.into_any_element()
|
|
}))
|
|
}
|
|
Some(Err(e)) => this.child(div().p_4().child(e).into_any_element()),
|
|
None => this.child(div().p_4().child("No SVG file selected")),
|
|
})
|
|
}
|
|
}
|
|
|
|
impl Focusable for SvgPreviewView {
|
|
fn focus_handle(&self, _cx: &App) -> FocusHandle {
|
|
self.focus_handle.clone()
|
|
}
|
|
}
|
|
|
|
impl EventEmitter<()> for SvgPreviewView {}
|
|
|
|
impl Item for SvgPreviewView {
|
|
type Event = ();
|
|
|
|
fn tab_icon(&self, _window: &Window, cx: &App) -> Option<Icon> {
|
|
self.buffer
|
|
.as_ref()
|
|
.and_then(|buffer| buffer.read(cx).file())
|
|
.and_then(|file| FileIcons::get_icon(file.path().as_std_path(), cx))
|
|
.map(Icon::from_path)
|
|
.or_else(|| Some(Icon::new(IconName::Image)))
|
|
}
|
|
|
|
fn tab_content_text(&self, _detail: usize, cx: &App) -> SharedString {
|
|
self.buffer
|
|
.as_ref()
|
|
.and_then(|svg_path| svg_path.read(cx).file())
|
|
.map(|name| format!("Preview {}", name.file_name(cx)).into())
|
|
.unwrap_or_else(|| "SVG Preview".into())
|
|
}
|
|
|
|
fn telemetry_event_text(&self) -> Option<&'static str> {
|
|
Some("svg preview: open")
|
|
}
|
|
|
|
fn to_item_events(_event: &Self::Event, _f: impl FnMut(workspace::item::ItemEvent)) {}
|
|
}
|