oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
75c53447548686c477434c95214e0e9a437593df
oak-gpui/crates
T
History
Kirill Bulatov 75c5344754 Fix completion labels becoming overly large due to LSP completion items with newlines (#23407) 
Reworks https://github.com/zed-industries/zed/pull/23030 and
https://github.com/zed-industries/zed/pull/15087
Closes https://github.com/zed-industries/zed/issues/23352
Closes https://github.com/zed-industries/zed/issues/23310 

Zed's completion items use `label` from LSP completion items as a base
to show in the list:
https://github.com/zed-industries/zed/blob/d290da7dac922fdc67c4774cdd371fba23fe62e3/crates/project/src/lsp_store.rs#L4371-L4374

Besides that, certain language plugins append `detail` or
`label_details.description` as a suffix:
https://github.com/zed-industries/zed/blob/d290da7dac922fdc67c4774cdd371fba23fe62e3/crates/languages/src/vtsls.rs#L178-L188

Either of these 3 properties may return `\n` (or multiple) in it,
spoiling Zed's completion menu, which uses `UniformList` to render those
items: a uniform list uses common, minimum possible height for each
element, and `\n` bloats that overly.

Good approach would be to use something else:
https://github.com/zed-industries/zed/issues/21403 but that has its own
drawbacks and relatively hard to use instead (?).

We could follow VSCode's approach and move away all but `label` from
`CodeLabel.text` to the side, where the documentation is, but that does
not solve the issue with `details` having newlines.

So, for now, sanitize all labels and remove any newlines from them. If
newlines are found, also replace whitespace sequences if there's more
than 1 in a row.

Later, this approach can be improved similarly to how Helix and Zed's
inline completions do: rendering a "ghost" text, showing the
completion's edit applied to the editor.

Release Notes:

- Fixed completion labels becoming overly large due to LSP completion
items with newlines
2025-01-21 17:55:41 +02:00
..
activity_indicator
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
anthropic
Fix older Anthropic models not supporting -latest tags (#23372)
2025-01-20 13:19:15 -05:00
assets
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
assistant
editor: Hide horizontal scrollbar if not visible (#23337)
2025-01-18 21:50:07 +00:00
assistant2
Wire up @mentioned files in assistant2 (#23389)
2025-01-20 21:33:18 -05:00
assistant_settings
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
assistant_slash_command
Wire up @mentioned files in assistant2 (#23389)
2025-01-20 21:33:18 -05:00
assistant_slash_commands
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
assistant_tool
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
assistant_tools
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
audio
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
auto_update
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
auto_update_ui
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
breadcrumbs
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
call
Allow filling co-authors in the git panel's commit input (#23329)
2025-01-18 22:57:17 +02:00
channel
Allow filling co-authors in the git panel's commit input (#23329)
2025-01-18 22:57:17 +02:00
cli
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
client
Require accepting ToS when enabling zeta (#23255)
2025-01-20 11:48:49 -03:00
clock
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
collab
Load all key bindings that parse and use markdown in error notifications (#23113)
2025-01-18 22:27:08 +00:00
collab_ui
Allow filling co-authors in the git panel's commit input (#23329)
2025-01-18 22:57:17 +02:00
collections
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
command_palette
Load all key bindings that parse and use markdown in error notifications (#23113)
2025-01-18 22:27:08 +00:00
command_palette_hooks
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
context_server
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
context_server_settings
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
copilot
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
db
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
diagnostics
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
docs_preprocessor
Prefer later bindings in keymap section for display in UI (#23378)
2025-01-20 23:20:15 +00:00
editor
Fix completion labels becoming overly large due to LSP completion items with newlines (#23407)
2025-01-21 17:55:41 +02:00
evals
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
extension
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
extension_api
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
extension_cli
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
extension_host
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
extensions_ui
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
feature_flags
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
feedback
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
file_finder
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
file_icons
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
fireworks
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
fs
windows: Fix FS-related issues (#23369)
2025-01-21 14:19:23 +08:00
fsevent
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
fuzzy
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
git
git: Skip directories in git status output (#23300)
2025-01-20 13:57:19 -05:00
git_hosting_providers
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
git_ui
git_ui: Capitalize co-author prefix (#23365)
2025-01-20 16:00:47 +00:00
go_to_line
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
google_ai
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
gpui
Prefer later bindings in keymap section for display in UI (#23378)
2025-01-20 23:20:15 +00:00
gpui_macros
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
html_to_markdown
html_to_markdown: Restore ability to publish (#23293)
2025-01-17 17:57:13 +00:00
http_client
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
image_viewer
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
indexed_docs
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
inline_completion
Require accepting ToS when enabling zeta (#23255)
2025-01-20 11:48:49 -03:00
inline_completion_button
Toggle inline completion menu from keyboard (#23380)
2025-01-20 19:11:13 -03:00
install_cli
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
journal
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
language
Fix completion labels becoming overly large due to LSP completion items with newlines (#23407)
2025-01-21 17:55:41 +02:00
language_extension
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
language_model
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
language_model_selector
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
language_models
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
language_selector
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
language_tools
Load all key bindings that parse and use markdown in error notifications (#23113)
2025-01-18 22:27:08 +00:00
languages
Fix completion labels becoming overly large due to LSP completion items with newlines (#23407)
2025-01-21 17:55:41 +02:00
livekit_client
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
livekit_client_macos
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
livekit_server
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
lmstudio
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
lsp
Revert "lsp: Parse LSP messages on background thread - again (#23122)" (#23301)
2025-01-17 15:06:10 -07:00
markdown
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
markdown_preview
Load all key bindings that parse and use markdown in error notifications (#23113)
2025-01-18 22:27:08 +00:00
media
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
menu
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
multi_buffer
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
node_runtime
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
notifications
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
ollama
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
open_ai
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
outline
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
outline_panel
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
paths
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
picker
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
prettier
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
project
Fix completion labels becoming overly large due to LSP completion items with newlines (#23407)
2025-01-21 17:55:41 +02:00
project_panel
project_panel: Adjust entry background and border colors (#23403)
2025-01-21 11:13:46 -03:00
project_symbols
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
prompt_library
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
proto
Allow filling co-authors in the git panel's commit input (#23329)
2025-01-18 22:57:17 +02:00
recent_projects
terminal: Add scrollbar (#23256)
2025-01-18 17:36:41 +01:00
refineable
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
release_channel
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
remote
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
remote_server
Fix project entry rename in Remote Development (#23382)
2025-01-21 12:48:40 +01:00
repl
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
reqwest_client
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
rich_text
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
rope
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
rpc
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
search
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
semantic_index
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
semantic_version
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
session
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
settings
Display keymap errors on initial load (#23394)
2025-01-21 07:14:46 +00:00
settings_ui
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
snippet
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
snippet_provider
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
snippets_ui
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
sqlez
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
sqlez_macros
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
story
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
storybook
Load all key bindings that parse and use markdown in error notifications (#23113)
2025-01-18 22:27:08 +00:00
streaming_diff
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
sum_tree
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
supermaven
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
supermaven_api
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
tab_switcher
tab_switcher: Preserve selected position on closed tabs (#22861)
2025-01-20 14:15:25 +02:00
task
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
tasks_ui
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
telemetry
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
telemetry_events
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
terminal
terminal: Add scrollbar (#23256)
2025-01-18 17:36:41 +01:00
terminal_view
terminal: Add scrollbar (#23256)
2025-01-18 17:36:41 +01:00
text
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
theme
project_panel: Adjust entry background and border colors (#23403)
2025-01-21 11:13:46 -03:00
theme_extension
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
theme_importer
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
theme_selector
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
time_format
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
title_bar
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
toolchain_selector
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
ui
Prefer later bindings in keymap section for display in UI (#23378)
2025-01-20 23:20:15 +00:00
ui_input
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
ui_macros
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
util
Display keymap errors on initial load (#23394)
2025-01-21 07:14:46 +00:00
vcs_menu
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
vim
Load all key bindings that parse and use markdown in error notifications (#23113)
2025-01-18 22:27:08 +00:00
vim_mode_setting
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
welcome
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
workspace
workspace: Add actions for cycling between windows (#23356)
2025-01-20 11:34:18 +00:00
worktree
windows: Fix FS-related issues (#23369)
2025-01-21 14:19:23 +08:00
zed
Display keymap errors on initial load (#23394)
2025-01-21 07:14:46 +00:00
zed_actions
chore: Use workspace fields for edition and publish (#23291)
2025-01-17 17:39:22 +01:00
zed_predict_tos
Require accepting ToS when enabling zeta (#23255)
2025-01-20 11:48:49 -03:00
zeta
Require accepting ToS when enabling zeta (#23255)
2025-01-20 11:48:49 -03:00