oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
69bdef38ecef673609e1acf1e7a6d79f5d4d44d3
oak-gpui/crates
T
History
Liu Jinyi 69bdef38ec editor: Fix inconsistent search behavior for untitled/temporary tabs (#37086) 
Closes #37597 

Release Notes:

- N/A

---


## Problem

When using "Tab Switcher: Toggle All", temporary files (untitled buffers
without associated file paths) cannot be searched by their displayed
content. This creates an inconsistent user experience where:

- **UI Display**: Shows dynamic titles based on the first line of
content (up to 40 characters)
- **Search Text**: Only searches for the static text "untitled"

### Example
- A temporary file containing `Hello World` is displayed as "Hello
World" in the tab
- However, searching for "Hello" in Tab Switcher returns no results
- Only searching for "untitled" will find this temporary file

## Root Cause

The issue stems from inconsistent title generation logic between display
and search:

1. **Display Title** (`items.rs:724`): Uses `self.title(cx)` →
`MultiBuffer::title()` → `buffer_content_title()`
- Returns the first line of content (max 40 chars) for temporary files
   
2. **Search Text** (`items.rs:650-656`): Uses `tab_content_text()`
method
   - Returns hardcoded "untitled" for files without paths

## Solution

Modified the `tab_content_text()` method in `crates/editor/src/items.rs`
to use the same logic as the displayed title for consistency:

```rust
fn tab_content_text(&self, detail: usize, cx: &App) -> SharedString {
    if let Some(path) = path_for_buffer(&self.buffer, detail, true, cx) {
        path.to_string_lossy().to_string().into()
    } else {
        // Use the same logic as the displayed title for consistency
        self.buffer.read(cx).title(cx).to_string().into()
    }
}
```
2025-09-07 11:33:17 -07:00
..
acp_thread
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
acp_tools
acp: Rename dev command (#36908)
2025-08-25 16:04:44 -06:00
action_log
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
activity_indicator
Remove some unused events (#37498)
2025-09-04 09:09:28 +02:00
agent
Centralize ZED_STATELESS (#37492)
2025-09-03 22:10:14 +00:00
agent2
agent2: Use inline enums in now and edit_file tools JSON schema (#37397)
2025-09-04 05:39:55 +00:00
agent_servers
acp: Pass project environment to external agent servers (#37568)
2025-09-04 18:16:25 -04:00
agent_settings
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
agent_ui
Tweak word completions more (#37697)
2025-09-06 13:39:21 +00:00
ai_onboarding
onboarding: Improve performance of AI upsell card (#37504)
2025-09-04 00:03:32 +00:00
anthropic
language_models: Fix beta_headers for Anthropic custom models (#37306)
2025-09-04 06:02:13 +02:00
askpass
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
assets
Use IBM Plex Sans / Lilex (#36084)
2025-08-13 13:25:52 -06:00
assistant_context
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
assistant_slash_command
Revert "Remote LSP logs (#36709)" (#37051)
2025-08-27 23:24:19 +00:00
assistant_slash_commands
Make SanitizedPath wrap Path instead of Arc<Path> to avoid allocation (#37106)
2025-08-28 13:32:30 -06:00
assistant_tool
Revert "Remote LSP logs (#36709)" (#37051)
2025-08-27 23:24:19 +00:00
assistant_tools
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
audio
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
auto_update
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
auto_update_helper
Add initial support for WSL (#37035)
2025-08-29 17:18:52 -07:00
auto_update_ui
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
aws_http_client
bedrock: Fix remaining streaming delays (#33931)
2025-07-22 11:55:24 -04:00
bedrock
bedrock: Inference Config updates (#35808)
2025-08-29 18:13:06 -04:00
breadcrumbs
Revert "Remote LSP logs (#36709)" (#37051)
2025-08-27 23:24:19 +00:00
buffer_diff
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
call
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
channel
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
cli
Remove wsl command line args on non-windows platforms (#37422)
2025-09-03 03:49:04 +00:00
client
Improve macOS version information in telemetry (#37185)
2025-09-05 12:40:47 -04:00
clock
…
cloud_api_client
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
cloud_api_types
Establish WebSocket connection to Cloud (#35734)
2025-08-07 01:28:41 +00:00
cloud_llm_client
agent2: Add now, grep, and web search tools (#35974)
2025-08-11 15:34:34 +02:00
collab
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
collab_ui
Restore notification panel settings (#37661)
2025-09-05 21:50:51 +02:00
collections
…
command_palette
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
command_palette_hooks
Syntax tree view improvements (#37570)
2025-09-05 14:22:32 +02:00
component
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
context_server
Add configurable timeout for context server tool calls (#33348)
2025-09-03 00:03:56 +00:00
copilot
Syntax tree view improvements (#37570)
2025-09-05 14:22:32 +02:00
crashes
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
credentials_provider
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
dap
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
dap_adapters
debugger: Add ability to only show stack frame entries from visible work trees (#37061)
2025-08-28 07:53:32 +00:00
db
Centralize ZED_STATELESS (#37492)
2025-09-03 22:10:14 +00:00
debug_adapter_extension
…
debugger_tools
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
debugger_ui
debugger: Fix allow showing more than 1 compact session item (#37036)
2025-09-05 21:35:28 +00:00
deepseek
Change DeepSeek max token count to 128k (#36864)
2025-09-04 05:51:48 +00:00
diagnostics
diagnostics: Fix diagnostics pane clearing up too eagerly on typing (#37546)
2025-09-04 15:30:23 +00:00
docs_preprocessor
windows: Fix keystroke & keymap (#36572)
2025-08-27 03:24:50 +08:00
edit_prediction
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
edit_prediction_button
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
editor
editor: Fix inconsistent search behavior for untitled/temporary tabs (#37086)
2025-09-07 11:33:17 -07:00
eval
Fix clippy::println_empty_string, clippy::while_let_on_iterator, clippy::while_let_on_iterator lint style violations (#36613)
2025-08-20 20:14:30 +02:00
explorer_command_injector
Just Zed instead of Zed Editor (#34146)
2025-07-10 21:08:43 +02:00
extension
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
extension_api
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
extension_cli
Remove /docs slash command (#36325)
2025-08-16 19:00:31 +00:00
extension_host
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
extensions_ui
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
feature_flags
acp: Enable claude code feature flag for everyone (#37390)
2025-09-02 17:57:29 -04:00
feedback
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
file_finder
toolchains: Allow users to provide custom paths to toolchains (#37009)
2025-09-06 00:47:39 +02:00
file_icons
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
fs
Various fixups to unsafe code (#37651)
2025-09-06 00:27:14 +02:00
fsevent
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
fuzzy
Prevent out of bounds access in recursive_score_match (#35630)
2025-08-06 10:53:20 +02:00
git
Fix clippy::println_empty_string, clippy::while_let_on_iterator, clippy::while_let_on_iterator lint style violations (#36613)
2025-08-20 20:14:30 +02:00
git_hosting_providers
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
git_ui
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
go_to_line
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
google_ai
Trim API key when submitting requests to LLM providers (#37082)
2025-08-28 12:00:44 +00:00
gpui
Revert "gpui: Skip test attribute expansion for rust-analyzer (#37611)" (#37705)
2025-09-06 16:51:51 +00:00
gpui_macros
settings ui: Start work on creating the initial structure (#36904)
2025-08-29 16:56:10 -04:00
gpui_tokio
Use Tokio::spawn instead of getting an executor handle (#36701)
2025-08-21 17:19:57 +00:00
html_to_markdown
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
http_client
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
http_client_tls
…
icons
debugger: Add ability to only show stack frame entries from visible work trees (#37061)
2025-08-28 07:53:32 +00:00
image_viewer
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
inspector_ui
Add option for code context menu items to have dynamic width (#37404)
2025-09-02 20:18:15 -03:00
install_cli
Fix clippy::needless_borrow lint violations (#36444)
2025-08-18 21:54:35 +00:00
jj
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
jj_ui
…
journal
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
keymap_editor
Add option for code context menu items to have dynamic width (#37404)
2025-09-02 20:18:15 -03:00
language
toolchains: Allow users to provide custom paths to toolchains (#37009)
2025-09-06 00:47:39 +02:00
language_extension
languages: Allow installing pre-release of rust-analyzer and clangd (#37530)
2025-09-04 09:22:19 +00:00
language_model
language_models: Add OpenRouterError and map OpenRouter errors to LanguageModelCompletionError (#34227)
2025-09-03 01:13:46 +02:00
language_models
language_models: Use /models/user for fetching OpenRouter models (#37534)
2025-09-06 07:42:15 +02:00
language_selector
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
language_tools
Fixed LSP binary info not being shown in full (#37682)
2025-09-06 07:37:59 +00:00
languages
Highlight labels in Go (#37673)
2025-09-06 01:36:36 +02:00
line_ending_selector
Add line ending selector (#35392)
2025-09-05 09:52:57 -07:00
livekit_api
…
livekit_client
Add Rodio audio pipeline as alternative to current LiveKit pipeline (#36607)
2025-08-21 15:56:16 +02:00
lmstudio
language_models: Fix tool_choice null issue for other providers (#34554)
2025-09-03 01:22:57 +02:00
lsp
Update lsp-types to properly handle brackets (#37166)
2025-08-29 17:08:42 +03:00
markdown
thread view: Refine tool call UI (#36937)
2025-08-26 12:55:40 -03:00
markdown_preview
markdown: Add HTML img tag support (#36700)
2025-08-31 11:43:24 +03:00
media
…
menu
…
migrator
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
mistral
language_models: Fix tool_choice null issue for other providers (#34554)
2025-09-03 01:22:57 +02:00
multi_buffer
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
nc
Claude experiment (#34577)
2025-07-17 14:25:55 +00:00
net
…
node_runtime
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
notifications
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
ollama
ollama: Add support for gpt-oss (#35648)
2025-08-06 10:44:15 -04:00
onboarding
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
open_ai
language_models: Fix tool_choice null issue for other providers (#34554)
2025-09-03 01:22:57 +02:00
open_router
language_models: Use /models/user for fetching OpenRouter models (#37534)
2025-09-06 07:42:15 +02:00
outline
…
outline_panel
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
panel
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
paths
Add initial support for WSL (#37035)
2025-08-29 17:18:52 -07:00
picker
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
prettier
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
project
Fixed LSP binary info not being shown in full (#37682)
2025-09-06 07:37:59 +00:00
project_panel
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
project_symbols
Make project symbols picker entry consistent with outline picker (#37176)
2025-08-29 14:07:27 -03:00
prompt_store
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
proto
toolchains: Allow users to provide custom paths to toolchains (#37009)
2025-09-06 00:47:39 +02:00
recent_projects
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
refineable
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
release_channel
…
remote
Revert "Remote: Change "sh -c" to "sh -lc" (#36760)" (#37417)
2025-09-03 14:24:32 -07:00
remote_server
Fix attach modal showing local processes in SSH sessions (#37608)
2025-09-05 17:03:42 -04:00
repl
toolchains: Allow users to provide custom paths to toolchains (#37009)
2025-09-06 00:47:39 +02:00
reqwest_client
reqwest_client: Remove example (#37410)
2025-09-03 00:52:04 +00:00
rich_text
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
rope
Optimize Chunks::seek when offset is in current chunk (#37659)
2025-09-06 04:22:55 +00:00
rpc
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
rules_library
Add macOS window tabs (#33334)
2025-08-28 03:51:22 +00:00
scheduler
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
schema_generator
…
search
Make entry_for_path return a reference instead of cloning (#37591)
2025-09-05 00:26:37 +00:00
semantic_index
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
semantic_version
…
session
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
settings
settings ui: Improve setting proc macro and add scroll to UI (#37581)
2025-09-04 22:30:48 +00:00
settings_profile_selector
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
settings_ui
Syntax tree view improvements (#37570)
2025-09-05 14:22:32 +02:00
settings_ui_macros
settings ui: Improve setting proc macro and add scroll to UI (#37581)
2025-09-04 22:30:48 +00:00
snippet
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
snippet_provider
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
snippets_ui
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
sqlez
Disable foreign keys in sqlite when running migrations (#37572)
2025-09-06 01:09:50 +00:00
sqlez_macros
…
story
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
storybook
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
streaming_diff
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
sum_tree
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
supermaven
supermaven: Improve completion caching and position validation (#37047)
2025-08-29 16:17:22 -04:00
supermaven_api
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
svg_preview
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
system_specs
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
tab_switcher
Activate preview for initially selected item (#37112)
2025-08-28 21:07:02 +00:00
task
Fix logic for default values for task variables (#37588)
2025-09-05 14:57:58 +00:00
tasks_ui
Fix clippy::len_zero lint style violations (#36589)
2025-08-20 14:35:59 +00:00
telemetry
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
telemetry_events
Remove old telemetry events and transformation layer (#36263)
2025-08-15 15:37:52 -04:00
terminal
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
terminal_view
linux: Fix IME preedit text not showing in Terminal on Wayland (#37701)
2025-09-07 02:01:55 +05:30
text
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
theme
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
theme_extension
…
theme_importer
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
theme_selector
Redesign and clean up all icons across Zed (#35856)
2025-08-08 15:34:36 -03:00
time_format
…
title_bar
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
toolchain_selector
toolchains: Allow users to provide custom paths to toolchains (#37009)
2025-09-06 00:47:39 +02:00
ui
Revert "gpui: Fix overflow_hidden to support clip with border radius" (#37480)
2025-09-03 19:52:47 +00:00
ui_input
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
ui_macros
…
ui_prompt
ui_prompt: Fix prompt dialog is hard to see on large screen (#35348)
2025-07-30 23:03:53 +05:30
util
Various fixups to unsafe code (#37651)
2025-09-06 00:27:14 +02:00
util_macros
…
vercel
openai: Don't send prompt_cache_key for OpenAI-compatible models (#36231)
2025-08-15 13:54:24 +03:00
vim
Add terminal::Toggle (#37585)
2025-09-05 17:34:39 +00:00
vim_mode_setting
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
watch
acp: Model-specific prompt capabilities for 1PA (#36879)
2025-08-25 14:28:11 -04:00
web_search
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
web_search_providers
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
workspace
Disable foreign keys in sqlite when running migrations (#37572)
2025-09-06 01:09:50 +00:00
worktree
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
x_ai
Add xAI's Grok Code Fast 1 model (#36959)
2025-08-26 21:08:45 +00:00
zed
zeta: Check whether data collection is allowed for recent edit history (#37680)
2025-09-07 11:16:49 -06:00
zed_actions
Add onboarding banner for claude code support (#37443)
2025-09-03 10:59:14 +00:00
zed_env_vars
Centralize ZED_STATELESS (#37492)
2025-09-03 22:10:14 +00:00
zeta
zeta: Check whether data collection is allowed for recent edit history (#37680)
2025-09-07 11:16:49 -06:00
zeta_cli
zeta: Check whether data collection is allowed for recent edit history (#37680)
2025-09-07 11:16:49 -06:00
zlog
Various fixups to unsafe code (#37651)
2025-09-06 00:27:14 +02:00
zlog_settings
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00