Dino 5ef6402d64 editor: Ensure all menus and popups are dismissed (#43169) ...

While investigating a bug report that, in Helix mode, pressing the
`escape` key would only hide the signature help popup and not the
completions menu, when `auto_signature_help` was enabled, it was noted
that the `editor::Editor.dismiss_menus_and_popups` method was not
dismissing all possible menus and popups and was, instead, stopping as
soon as a single menu or popup was dismissed.

From the name of the method it appears that we actually want to dismiss
all so this commit updates it as such, ensuring that the bug reported is
also fixed.

Closes #42499 

Release Notes:

- Fixed issue with popups and menus not being dismissed while using
`auto_signature_help` in Helix Mode

2025-11-20 16:25:09 +00:00

..

acp_thread

Stop thread on Restore Checkpoint (#42537)

2025-11-12 15:13:40 +00:00

acp_tools

acp_tools: Add vertical scrollbar to ACP logs (#41740)

2025-11-02 18:11:21 +00:00

action_log

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

activity_indicator

git: Add notification to git clone (#41712)

2025-11-11 01:02:13 -05:00

agent

Thought signatures (#42915)

2025-11-18 10:41:19 -05:00

agent_servers

agent_ui: Add support for setting a model as the default for external agents (#43122)

2025-11-20 11:00:01 +01:00

agent_settings

agent: Add ability to set a default_model per profile (#39220)

2025-11-10 11:11:24 -03:00

agent_ui

svg_preview: Remove unnecessary dependency on editor (#43147)

2025-11-20 12:18:50 +01:00

ai_onboarding

ai onboarding: Add dismiss button to the sign in banner (#40660)

2025-10-20 08:35:28 -03:00

anthropic

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

askpass

util: Check whether discovered powershell is actually executable (#43044)

2025-11-19 09:26:49 +00:00

assets

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

assistant_slash_command

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

assistant_slash_commands

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

assistant_text_thread

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

audio

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

auto_update

util: Use process spawn helpers in more places (#42976)

2025-11-18 14:31:39 +00:00

auto_update_helper

auto_update: Ignore dir removal errors on windows (#42435)

2025-11-11 12:55:19 +00:00

auto_update_ui

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

aws_http_client

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

bedrock

bedrock: Add support for Claude Haiku 4.5 model (#41045)

2025-10-29 16:41:43 +01:00

breadcrumbs

svg_preview: Remove unnecessary dependency on editor (#43147)

2025-11-20 12:18:50 +01:00

buffer_diff

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

call

Bump Rust to 1.91.1 (#42561)

2025-11-12 20:27:04 +00:00

channel

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

cli

rope: Prevent stack overflows by bumping rayon stack sizes (#41397)

2025-10-28 20:21:49 +00:00

client

Use metrics-id for sentry user id when we have it (#42931)

2025-11-17 23:44:59 +00:00

clock

text: Improve panic messages with more information (#42072)

2025-11-06 09:16:45 +00:00

cloud_api_client

Use cloud for auto-update (#42246)

2025-11-10 23:00:55 -07:00

cloud_api_types

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

cloud_llm_client

zeta2: Support qwen3-minimal prompt format (#42902)

2025-11-17 20:36:05 +02:00

cloud_zeta2_prompt

zeta2: Improve queries parsing (#43012)

2025-11-18 23:46:29 +00:00

codestral

zeta2: Build edit prediction prompt and process model output in client (#41870)

2025-11-06 18:36:58 -05:00

collab

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

collab_ui

svg_preview: Remove unnecessary dependency on editor (#43147)

2025-11-20 12:18:50 +01:00

collections

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

command_palette

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

command_palette_hooks

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

component

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

context_server

Add HTTP transport support for MCP servers (#39021)

2025-11-18 16:39:08 +00:00

copilot

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

crashes

extension_host: Fix IS_WASM_THREAD being set for wrong threads (#43005)

2025-11-18 23:49:22 +00:00

credentials_provider

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

dap

util: Fix zip extraction (#42714)

2025-11-19 12:34:41 +01:00

dap_adapters

Allow for using config specific gdb binaries in gdb adapter (#37193)

2025-11-06 12:53:59 -05:00

db

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

debug_adapter_extension

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

debugger_tools

Revert "Keep selection in SwitchToHelixNormalMode (#41583)" (#42892)

2025-11-17 11:01:34 -07:00

debugger_ui

debugger: Allow users to include PickProcessId in debug tasks and resolve Pid (#42913)

2025-11-20 10:12:59 -05:00

deepseek

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

denoise

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

diagnostics

svg_preview: Remove unnecessary dependency on editor (#43147)

2025-11-20 12:18:50 +01:00

docs_preprocessor

docs: Ensure macOS and Linux keybindings are escaped in HTML (#39802)

2025-10-23 14:13:35 -04:00

edit_prediction

Report discarded zeta predictions and indicate whether they were shown (#42403)

2025-11-12 16:41:04 -08:00

edit_prediction_button

zeta2: Merge Sweep and Zeta2 Providers (#43097)

2025-11-19 15:40:06 -08:00

edit_prediction_context

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

editor

editor: Ensure all menus and popups are dismissed (#43169)

2025-11-20 16:25:09 +00:00

eval

Add more secrets to eval workflows (#42459)

2025-11-11 16:07:57 +00:00

explorer_command_injector

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

extension

Support Agent Servers on remoting (#42683)

2025-11-17 10:48:14 -05:00

extension_api

Windows: Fix issues with paths in extensions (#37811)

2025-09-11 13:56:06 -07:00

extension_cli

Fix categorization of agent server extensions (#41689)

2025-10-31 21:18:22 +00:00

extension_host

Fix extension auto-install on first setup (#43078)

2025-11-19 16:41:39 +00:00

extensions_ui

ui: Remove the ToggleButton component (#43115)

2025-11-20 01:28:25 -03:00

feature_flags

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

feedback

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

file_finder

Add clear recent files history command (#42176)

2025-11-11 15:42:00 +02:00

file_icons

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

fs

Revert "Fix track file renames in git panel (#42352)" (#43030)

2025-11-19 03:56:45 +00:00

fs_benchmarks

fs: Reintroduce benchmarks crate (#40689)

2025-10-20 10:30:06 +00:00

fsevent

Try reducing flakiness of fs-event tests by bumping timeout to 4s on CI (#42960)

2025-11-18 11:00:02 +00:00

fuzzy

file_finder: Include worktree root name in multi-worktrees workspace (#40415)

2025-10-20 23:54:56 +03:00

git

Revert "Fix track file renames in git panel (#42352)" (#43030)

2025-11-19 03:56:45 +00:00

git_hosting_providers

git: Fix support for self-hosted Bitbucket (#42002)

2025-11-09 21:37:22 -05:00

git_ui

git: Compress diff for commit message generation (#42835)

2025-11-20 11:30:34 +00:00

go_to_line

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

google_ai

Update google_ai.rs (#43034)

2025-11-19 05:41:24 +00:00

gpui

Use fixed calloop (#43081)

2025-11-19 22:06:13 +01:00

gpui_macros

Reduce macro burden for rust-analyzer (#42871)

2025-11-17 12:31:00 +00:00

gpui_tokio

workspace: Handle non-cloneable items better (#41215)

2025-10-26 13:24:26 +00:00

html_to_markdown

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

http_client

http_client: Remove unused HttpClient::type_name method (#42803)

2025-11-17 15:28:22 +01:00

http_client_tls

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

icons

Add experimental Sweep edit prediction provider (#42927)

2025-11-18 01:00:26 +00:00

image_viewer

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

inspector_ui

Add support for multi-word snippet prefixes (#42398)

2025-11-11 16:34:25 -05:00

install_cli

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

journal

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

json_schema_store

Replace deprecated json.schemastore.org with www.schemastore.org (#42336)

2025-11-11 15:43:25 +02:00

keymap_editor

chore: Fix build graph - again (#42999)

2025-11-18 19:20:34 +01:00

language

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

language_extension

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

language_model

Thought signatures (#42915)

2025-11-18 10:41:19 -05:00

language_models

Thought signatures (#42915)

2025-11-18 10:41:19 -05:00

language_onboarding

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

language_selector

Fix keybind hints flickering in certain scenarios (#40927)

2025-10-22 19:52:38 +00:00

language_tools

svg_preview: Remove unnecessary dependency on editor (#43147)

2025-11-20 12:18:50 +01:00

languages

Fix diff highlights (#38384)

2025-11-20 15:52:15 +01:00

line_ending_selector

Fix keybind hints flickering in certain scenarios (#40927)

2025-10-22 19:52:38 +00:00

livekit_api

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

livekit_client

gpui: Add to support check state to MenuItem (#39876)

2025-11-07 09:42:55 +00:00

lmstudio

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

lsp

lsp: Support deprecated completion item tag and advertise capability (#43000)

2025-11-19 12:19:58 +01:00

markdown

Allow styling the container of markdown elements (#43107)

2025-11-19 23:40:54 +00:00

markdown_preview

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

media

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

menu

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

migrator

project_panel: Add auto_open settings (#40435)

2025-11-12 03:23:40 +05:30

miniprofiler_ui

Miniprofiler (#42385)

2025-11-12 15:31:20 +01:00

mistral

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

multi_buffer

multi_buffer: Remove redundant TypedOffset/TypedPoint (#43139)

2025-11-20 09:31:18 +00:00

nc

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

net

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

node_runtime

Disable env clearing for npm subcommands (#42587)

2025-11-12 22:03:59 -06:00

notifications

sum_tree: Implement recursive Sumtree::find, use it over Cursor::seek if possible (#40700)

2025-10-20 17:20:09 +00:00

ollama

ollama: Fix tool calling (#42275)

2025-11-11 16:10:47 +01:00

onboarding

Increase error verbosity (#43013)

2025-11-18 23:25:12 +00:00

open_ai

Add retry support for OpenAI-compatible LLM providers (#37891)

2025-11-13 14:15:46 +00:00

open_router

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

outline

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

outline_panel

outline_panel: Remove toggle expanded behavior from OpenSelectedEntry (#42214)

2025-11-14 01:07:22 +05:30

panel

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

paths

Miniprofiler (#42385)

2025-11-12 15:31:20 +01:00

picker

git_ui: Dismiss pickers only on active window (#41320)

2025-11-18 21:57:30 -05:00

prettier

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

project

Improve readability of files in the git changes panel (#41857)

2025-11-20 06:14:46 -05:00

project_benchmarks

search: New recent old search implementation (#40835)

2025-11-13 14:56:40 +01:00

project_panel

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

project_symbols

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

prompt_store

prompt_store: Remove unused code (#41473)

2025-10-29 16:27:30 +00:00

proto

Revert "Fix track file renames in git panel (#42352)" (#43030)

2025-11-19 03:56:45 +00:00

recent_projects

Use cloud for auto-update (#42246)

2025-11-10 23:00:55 -07:00

refineable

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

release_channel

Use cloud for auto-update (#42246)

2025-11-10 23:00:55 -07:00

remote

remote: Fix up incorrect logs (#42979)

2025-11-18 15:14:52 +00:00

remote_server

util: Use process spawn helpers in more places (#42976)

2025-11-18 14:31:39 +00:00

repl

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

reqwest_client

Add experimental Sweep edit prediction provider (#42927)

2025-11-18 01:00:26 +00:00

rich_text

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

rope

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

rpc

ACP Extensions (#40663)

2025-10-24 07:52:51 -04:00

rules_library

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

scheduler

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

schema_generator

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

search

svg_preview: Remove unnecessary dependency on editor (#43147)

2025-11-20 12:18:50 +01:00

semantic_version

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

session

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

settings

Improve readability of files in the git changes panel (#41857)

2025-11-20 06:14:46 -05:00

settings_json

settings_ui: Show migration banner (#41112)

2025-10-27 10:13:26 -04:00

settings_macros

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

settings_profile_selector

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

settings_ui

Improve readability of files in the git changes panel (#41857)

2025-11-20 06:14:46 -05:00

snippet

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

snippet_provider

Add support for multi-word snippet prefixes (#42398)

2025-11-11 16:34:25 -05:00

snippets_ui

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

sqlez

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

sqlez_macros

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

story

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

storybook

ui: Remove outdated/unused component stories (#43118)

2025-11-20 01:52:13 -03:00

streaming_diff

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

sum_tree

diagnostics: Keep diagnostic excerpt ranges properly ordered (#42298)

2025-11-09 10:55:56 +00:00

supermaven

zeta2: Build edit prediction prompt and process model output in client (#41870)

2025-11-06 18:36:58 -05:00

supermaven_api

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

svg_preview

svg_preview: Remove unnecessary dependency on editor (#43147)

2025-11-20 12:18:50 +01:00

system_specs

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

tab_switcher

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

task

debugger: Allow users to include PickProcessId in debug tasks and resolve Pid (#42913)

2025-11-20 10:12:59 -05:00

tasks_ui

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

telemetry

Fix telemetry (#42184)

2025-11-07 11:36:05 +00:00

telemetry_events

Use metrics-id for sentry user id when we have it (#42931)

2025-11-17 23:44:59 +00:00

terminal

terminal: Add setting for scroll multiplier (#39463)

2025-11-12 16:38:06 +01:00

terminal_view

terminal_view: Fix terminal opening in root directory when editing single file corktree (#42953)

2025-11-18 13:37:48 +01:00

text

multi_buffer: Typed MultiBufferOffset (#42707)

2025-11-19 22:00:58 +00:00

theme

Rename ThemeMode to ThemeAppearanceMode (#42279)

2025-11-10 14:26:01 -07:00

theme_extension

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

theme_importer

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

theme_selector

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

time_format

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

title_bar

Make drag and double click enabled on the whole title bar on macOS (#41839)

2025-11-14 22:46:35 +00:00

toolchain_selector

Fix keybind hints flickering in certain scenarios (#40927)

2025-10-22 19:52:38 +00:00

ui

ui: Remove Badge component (#43168)

2025-11-20 12:45:49 -03:00

ui_input

agent_ui: Make input fields in Bedrock settings keyboard navigable (#42916)

2025-11-17 19:13:15 -03:00

ui_macros

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

ui_prompt

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

util

Potentially make zip test less flakey (#43099)

2025-11-19 14:50:32 -07:00

util_macros

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

vercel

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

vim

vim: Fix increment panicking due to invalid utf8 offsets (#43101)

2025-11-20 07:12:50 +00:00

vim_mode_setting

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

watch

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

web_search

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

web_search_providers

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

workspace

svg_preview: Remove unnecessary dependency on editor (#43147)

2025-11-20 12:18:50 +01:00

worktree

Remove settings::Maybe (#42933)

2025-11-18 10:23:16 -07:00

worktree_benchmarks

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

x_ai

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

zed

ui: Add ThreadItem component (#43167)

2025-11-20 12:45:26 -03:00

zed_actions

chore: Fix build graph - again (#42999)

2025-11-18 19:20:34 +01:00

zed_env_vars

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

zeta

Fix formatting in various files (#42917)

2025-11-17 21:48:09 +00:00

zeta2

zeta2: Merge Sweep and Zeta2 Providers (#43097)

2025-11-19 15:40:06 -08:00

zeta2_tools

svg_preview: Remove unnecessary dependency on editor (#43147)

2025-11-20 12:18:50 +01:00

zeta_cli

zeta2: Merge Sweep and Zeta2 Providers (#43097)

2025-11-19 15:40:06 -08:00

zlog

Try to download wasi-sdk ahead of time (#42377)

2025-11-10 19:50:43 +00:00

zlog_settings

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00