oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
5b8bb6237f24d1a69bc8897add716e1df1323e2e
oak-gpui/crates
T
History
Marshall Bowers 5b8bb6237f Scale UI elements in the editor based on the buffer_font_size (#11817) 
This PR adjusts how UI elements are rendered inside of full-size editors
to scale with the configured `buffer_font_size`.

This fixes some issues where UI elements (such as the `IconButton`s used
for code action and task run indicators) would not scale as the
`buffer_font_size` was changed.

We achieve this by changing the rem size when rendering the
`EditorElement`, with a rem size that is derived from the
`buffer_font_size`.

`WindowContext` now has a new `with_rem_size` method that can be used to
render an element with a given rem size. Note that this can only be
called during `request_layout`, `prepaint`, or `paint`, similar to
`with_text_style` or `with_content_mask`.

### Before

<img width="1264" alt="Screenshot 2024-05-14 at 2 15 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/05ad7f8d-c62f-4baa-bffd-38cace7f3710">

<img width="1264" alt="Screenshot 2024-05-14 at 2 15 49 PM"
src="https://github.com/zed-industries/zed/assets/1486634/254cd11c-3723-488f-ab3d-ed653169056c">

### After

<img width="1264" alt="Screenshot 2024-05-14 at 2 13 02 PM"
src="https://github.com/zed-industries/zed/assets/1486634/c8dad309-62a4-444f-bfeb-a0009dc08c03">

<img width="1264" alt="Screenshot 2024-05-14 at 2 13 06 PM"
src="https://github.com/zed-industries/zed/assets/1486634/4d9a3a52-9656-4768-b210-840b4884e381">

Note: This diff is best viewed with whitespace changes hidden:

<img width="245" alt="Screenshot 2024-05-14 at 2 22 45 PM"
src="https://github.com/zed-industries/zed/assets/1486634/7cb9829f-9c1b-4224-95be-82182017ed90">

Release Notes:

- Changed UI elements within the editor to scale based on
`buffer_font_size` (e.g., code action indicators, task run indicators,
etc.).
2024-05-14 14:34:39 -04:00
..
activity_indicator
linux: Store binary path before restart to handle deleted binary file (#11568)
2024-05-08 19:13:28 +02:00
anthropic
Sanitize messages before sending them to Anthropic (#11810)
2024-05-14 17:47:33 +02:00
assets
New revision of the Assistant Panel (#10870)
2024-04-23 16:23:26 -07:00
assistant
Report response latency and errors when using (inline) assistant (#11806)
2024-05-14 18:18:26 +02:00
assistant2
Change ToolOutput to ToolView (#11682)
2024-05-10 15:22:09 -07:00
assistant_tooling
Bring the Tool Calling README up to date (#11683)
2024-05-12 04:47:19 -07:00
audio
…
auto_update
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
breadcrumbs
Break typography styles out of StyledExt (#11013)
2024-04-25 17:42:53 -04:00
call
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
channel
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
cli
linux cli (#11585)
2024-05-09 21:08:49 -06:00
client
Report response latency and errors when using (inline) assistant (#11806)
2024-05-14 18:18:26 +02:00
clock
…
collab
Report response latency and errors when using (inline) assistant (#11806)
2024-05-14 18:18:26 +02:00
collab_ui
wayland: Window controls and drag (#11525)
2024-05-14 09:44:55 -07:00
collections
…
color
…
command_palette
preview tabs: Allow replacing preview tab when using code navigation (#10730)
2024-04-29 20:47:01 +02:00
command_palette_hooks
…
copilot
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
db
Clean up whitespace (#10755)
2024-04-23 13:31:21 -04:00
dev_server_projects
Add xtask for finding crates with missing licenses (#11776)
2024-05-13 18:52:12 -04:00
diagnostics
Introduce DisplayRow, MultiBufferRow newtypes and BufferRow type alias (#11656)
2024-05-11 00:06:51 +03:00
editor
Scale UI elements in the editor based on the buffer_font_size (#11817)
2024-05-14 14:34:39 -04:00
extension
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
extension_api
…
extension_cli
…
extensions_ui
Extract Ruby extension (#11360)
2024-05-10 11:53:11 -04:00
feature_flags
WIP: remoting (#10085)
2024-04-11 15:36:35 -06:00
feedback
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
file_finder
Remove 'Destructive' prompts (#11631)
2024-05-09 18:52:09 -06:00
file_icons
gpui: Fix Global trait (#11187)
2024-04-29 16:37:37 -04:00
fs
linux: Handle modification events from file watcher (#11778)
2024-05-14 11:00:26 -07:00
fsevent
Retain run loop (#11241)
2024-04-30 23:31:59 -06:00
fuzzy
…
git
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
git_hosting_providers
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
go_to_line
Introduce DisplayRow, MultiBufferRow newtypes and BufferRow type alias (#11656)
2024-05-11 00:06:51 +03:00
google_ai
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
gpui
Scale UI elements in the editor based on the buffer_font_size (#11817)
2024-05-14 14:34:39 -04:00
gpui_macros
Adjust names of negated style methods (#11453)
2024-05-06 13:56:25 -04:00
headless
linux cli (#11585)
2024-05-09 21:08:49 -06:00
http
Add missing LICENSE file to http crate (#11773)
2024-05-13 18:26:12 -04:00
image_viewer
Add xtask for finding crates with missing licenses (#11776)
2024-05-13 18:52:12 -04:00
inline_completion_button
Supermaven (#10788)
2024-05-03 12:50:42 -07:00
install_cli
…
journal
…
language
editor: Support walking through overlapping diagnostics (#11139)
2024-05-11 00:32:49 +02:00
language_selector
…
language_tools
Return prettier entry back to LSP logs (#11563)
2024-05-08 18:21:43 +03:00
languages
tasks: Reorganize task modal (#11752)
2024-05-14 11:22:09 +02:00
live_kit_client
Hoist nanoid to workspace-level (#11029)
2024-04-25 22:37:40 -04:00
live_kit_server
Vendor LiveKit protocol (#11672)
2024-05-10 14:18:40 -04:00
lsp
lsp: More information in error if server fails to start (#11343)
2024-05-03 13:23:52 +02:00
markdown
Add xtask for finding crates with missing licenses (#11776)
2024-05-13 18:52:12 -04:00
markdown_preview
markdown preview: Break up list items into individual blocks (#10852)
2024-04-26 21:34:45 +02:00
media
…
menu
…
multi_buffer
Introduce DisplayRow, MultiBufferRow newtypes and BufferRow type alias (#11656)
2024-05-11 00:06:51 +03:00
node_runtime
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
notifications
…
open_ai
Add GPT-4o as possible model (#11764)
2024-05-14 10:43:24 +02:00
outline
Introduce DisplayRow, MultiBufferRow newtypes and BufferRow type alias (#11656)
2024-05-11 00:06:51 +03:00
picker
new path picker (#11015)
2024-04-26 13:25:25 -06:00
prettier
…
project
git: Support git repos with .git folder above project root (#11550)
2024-05-14 18:34:51 +02:00
project_panel
project panel: Allow confirming prompt with keyboard (#11346)
2024-05-03 15:15:39 +02:00
project_symbols
…
quick_action_bar
Do not show tooltip for editor controls if clicked (#10679)
2024-04-17 13:20:47 +02:00
recent_projects
Make border methods always require an explicit width (#11450)
2024-05-06 13:22:47 -04:00
refineable
…
release_channel
linux cli (#11585)
2024-05-09 21:08:49 -06:00
rich_text
New revision of the Assistant Panel (#10870)
2024-04-23 16:23:26 -07:00
rope
Revert "Revert "language: Remove buffer fingerprinting (#9007)"" (#9671)
2024-04-12 18:40:35 +02:00
rpc
remoting: Edit dev server (#11344)
2024-05-06 12:58:11 +02:00
search
Introduce DisplayRow, MultiBufferRow newtypes and BufferRow type alias (#11656)
2024-05-11 00:06:51 +03:00
semantic_index
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
semantic_version
…
settings
Don't log JSON parse errors with no settings (#11459)
2024-05-06 14:55:44 -06:00
snippet
…
sqlez
Rename RemoteProject -> DevServerProject (#11301)
2024-05-02 11:00:08 -06:00
sqlez_macros
…
story
Introduce a new markdown crate (#11556)
2024-05-09 11:03:33 +02:00
storybook
Add Tool Strip (#11756)
2024-05-13 17:58:08 -04:00
sum_tree
Update docstring for SumTree (#10927)
2024-04-24 14:01:10 +02:00
supermaven
Add xtask for finding crates with missing licenses (#11776)
2024-05-13 18:52:12 -04:00
supermaven_api
Add xtask for finding crates with missing licenses (#11776)
2024-05-13 18:52:12 -04:00
tab_switcher
Introduce recent files ambient context for assistant (#11791)
2024-05-14 13:48:36 +02:00
task
tasks: Reorganize task modal (#11752)
2024-05-14 11:22:09 +02:00
tasks_ui
tasks: Reorganize task modal (#11752)
2024-05-14 11:22:09 +02:00
telemetry_events
Report response latency and errors when using (inline) assistant (#11806)
2024-05-14 18:18:26 +02:00
terminal
terminal: Fix Alacritty key bindings (#11782)
2024-05-14 11:09:21 +02:00
terminal_view
gpui: Pass Style by value to request_layout (#11597)
2024-05-09 11:38:53 +02:00
text
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
theme
Adjust names of negated style methods (#11453)
2024-05-06 13:56:25 -04:00
theme_importer
Rust 1.78 (#11314)
2024-05-05 15:02:50 +02:00
theme_selector
…
time_format
Inline git blame (#10398)
2024-04-15 14:21:52 +02:00
ui
wayland: Window controls and drag (#11525)
2024-05-14 09:44:55 -07:00
ui_text_field
Make border methods always require an explicit width (#11450)
2024-05-06 13:22:47 -04:00
util
Extract http from util (#11680)
2024-05-10 15:50:20 -06:00
vcs_menu
vcs menu: Use project's repositories, do not open directly (#11652)
2024-05-10 11:06:32 +02:00
vim
vim test redux (#11709)
2024-05-11 14:04:05 -04:00
welcome
Supermaven (#10788)
2024-05-03 12:50:42 -07:00
workspace
Introduce recent files ambient context for assistant (#11791)
2024-05-14 13:48:36 +02:00
worktree
git: Support git repos with .git folder above project root (#11550)
2024-05-14 18:34:51 +02:00
zed
shell: Load SHELL from passwd entry if launched as desktop app (#11758)
2024-05-14 10:16:55 +02:00
zed_actions
…