oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
3d6722be9abf94af5680a3323b69a452154c55b2
oak-gpui/crates
T
History
joel 3d6722be9a Fix Right Alt key not working in keybindings on Windows (#40536) 
### Problem
On Windows, the right Alt key was not working in keybindings (e.g.,
`Ctrl+Right Alt+B`), while the left Alt key worked correctly. This was
due to overly aggressive AltGr detection that treated any `right Alt +
left Ctrl` combination as AltGr, even on US keyboards where AltGr
doesn't exist.

### Root Cause
Windows internally represents AltGr (Alt Graph) as `right Alt + left
Ctrl` pressed simultaneously. The previous implementation always
excluded this combination from being treated as regular modifier keys to
support international keyboards. However, this broke keybindings using
right Alt on US/UK keyboards where users expect right Alt to behave
identically to left Alt.

### Solution
Implemented keyboard layout-aware AltGr detection:

1. Added `uses_altgr()` method to `WindowsKeyboardLayout` that checks if
the current keyboard layout is known to use AltGr (German, French,
Spanish, Polish, etc.)
2. Modified `current_modifiers()` to only apply AltGr special handling
when the keyboard layout actually uses it
3. Added explicit checking for both `VK_LMENU` and `VK_RMENU` instead of
relying solely on the generic `VK_MENU`

### Behavior
- **US/UK keyboards**: Right Alt now works identically to left Alt in
keybindings. `Ctrl+Right Alt+B` triggers the same action as `Ctrl+Left
Alt+B`
- **International keyboards** (German, French, Spanish, etc.): AltGr
continues to work correctly for typing special characters and doesn't
trigger keybindings
- **All keyboards**: Both Alt keys are detected symmetrically, matching
the behavior of left/right Windows keys

### Testing
Manually tested on Windows with US keyboard layout:
-  `Ctrl+Left Alt+B` triggers keybinding
-  `Ctrl+Right Alt+B` triggers keybinding  
-  Both Alt keys work independently in keybindings


Release Notes:
- Fixed Right Alt key not working in keybindings on Windows
2025-10-18 02:27:45 +02:00
..
acp_thread
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
acp_tools
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
action_log
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
activity_indicator
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
agent
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
agent_servers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
agent_settings
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
agent_ui
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
ai_onboarding
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
anthropic
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
askpass
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assets
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_context
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_command
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_commands
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
audio
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
auto_update
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
auto_update_helper
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
auto_update_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
aws_http_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
bedrock
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
breadcrumbs
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
buffer_diff
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
call
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
channel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cli
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
clock
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_api_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_api_types
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_llm_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_zeta2_prompt
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
codestral
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
collab
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
collab_ui
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
collections
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
command_palette
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
command_palette_hooks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
component
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
context_server
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
copilot
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
crashes
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
credentials_provider
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
dap
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
dap_adapters
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
db
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debug_adapter_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debugger_tools
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debugger_ui
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
deepseek
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
denoise
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
diagnostics
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
docs_preprocessor
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
edit_prediction
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
edit_prediction_button
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
edit_prediction_context
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
editor
Re-register buffers on server stop (#40504)
2025-10-17 21:04:08 +00:00
eval
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
explorer_command_injector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extension_api
Windows: Fix issues with paths in extensions (#37811)
2025-09-11 13:56:06 -07:00
extension_cli
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extension_host
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extensions_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
feature_flags
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
feedback
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
file_finder
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
file_icons
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fs
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fs_benchmarks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fsevent
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fuzzy
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
git
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
git_hosting_providers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
git_ui
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
go_to_line
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
google_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
gpui
Fix Right Alt key not working in keybindings on Windows (#40536)
2025-10-18 02:27:45 +02:00
gpui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
gpui_tokio
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
html_to_markdown
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
http_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
http_client_tls
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
icons
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
image_viewer
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
inspector_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
install_cli
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
journal
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
json_schema_store
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
keymap_editor
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_model
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_models
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_onboarding
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_tools
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
languages
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
line_ending_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
livekit_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
livekit_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
lmstudio
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
lsp
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
markdown
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
markdown_preview
markdown_preview: Improve the link decoration logic (#39905)
2025-10-17 19:43:44 -03:00
media
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
menu
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
migrator
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
mistral
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
multi_buffer
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
nc
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
net
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
node_runtime
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
notifications
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ollama
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
onboarding
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
open_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
open_router
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
outline
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
outline_panel
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
panel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
paths
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
picker
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
prettier
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
project
Disallow rename/copy/delete on unshared files (#40540)
2025-10-17 22:33:08 +00:00
project_panel
Disallow rename/copy/delete on unshared files (#40540)
2025-10-17 22:33:08 +00:00
project_symbols
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
prompt_store
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
proto
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
recent_projects
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
refineable
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
release_channel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
remote
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
remote_server
Set the minimum log level to info for the remote server (#40543)
2025-10-17 18:32:52 -04:00
repl
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
reqwest_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rich_text
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rope
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rpc
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rules_library
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
scheduler
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
schema_generator
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
search
perf: Add on search + fixups (#40537)
2025-10-17 22:11:09 +00:00
semantic_version
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
session
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings
settings_ui: Fix stepper buttons to Inactive Opacity to 0.1 increment adjustments (#40477)
2025-10-17 23:12:05 +00:00
settings_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings_profile_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings_ui
settings_ui: Fix stepper buttons to Inactive Opacity to 0.1 increment adjustments (#40477)
2025-10-17 23:12:05 +00:00
snippet
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
snippet_provider
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
snippets_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
story
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
storybook
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
streaming_diff
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sum_tree
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
supermaven
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
supermaven_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
svg_preview
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
system_specs
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
tab_switcher
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
task
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
tasks_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
telemetry
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
telemetry_events
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
terminal
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
terminal_view
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
text
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_importer
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
time_format
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
title_bar
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
toolchain_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ui_input
settings_ui: Fix stepper buttons to Inactive Opacity to 0.1 increment adjustments (#40477)
2025-10-17 23:12:05 +00:00
ui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ui_prompt
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
util
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
util_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vercel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vim
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
vim_mode_setting
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
watch
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search_providers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
workspace
settings_ui: Fix stepper buttons to Inactive Opacity to 0.1 increment adjustments (#40477)
2025-10-17 23:12:05 +00:00
worktree
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
worktree_benchmarks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
x_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zed
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
zed_actions
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zed_env_vars
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zeta
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zeta2
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zeta2_tools
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zeta_cli
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zlog
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zlog_settings
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00