Kirill BulatovandPiotr Osiewicz 95c045ad93 Fix LSP violation when dismissing server notifications (#23531) ...

Part of https://github.com/zed-industries/zed/issues/22606
Closes https://github.com/zed-industries/zed/issues/23509

When a user sees an odd notification from the language server like

<img width="508" alt="image"
src="https://github.com/user-attachments/assets/6f5ef1aa-0f09-4705-a02a-aaf81dd8620c"
/>

they usually dismiss that.

Zed uses channels to wait and handle user interactions with such
notifications, and, due to `?`, sends back
```json
{"jsonrpc":"2.0","id":1,"error":{"message":"receiving from an empty and closed channel"}}
```

which is not spec-compliant:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showMessageRequest

> Response:
>
> * result: the selected
[MessageActionItem](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#messageActionItem)
| null if none got selected.
> * error: code and message set in case an exception happens during
showing a message.

Unfortunately, vtsls (and, potentially, others) crash if receive such
non-compliant requests, and do not get back.

After the fix, the message is correct:
```json
{"jsonrpc":"2.0","id":1,"result":null}
```


Release Notes:

- Fixed vtsls crashing on notification dismiss

Co-authored-by: Piotr Osiewicz <piotr@zed.dev>

2025-01-23 13:30:35 +00:00

..

lsp_command

use ssh lsp store (#17655)

2024-09-10 15:51:01 -04:00

project_tree

project: Reorder LSP Adapters within LanguageRegistry (#23528)

2025-01-23 12:03:37 +00:00

buffer_store.rs

deps: Bump smol to 2.0 (#22956)

2025-01-10 13:38:00 +00:00

color_extractor.rs

Simplify static expression to a constant (#23193)

2025-01-15 19:31:21 +00:00

connection_manager.rs

chore: Fix several style lints (#17488)

2024-09-06 11:58:39 +02:00

debounced_delay.rs

chore: Fix several style lints (#17488)

2024-09-06 11:58:39 +02:00

direnv.rs

Environment loading fixes (#19144)

2024-10-16 12:14:40 +02:00

environment.rs

environments: Don't load shell environments in non-local worktrees (#23138)

2025-01-14 17:13:55 +00:00

git.rs

git: No-op when trying to commit with nothing staged or no commit message (#23491)

2025-01-22 18:04:14 -05:00

image_store.rs

image viewer: Allow dropping images on pane (#21803)

2024-12-10 15:01:14 +01:00

lsp_command.rs

lsp: Use replace edits for completions (#23490)

2025-01-22 21:00:04 +00:00

lsp_ext_command.rs

Include display text for LSP commands in errors (#23012)

2025-01-11 21:59:06 +00:00

lsp_store.rs

Fix LSP violation when dismissing server notifications (#23531)

2025-01-23 13:30:35 +00:00

prettier_store.rs

project: Allow running multiple instances of a single language server within a single worktree (#23473)

2025-01-22 21:19:02 +01:00

project_settings.rs

Document git.gutter_debounce setting (#22663)

2025-01-06 18:33:04 +00:00

project_tests.rs

project: Allow running multiple instances of a single language server within a single worktree (#23473)

2025-01-22 21:19:02 +01:00

project_tree.rs

project: Allow running multiple instances of a single language server within a single worktree (#23473)

2025-01-22 21:19:02 +01:00

project.rs

Omit tsdk_path from the servers' options if it does not exist (#23525)

2025-01-23 11:17:32 +00:00

search_history.rs

project search: Persist search history across session (#9932)

2024-04-02 11:13:18 +02:00

search.rs

Use static LazyLocks for all constant regexes (#22225)

2024-12-19 02:20:35 +00:00

task_inventory.rs

Move git status out of Entry (#22224)

2025-01-04 01:00:16 +00:00

task_store.rs

Fix active line number highlight (#23266)

2025-01-17 01:23:28 +00:00

terminals.rs

terminal: Check for script existence properly before activating it (#23476)

2025-01-23 12:32:21 +01:00

toolchain_store.rs

toolchains: Run listing tasks on background thread (#21414)

2024-12-02 21:03:31 +01:00

worktree_store.rs

git: Implement a basic repository selector (#23419)

2025-01-21 18:11:53 -05:00

yarn.rs

chore: Fix several style lints (#17488)

2024-09-06 11:58:39 +02:00