This PR implements the preview tabs feature from VSCode. More details and thanks for the head start of the implementation here #6782. Here is what I have observed from using the vscode implementation ([x] -> already implemented): - [x] Single click on project file opens tab as preview - [x] Double click on item in project panel opens tab as permanent - [x] Double click on the tab makes it permanent - [x] Navigating away from the tab makes the tab permanent and the new tab is shown as preview (e.g. GoToReference) - [x] Existing preview tab is reused when opening a new tab - [x] Dragging tab to the same/another panel makes the tab permanent - [x] Opening a tab from the file finder makes the tab permanent - [x] Editing a preview tab will make the tab permanent - [x] Using the space key in the project panel opens the tab as preview - [x] Handle navigation history correctly (restore a preview tab as preview as well) - [x] Restore preview tabs after restarting - [x] Support opening files from file finder in preview mode (vscode: "Enable Preview From Quick Open") I need to do some more testing of the vscode implementation, there might be other behaviors/workflows which im not aware of that open an item as preview/make them permanent. Showcase: https://github.com/zed-industries/zed/assets/53836821/9be16515-c740-4905-bea1-88871112ef86 TODOs - [x] Provide `enable_preview_tabs` setting - [x] Write some tests - [x] How should we handle this in collaboration mode (have not tested the behavior so far) - [x] Keyboard driven usage (probably need workspace commands) - [x] Register `TogglePreviewTab` only when setting enabled? - [x] Render preview tabs in tab switcher as italic - [x] Render preview tabs in image viewer as italic - [x] Should this be enabled by default (it is the default behavior in VSCode)? - [x] Docs Future improvements (out of scope for now): - Support preview mode for find all references and possibly other multibuffers (VSCode: "Enable Preview From Code Navigation") Release Notes: - Added preview tabs ([#4922](https://github.com/zed-industries/zed/issues/4922)). --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
135 lines
3.8 KiB
Rust
135 lines
3.8 KiB
Rust
use crate::{
|
|
item::{Item, ItemEvent, TabContentParams},
|
|
ItemNavHistory, WorkspaceId,
|
|
};
|
|
use anyhow::Result;
|
|
use call::participant::{Frame, RemoteVideoTrack};
|
|
use client::{proto::PeerId, User};
|
|
use futures::StreamExt;
|
|
use gpui::{
|
|
div, img, AppContext, Element, EventEmitter, FocusHandle, FocusableView, InteractiveElement,
|
|
ParentElement, Render, SharedString, Styled, Task, View, ViewContext, VisualContext,
|
|
WindowContext,
|
|
};
|
|
use std::sync::{Arc, Weak};
|
|
use ui::{h_flex, prelude::*, Icon, IconName, Label};
|
|
|
|
pub enum Event {
|
|
Close,
|
|
}
|
|
|
|
pub struct SharedScreen {
|
|
track: Weak<RemoteVideoTrack>,
|
|
frame: Option<Frame>,
|
|
pub peer_id: PeerId,
|
|
user: Arc<User>,
|
|
nav_history: Option<ItemNavHistory>,
|
|
_maintain_frame: Task<Result<()>>,
|
|
focus: FocusHandle,
|
|
}
|
|
|
|
impl SharedScreen {
|
|
pub fn new(
|
|
track: &Arc<RemoteVideoTrack>,
|
|
peer_id: PeerId,
|
|
user: Arc<User>,
|
|
cx: &mut ViewContext<Self>,
|
|
) -> Self {
|
|
cx.focus_handle();
|
|
let mut frames = track.frames();
|
|
Self {
|
|
track: Arc::downgrade(track),
|
|
frame: None,
|
|
peer_id,
|
|
user,
|
|
nav_history: Default::default(),
|
|
_maintain_frame: cx.spawn(|this, mut cx| async move {
|
|
while let Some(frame) = frames.next().await {
|
|
this.update(&mut cx, |this, cx| {
|
|
this.frame = Some(frame);
|
|
cx.notify();
|
|
})?;
|
|
}
|
|
this.update(&mut cx, |_, cx| cx.emit(Event::Close))?;
|
|
Ok(())
|
|
}),
|
|
focus: cx.focus_handle(),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl EventEmitter<Event> for SharedScreen {}
|
|
|
|
impl FocusableView for SharedScreen {
|
|
fn focus_handle(&self, _: &AppContext) -> FocusHandle {
|
|
self.focus.clone()
|
|
}
|
|
}
|
|
impl Render for SharedScreen {
|
|
fn render(&mut self, cx: &mut ViewContext<Self>) -> impl IntoElement {
|
|
div()
|
|
.bg(cx.theme().colors().editor_background)
|
|
.track_focus(&self.focus)
|
|
.key_context("SharedScreen")
|
|
.size_full()
|
|
.children(
|
|
self.frame
|
|
.as_ref()
|
|
.map(|frame| img(frame.image()).size_full()),
|
|
)
|
|
}
|
|
}
|
|
|
|
impl Item for SharedScreen {
|
|
type Event = Event;
|
|
|
|
fn tab_tooltip_text(&self, _: &AppContext) -> Option<SharedString> {
|
|
Some(format!("{}'s screen", self.user.github_login).into())
|
|
}
|
|
|
|
fn deactivated(&mut self, cx: &mut ViewContext<Self>) {
|
|
if let Some(nav_history) = self.nav_history.as_mut() {
|
|
nav_history.push::<()>(None, cx);
|
|
}
|
|
}
|
|
|
|
fn tab_content(&self, params: TabContentParams, _: &WindowContext<'_>) -> gpui::AnyElement {
|
|
h_flex()
|
|
.gap_1()
|
|
.child(Icon::new(IconName::Screen))
|
|
.child(
|
|
Label::new(format!("{}'s screen", self.user.github_login)).color(
|
|
if params.selected {
|
|
Color::Default
|
|
} else {
|
|
Color::Muted
|
|
},
|
|
),
|
|
)
|
|
.into_any()
|
|
}
|
|
|
|
fn telemetry_event_text(&self) -> Option<&'static str> {
|
|
None
|
|
}
|
|
|
|
fn set_nav_history(&mut self, history: ItemNavHistory, _: &mut ViewContext<Self>) {
|
|
self.nav_history = Some(history);
|
|
}
|
|
|
|
fn clone_on_split(
|
|
&self,
|
|
_workspace_id: WorkspaceId,
|
|
cx: &mut ViewContext<Self>,
|
|
) -> Option<View<Self>> {
|
|
let track = self.track.upgrade()?;
|
|
Some(cx.new_view(|cx| Self::new(&track, self.peer_id, self.user.clone(), cx)))
|
|
}
|
|
|
|
fn to_item_events(event: &Self::Event, mut f: impl FnMut(ItemEvent)) {
|
|
match event {
|
|
Event::Close => f(ItemEvent::CloseItem),
|
|
}
|
|
}
|
|
}
|